jpountz commented on PR #13472:
URL: https://github.com/apache/lucene/pull/13472#issuecomment-2155882665
Your suggestion is how it used to work before:
https://github.com/apache/lucene/pull/12499/files#diff-e744fc99cb74627f02e30c1cbda56dede66d2ecdfd57db2ce869b9a9a43fa41cR49-R64.
The context
jpountz commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1631987192
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hits,
original-brownbear commented on PR #13472:
URL: https://github.com/apache/lucene/pull/13472#issuecomment-2155894536
> The idea behind this other PR was that you would have a worker executor
that would do almost all the work, and a coordination executor that would be
mostly coordinating work
original-brownbear commented on PR #13472:
URL: https://github.com/apache/lucene/pull/13472#issuecomment-2155919543
> I'm not sure if we're at a point where this coordination executor could
run on virtual threads, but at least conceptually this is how I'm thinking of
it.
That does m
jpountz commented on PR #13472:
URL: https://github.com/apache/lucene/pull/13472#issuecomment-2155964757
Thanks for explaining I had not read your implementation carefully. I agree
that we are doing less blocking than in the previous implementation of this,
though we could still be blocking
original-brownbear commented on PR #13472:
URL: https://github.com/apache/lucene/pull/13472#issuecomment-2155979514
>E.g. if you have two tasks and the first one takes more time?
Right, that's a possible scenario, but unless we move to some kind of async
API like the one you mentione
msokolov commented on code in PR #13469:
URL: https://github.com/apache/lucene/pull/13469#discussion_r1632032521
##
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsReader.java:
##
@@ -217,6 +220,18 @@ public ByteVectorValues getByteVectorValues(String f
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632101139
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632101267
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632104552
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632104552
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
uschindler commented on PR #13471:
URL: https://github.com/apache/lucene/pull/13471#issuecomment-2156173831
Will check tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
dweiss commented on PR #13471:
URL: https://github.com/apache/lucene/pull/13471#issuecomment-2156174240
No worries, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
hack4chang commented on code in PR #13470:
URL: https://github.com/apache/lucene/pull/13470#discussion_r1632111769
##
lucene/core/src/java/org/apache/lucene/search/TopDocs.java:
##
@@ -350,4 +354,38 @@ private static TopDocs mergeAux(
return new TopFieldDocs(totalHits, hi
github-actions[bot] commented on PR #13054:
URL: https://github.com/apache/lucene/pull/13054#issuecomment-2156239861
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
15 matches
Mail list logo
