Re: [PR] Early terminate visit BKD leaf when current value greater than upper point in sorted dim. [lucene]

2024-05-11 Thread via GitHub
vsop-479 commented on PR #12528: URL: https://github.com/apache/lucene/pull/12528#issuecomment-2105633049 @iverase I implemented `visitWithSortedDim` for `pointCount` in `PointRangeQuery`. Please take a look when you get a chance. Or Do you have any other ideas to terminate visiti

Re: [PR] Use `IndexInput#prefetch` for terms dictionary lookups. [lucene]

2024-05-11 Thread via GitHub
jpountz commented on PR #13359: URL: https://github.com/apache/lucene/pull/13359#issuecomment-2105658311 This is a draft as I need to do more work on tests and making sure that this new method cannot corrupt the state of the `SegmentTermsEnum`. But I created a benchmark that start

Re: [I] Multi-value Support for KnnVectorField [lucene]

2024-05-11 Thread via GitHub
krickert commented on issue #12313: URL: https://github.com/apache/lucene/issues/12313#issuecomment-2105745361 I was thinking about this and thought this would be cool with a few different use cases for a multi-valued vector: 1. The multi-values are treated the same as the single valu

Re: [PR] Reduce memory usage of field maps in FieldInfos and BlockTree TermsReader. [lucene]

2024-05-11 Thread via GitHub
bruno-roustant commented on code in PR #13327: URL: https://github.com/apache/lucene/pull/13327#discussion_r1597449679 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -139,17 +148,38 @@ public FieldInfos(FieldInfo[] infos) { this.softDeletesField = so

Re: [PR] Reduce memory usage of field maps in FieldInfos and BlockTree TermsReader. [lucene]

2024-05-11 Thread via GitHub
dsmiley commented on code in PR #13327: URL: https://github.com/apache/lucene/pull/13327#discussion_r1597469133 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -139,17 +148,38 @@ public FieldInfos(FieldInfo[] infos) { this.softDeletesField = softDelet

[PR] Call ArrayUtil.copyOf instead of ArrayUtil.copySubArray for full array copy. [lucene]

2024-05-11 Thread via GitHub
bruno-roustant opened a new pull request, #13360: URL: https://github.com/apache/lucene/pull/13360 ArrayUtil provides copySubArray() as replacement of Array.copyOf and Array.copyOfRange (with better bounds check). Unfortunately ArrayUtil does not provide copyArray(), so it is weird for call

Re: [PR] Reduce memory usage of field maps in FieldInfos and BlockTree TermsReader. [lucene]

2024-05-11 Thread via GitHub
bruno-roustant commented on code in PR #13327: URL: https://github.com/apache/lucene/pull/13327#discussion_r1597476337 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -139,17 +148,38 @@ public FieldInfos(FieldInfo[] infos) { this.softDeletesField = so

Re: [PR] Reduce memory usage of field maps in FieldInfos and BlockTree TermsReader. [lucene]

2024-05-11 Thread via GitHub
bruno-roustant commented on code in PR #13327: URL: https://github.com/apache/lucene/pull/13327#discussion_r1585022423 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -156,15 +139,17 @@ public FieldInfos(FieldInfo[] infos) { this.softDeletesField = so

Re: [PR] Reduce memory usage of field maps in FieldInfos and BlockTree TermsReader. [lucene]

2024-05-11 Thread via GitHub
dsmiley commented on code in PR #13327: URL: https://github.com/apache/lucene/pull/13327#discussion_r1597484741 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -139,17 +148,38 @@ public FieldInfos(FieldInfo[] infos) { this.softDeletesField = softDelet

Re: [PR] Reduce memory usage of field maps in FieldInfos and BlockTree TermsReader. [lucene]

2024-05-11 Thread via GitHub
bruno-roustant commented on code in PR #13327: URL: https://github.com/apache/lucene/pull/13327#discussion_r1597498694 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -156,15 +151,38 @@ public FieldInfos(FieldInfo[] infos) { this.softDeletesField = so

Re: [PR] Reduce memory usage of field maps in FieldInfos and BlockTree TermsReader. [lucene]

2024-05-11 Thread via GitHub
bruno-roustant commented on code in PR #13327: URL: https://github.com/apache/lucene/pull/13327#discussion_r1597498694 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -156,15 +151,38 @@ public FieldInfos(FieldInfo[] infos) { this.softDeletesField = so

Re: [PR] Use `IndexInput#prefetch` for terms dictionary lookups. [lucene]

2024-05-11 Thread via GitHub
rmuir commented on code in PR #13359: URL: https://github.com/apache/lucene/pull/13359#discussion_r1597522761 ## lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnum.java: ## @@ -307,6 +309,31 @@ private boolean setEOF() { return true; } +