stefanvodita commented on PR #13300:
URL: https://github.com/apache/lucene/pull/13300#issuecomment-2088157884
I went through this change once more to make sure it's safe to push. I would
still like a second opinion, just in case I'm missing something, otherwise I'll
merge this in a few days
dweiss commented on PR #12131:
URL: https://github.com/apache/lucene/pull/12131#issuecomment-2088223120
Ah, I see your point. The only crude workaround I see for now is to set
those props via an environment variable - these should be picked up by all
included builds. For example, when I run
stefanvodita commented on PR #13300:
URL: https://github.com/apache/lucene/pull/13300#issuecomment-2088360624
Thank you for the review Mike! I did have to change a couple things:
1. Added a new constructor to `TaxonomyFacets`, which takes a
`FacetsCollector`, since I couldn't change the e
benwtrent commented on PR #13321:
URL: https://github.com/apache/lucene/pull/13321#issuecomment-2088378164
@uschindler I addressed your comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
uschindler commented on PR #13321:
URL: https://github.com/apache/lucene/pull/13321#issuecomment-2088443326
To me changes look fine.
For discussion: In my opinion the conditional code falling back to defaults
should possibly be moved to the VectorUtil class and i think them the boolea
benwtrent merged PR #13321:
URL: https://github.com/apache/lucene/pull/13321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
benwtrent commented on PR #13181:
URL: https://github.com/apache/lucene/pull/13181#issuecomment-2088865803
This is my first attempt at a new interface for exact search.
We are missing performance improvements through quantization and have a
fairly complex API for exact search, requiri
benwtrent opened a new pull request, #1:
URL: https://github.com/apache/lucene/pull/1
The flaky test failure is due to score tie-breaking by doc id. To avoid
requiring document id order from being consistent (thus reducing randomness in
the test), this commit ensures all bit vectors
dnhatn closed issue #11079: Duplication computation for TieredMergePolicy's
numDeletesToMerge [LUCENE-10041]
URL: https://github.com/apache/lucene/issues/11079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dnhatn commented on issue #11079:
URL: https://github.com/apache/lucene/issues/11079#issuecomment-2089073368
Fixed in #12339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zacharymorn closed pull request #12890: [WIP] LUCENE-10002: Deprecate
FacetsCollector#search helper methods as they internally use
IndexSearcher#search(Query, Collector) API
URL: https://github.com/apache/lucene/pull/12890
--
This is an automated message from the Apache Git Service.
To respo
zacharymorn opened a new pull request, #13334:
URL: https://github.com/apache/lucene/pull/13334
This is a follow-up PR for https://github.com/apache/lucene/pull/12890,
where we have agreement that FacetsCollector#search helper methods can be
deprecated without replacement.
Build succ
shubhamvishu commented on code in PR #13328:
URL: https://github.com/apache/lucene/pull/13328#discussion_r1586937485
##
lucene/core/src/java/org/apache/lucene/util/TermAndVector.java:
##
@@ -24,23 +24,7 @@
*
* @lucene.experimental
*/
-public class TermAndVector {
-
- priv
shubhamvishu commented on code in PR #13328:
URL: https://github.com/apache/lucene/pull/13328#discussion_r1586937857
##
lucene/core/src/java/org/apache/lucene/search/CollectionStatistics.java:
##
@@ -116,7 +105,8 @@ public CollectionStatistics(
*
* @return field's name,
shubhamvishu commented on code in PR #13328:
URL: https://github.com/apache/lucene/pull/13328#discussion_r1586937659
##
lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java:
##
@@ -171,14 +171,7 @@ public final float overheadRatio(int bitsPerValue) {
}
/**
shubhamvishu commented on PR #13328:
URL: https://github.com/apache/lucene/pull/13328#issuecomment-2089321284
I addressed your comments in the new revision and all the checks are passing
now after your fix. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on PR #13143:
URL: https://github.com/apache/lucene/pull/13143#issuecomment-2089326240
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
jainankitk commented on issue #13335:
URL: https://github.com/apache/lucene/issues/13335#issuecomment-2089338809
Looks related to #9814, but there are differences between the two. As
discussed offline with @bowenlan and @rishabhmaurya, MultiRangeQuery only tells
what matches with your multi
shubhamvishu commented on code in PR #13328:
URL: https://github.com/apache/lucene/pull/13328#discussion_r1586937485
##
lucene/core/src/java/org/apache/lucene/util/TermAndVector.java:
##
@@ -24,23 +24,7 @@
*
* @lucene.experimental
*/
-public class TermAndVector {
-
- priv
iamsanjay commented on code in PR #13319:
URL: https://github.com/apache/lucene/pull/13319#discussion_r1587080630
##
lucene/core/src/java/org/apache/lucene/document/BinaryRangeFieldRangeQuery.java:
##
@@ -136,7 +136,18 @@ public float matchCost() {
}
20 matches
Mail list logo
