Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-27 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1581809438 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-27 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1581809438 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-27 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1581809438 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-27 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1581809438 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-27 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1581809438 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [PR] Performance improvements to use read lock to access LRUQueryCache [lucene]

2024-04-27 Thread via GitHub
boicehuang commented on code in PR #13306: URL: https://github.com/apache/lucene/pull/13306#discussion_r1581809438 ## lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java: ## @@ -265,7 +269,6 @@ boolean requiresEviction() { } CacheAndCount get(Query key, Inde

Re: [I] Decouple within-query concurrency from the index's segment geometry [LUCENE-8675] [lucene]

2024-04-27 Thread via GitHub
msokolov commented on issue #9721: URL: https://github.com/apache/lucene/issues/9721#issuecomment-2080592940 I guess we can use the new "parent field" to enforce that intervals must end on a non-child document, and we have to refuse to attempt query execution over sub-leaf interval if there

Re: [I] MIGRATE.md doesn't mention the transition from Collector to CollectorManager [lucene]

2024-04-27 Thread via GitHub
mikemccand commented on issue #13218: URL: https://github.com/apache/lucene/issues/13218#issuecomment-2080640729 > is this for 10.0.0 This is for 10.0.0, yes, but is also helpful when upgrading to 9.x since these APIs are deprecated there (and removed in 10.0). @zacharymorn --

Re: [PR] Backport to 9x: Initialize facet counting data structures lazily #12408 [lucene]

2024-04-27 Thread via GitHub
github-actions[bot] commented on PR #13300: URL: https://github.com/apache/lucene/pull/13300#issuecomment-2081261294 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi