Re: [PR] Deprecate COSINE VectorSimilarity function [lucene]

2024-04-18 Thread via GitHub
Pulkitg64 commented on PR #13308: URL: https://github.com/apache/lucene/pull/13308#issuecomment-2063164324 Thanks @jpountz for confirming and suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] [RFC] Improve skipping logic for after values in sort query [lucene]

2024-04-18 Thread via GitHub
gashutos commented on issue #13313: URL: https://github.com/apache/lucene/issues/13313#issuecomment-2064607809 >Is my understanding correct that this would possibly help with deep pagination but hurt with the first few pages since it may force Lucene to evaluate a BKD range query that match

Re: [I] [RFC] Improve skipping logic for after values in sort query [lucene]

2024-04-18 Thread via GitHub
gashutos commented on issue #13313: URL: https://github.com/apache/lucene/issues/13313#issuecomment-2064611467 I was thinking if we can make these threshold `12%`, `20%` etc configurable by Lucene config as well to give more conrtol to end user to fine tune based on workload. -- This is

Re: [I] [RFC] Improve skipping logic for after values in sort query [lucene]

2024-04-18 Thread via GitHub
jpountz commented on issue #13313: URL: https://github.com/apache/lucene/issues/13313#issuecomment-2065276145 I'd rather not make this configurable, but if you can suggest a new threshold that works better for this adversarial case and doesn't hurt sorted queries such as tasks from nightly

Re: [PR] upgrade commons codec from 1.13.0 to 1.16.0 [lucene]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #13269: URL: https://github.com/apache/lucene/pull/13269#issuecomment-2065522805 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Make Lucene90 postings format to write FST off heap [lucene]

2024-04-18 Thread via GitHub
github-actions[bot] commented on PR #12985: URL: https://github.com/apache/lucene/pull/12985#issuecomment-2065523143 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi