Re: [PR] Move synonym map off-heap for SynonymGraphFilter [lucene]

2024-02-09 Thread via GitHub
msfroh commented on PR #13054: URL: https://github.com/apache/lucene/pull/13054#issuecomment-1935491971 I decided to try experimenting with moving the output words back onto the heap, since I didn't the fact that every word lookup was triggering a seek. Running now, I got way less va

Re: [PR] Bump release to Java 21 [lucene]

2024-02-09 Thread via GitHub
ChrisHegarty commented on PR #12753: URL: https://github.com/apache/lucene/pull/12753#issuecomment-1935727748 At the moment we're just using this PR to ensure build and tests of _main_ are ok with Java 21. In order to make sure we're ready to bump when the time comes. -- This is an autom

Re: [PR] upgrade to OpenNLP 2.3.2 [lucene]

2024-02-09 Thread via GitHub
cpoerschke commented on PR #12674: URL: https://github.com/apache/lucene/pull/12674#issuecomment-1935747334 > ... perhaps fire an email to legal at apache, asking ... Good idea, will do. And thanks for reviewing also with this in mind! -- This is an automated message from th

Re: [PR] upgrade to OpenNLP 2.3.2 [lucene]

2024-02-09 Thread via GitHub
cpoerschke merged PR #12674: URL: https://github.com/apache/lucene/pull/12674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [PR] upgrade to OpenNLP 2.3.2 [lucene]

2024-02-09 Thread via GitHub
cpoerschke commented on PR #12674: URL: https://github.com/apache/lucene/pull/12674#issuecomment-1935802081 > > ... perhaps fire an email to legal at apache, asking ... > > Good idea, will do. And thanks for reviewing also with this in mind! https://issues.apache.org/jira/browse

Re: [PR] Enable MemorySegment in MMapDirectory for Java 22+ and Vectorization (incubation) for exact Java 22 [lucene]

2024-02-09 Thread via GitHub
uschindler commented on PR #12706: URL: https://github.com/apache/lucene/pull/12706#issuecomment-1935816905 The release candidate is still missing and wasn't announced by Mark Reinhold: https://jdk.java.net/22/ -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]

2024-02-09 Thread via GitHub
sabi0 commented on code in PR #13068: URL: https://github.com/apache/lucene/pull/13068#discussion_r1484475836 ## lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java: ## @@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) { privat

Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]

2024-02-09 Thread via GitHub
dweiss commented on code in PR #13068: URL: https://github.com/apache/lucene/pull/13068#discussion_r1484540199 ## lucene/core/src/java/org/apache/lucene/util/ToStringUtils.java: ## @@ -32,11 +32,37 @@ public static void byteArray(StringBuilder buffer, byte[] bytes) { priva

Re: [PR] Modernize BWC testing with parameterized tests [lucene]

2024-02-09 Thread via GitHub
HoustonPutman commented on PR #13046: URL: https://github.com/apache/lucene/pull/13046#issuecomment-1936231183 So I just finished the 8.11.3 release, and had some problems with the back-compat testing code. Obviously the ant/gradle switch and jdk versions meant that I had to do a lot of it

Re: [PR] Add necessary assertion in CheckHits#doCheckMaxScores [lucene]

2024-02-09 Thread via GitHub
jpountz merged PR #13088: URL: https://github.com/apache/lucene/pull/13088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Bump release to Java 21 [lucene]

2024-02-09 Thread via GitHub
rmuir commented on PR #12753: URL: https://github.com/apache/lucene/pull/12753#issuecomment-1936554932 I did `git grep 17` and sifted through the noise, there's just no substitute, quickly fixed a bunch of stuff. sorry for any build breakage if it happens :) still need to update `rel

Re: [PR] Enable MemorySegment in MMapDirectory for Java 22+ and Vectorization (incubation) for exact Java 22 [lucene]

2024-02-09 Thread via GitHub
uschindler commented on PR #12706: URL: https://github.com/apache/lucene/pull/12706#issuecomment-1936659871 JDK release candidate was announced (it is build 35). I downloaded and tested it with vector and foreign API, no API breaks detected. Tests work. I will merge this now. -- Th

Re: [PR] Enable MemorySegment in MMapDirectory for Java 22+ and Vectorization (incubation) for exact Java 22 [lucene]

2024-02-09 Thread via GitHub
uschindler merged PR #12706: URL: https://github.com/apache/lucene/pull/12706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[PR] Make `static final Map` constants immutable [lucene]

2024-02-09 Thread via GitHub
sabi0 opened a new pull request, #13092: URL: https://github.com/apache/lucene/pull/13092 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai