[PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]

2024-02-03 Thread via GitHub
sabi0 opened a new pull request, #13068: URL: https://github.com/apache/lucene/pull/13068 I noticed there are `brToString()` methods in 16 different classes. What do you think of providing a shared implementation in the `ToStringUtils` class? If you find the proposal useful I will

Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]

2024-02-03 Thread via GitHub
almogtavor commented on PR #13068: URL: https://github.com/apache/lucene/pull/13068#issuecomment-1925313927 @sabi0 i think you should also migrate these 16 classes to use the method from the `ToStringUtils` -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Move `brToString(BytesRef)` to `ToStringUtils` [lucene]

2024-02-03 Thread via GitHub
sabi0 commented on PR #13068: URL: https://github.com/apache/lucene/pull/13068#issuecomment-1925314365 That's what I meant with > I will proceed with removing the other copies Did not want to waste time on this in case the suggestion would be rejected. I will push the changes

Re: [PR] LUCENE-4056: Japanese Tokenizer (Kuromoji) cannot build UniDic dictionary [lucene]

2024-02-03 Thread via GitHub
azagniotov commented on PR #12517: URL: https://github.com/apache/lucene/pull/12517#issuecomment-1925374230 Hi @uschindler , I wanted to ping you and see if you have any thoughts on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Throw CorruptSegmentInfoException on encountering missing segment info (_N.si) file in CheckIndex [lucene]

2024-02-03 Thread via GitHub
github-actions[bot] commented on PR #12872: URL: https://github.com/apache/lucene/pull/12872#issuecomment-1925496330 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

[PR] Fix NPE in TestReqOptSumScorer.testFilterRandomRareOpt [lucene]

2024-02-03 Thread via GitHub
easyice opened a new pull request, #13069: URL: https://github.com/apache/lucene/pull/13069 The value `C` of field `f` may not appear in all segments. ``` > java.lang.NullPointerException: Cannot invoke "org.apache.lucene.search.Scorer.twoPhaseIterator()" because "s2" is