Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-02-02 Thread via GitHub
tveasey commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1475846853 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -79,24 +83,32 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOExcept

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-02-02 Thread via GitHub
jimczi commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1475878963 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -79,24 +83,32 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOExcepti

Re: [I] Re-explore the logic around when Vector search should be Exact [lucene]

2024-02-02 Thread via GitHub
benwtrent commented on issue #12505: URL: https://github.com/apache/lucene/issues/12505#issuecomment-1924087207 Note, we no longer hit the graph when asking for more docs than are in the segment (even when not using a filter) https://github.com/apache/lucene/pull/12806 But ther

[PR] Support getMaxScore of DisjunctionSumScorer for non top level scoring… [lucene]

2024-02-02 Thread via GitHub
mrkm4ntr opened a new pull request, #13066: URL: https://github.com/apache/lucene/pull/13066 … clause ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-02-02 Thread via GitHub
mayya-sharipova commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1476532664 ## lucene/core/src/java/org/apache/lucene/search/knn/KnnCollectorManager.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-02-02 Thread via GitHub
mayya-sharipova commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1476712259 ## lucene/core/src/java/org/apache/lucene/index/LeafReader.java: ## @@ -236,27 +235,24 @@ public final PostingsEnum postings(Term term) throws IOException {

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-02-02 Thread via GitHub
mayya-sharipova commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1476712594 ## lucene/core/src/java/org/apache/lucene/index/LeafReader.java: ## @@ -277,27 +273,24 @@ public final TopDocs searchNearestVectors( * * @param field t

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-02-02 Thread via GitHub
mayya-sharipova commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1476712873 ## lucene/core/src/java/org/apache/lucene/search/knn/KnnCollectorManager.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-02-02 Thread via GitHub
mayya-sharipova commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1476532664 ## lucene/core/src/java/org/apache/lucene/search/knn/KnnCollectorManager.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-02-02 Thread via GitHub
mayya-sharipova commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1476713535 ## lucene/core/src/java/org/apache/lucene/search/TopKnnCollector.java: ## @@ -27,25 +29,78 @@ */ public final class TopKnnCollector extends AbstractKnnColle

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-02-02 Thread via GitHub
mayya-sharipova commented on PR #12962: URL: https://github.com/apache/lucene/pull/12962#issuecomment-1924675805 @benwtrent @jimczi Thanks for your great feedback, with the latest changes I tried to address your comments, please check if need something else. -- This is an automated messag

Re: [PR] Use growNoCopy in some places [lucene]

2024-02-02 Thread via GitHub
github-actions[bot] commented on PR #12951: URL: https://github.com/apache/lucene/pull/12951#issuecomment-1924928770 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi