Re: [PR] Split taxonomy arrays across chunks [lucene]

2024-01-20 Thread via GitHub
msfroh commented on code in PR #12995: URL: https://github.com/apache/lucene/pull/12995#discussion_r1460625252 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java: ## @@ -68,25 +94,66 @@ public TaxonomyIndexArrays(IndexReader reader, Tax

Re: [PR] Split taxonomy arrays across chunks [lucene]

2024-01-20 Thread via GitHub
msfroh commented on PR #12995: URL: https://github.com/apache/lucene/pull/12995#issuecomment-1902249764 > @msfroh - I left just one more nitpicky comment. Can you also add a CHANGES entry? I would be happy to merge the PR after. Done! I also tweaked the bounds for `testThousan

Re: [PR] Split taxonomy arrays across chunks [lucene]

2024-01-20 Thread via GitHub
stefanvodita commented on PR #12995: URL: https://github.com/apache/lucene/pull/12995#issuecomment-1902258322 Thank you! I think the PR is in good shape. I'll leave it up for a couple days and then merge if no one else comments. -- This is an automated message from the Apache Git Service.