Re: [PR] Use growNoCopy in some places [lucene]

2024-01-19 Thread via GitHub
easyice commented on code in PR #12951: URL: https://github.com/apache/lucene/pull/12951#discussion_r1458564693 ## lucene/core/src/java/org/apache/lucene/util/fst/Util.java: ## Review Comment: Nice find! Thank you @epotyom ! -- This is an automated message from the Apac

Re: [I] What if we pick up segments in segment size's ascending order in TieredMergePolicy.doFindMerges? [lucene]

2024-01-19 Thread via GitHub
vsop-479 commented on issue #13022: URL: https://github.com/apache/lucene/issues/13022#issuecomment-1900060071 Out of curiosity, i measured the method performance in both pick up order, by add a test case in `TestTieredMergePolicy`(without assert): seg count | baseline(desc pick) | c

Re: [PR] Use growNoCopy in some places [lucene]

2024-01-19 Thread via GitHub
easyice commented on PR #12951: URL: https://github.com/apache/lucene/pull/12951#issuecomment-1900247470 Thank you for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Enable CheckIndex to exorcise segments with missing segment infos (.si) (#7820) [lucene]

2024-01-19 Thread via GitHub
gokaai commented on code in PR #12872: URL: https://github.com/apache/lucene/pull/12872#discussion_r1459040185 ## lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java: ## @@ -389,13 +386,25 @@ private static void parseSegmentInfos( } long totalDocs = 0; +

Re: [PR] Throw CorruptSegmentInfoException on encountering missing segment info (_N.si) file in CheckIndex [lucene]

2024-01-19 Thread via GitHub
gokaai commented on PR #12872: URL: https://github.com/apache/lucene/pull/12872#issuecomment-1900475365 I edited the PR description to more accurately represent what is being done. We aren't dealing with the exorcism issue yet, but throwing the right exception on encountering missing segmen

[PR] Add Stefan Vodita as committer [lucene-site]

2024-01-19 Thread via GitHub
stefanvodita opened a new pull request, #74: URL: https://github.com/apache/lucene-site/pull/74 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Add Stefan Vodita as committer [lucene-site]

2024-01-19 Thread via GitHub
stefanvodita merged PR #74: URL: https://github.com/apache/lucene-site/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

Re: [PR] Run BWC indices generation code together with unittest [lucene]

2024-01-19 Thread via GitHub
s1monw merged PR #13023: URL: https://github.com/apache/lucene/pull/13023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Split taxonomy arrays across chunks [lucene]

2024-01-19 Thread via GitHub
stefanvodita commented on code in PR #12995: URL: https://github.com/apache/lucene/pull/12995#discussion_r1459792589 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/directory/TaxonomyIndexArrays.java: ## @@ -68,25 +94,66 @@ public TaxonomyIndexArrays(IndexReader reader