Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-01-17 Thread via GitHub
mayya-sharipova commented on PR #12962: URL: https://github.com/apache/lucene/pull/12962#issuecomment-1895612417 > It's also important to check the order of execution. For instance what happens if all segments are executed serially (rather than in parallel), does it changes the recall?

Re: [PR] Fix BWC test generation after mondernizing LineDocFile [lucene]

2024-01-17 Thread via GitHub
jpountz commented on code in PR #13021: URL: https://github.com/apache/lucene/pull/13021#discussion_r1455491681 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java: ## @@ -219,22 +228,48 @@ public void testCreateMoreTermsIndex() th

Re: [PR] Fix BWC test generation after mondernizing LineDocFile [lucene]

2024-01-17 Thread via GitHub
s1monw commented on code in PR #13021: URL: https://github.com/apache/lucene/pull/13021#discussion_r1455526064 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java: ## @@ -219,22 +228,48 @@ public void testCreateMoreTermsIndex() thr

Re: [PR] Fix BWC test generation after mondernizing LineDocFile [lucene]

2024-01-17 Thread via GitHub
jpountz commented on code in PR #13021: URL: https://github.com/apache/lucene/pull/13021#discussion_r1455533959 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java: ## @@ -219,22 +228,48 @@ public void testCreateMoreTermsIndex() th

Re: [PR] Fix BWC test generation after mondernizing LineDocFile [lucene]

2024-01-17 Thread via GitHub
s1monw merged PR #13021: URL: https://github.com/apache/lucene/pull/13021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-01-17 Thread via GitHub
tveasey commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1455672480 ## lucene/core/src/java/org/apache/lucene/util/hnsw/BlockingFloatHeap.java: ## @@ -0,0 +1,190 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-01-17 Thread via GitHub
tveasey commented on PR #12962: URL: https://github.com/apache/lucene/pull/12962#issuecomment-1895920963 > This makes an interval of 255 a reasonable choice. I agree. This looks better to me. One thing I would be intrigued to try is the slight change in schedules as per [this](https:

Re: [I] Cut over HNSW's neighbor lists to group-varint? [lucene]

2024-01-17 Thread via GitHub
easyice commented on issue #12871: URL: https://github.com/apache/lucene/issues/12871#issuecomment-1896075935 Hi Adrien, i tried the idea, this will got a ~10% speedup on JHM output, which is slightly less because it needs an extra loop to decode the delta. The benchmark using neighb

Re: [PR] Enable CheckIndex to exorcise segments with missing segment infos (.si) (#7820) [lucene]

2024-01-17 Thread via GitHub
github-actions[bot] commented on PR #12872: URL: https://github.com/apache/lucene/pull/12872#issuecomment-1897533423 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi