Re: [PR] Fix Field.java documentation to refer to new IntField/FloatField/LongField/DoubleField #12125 [lucene]

2024-01-15 Thread via GitHub
SreehariG73 commented on PR #12821: URL: https://github.com/apache/lucene/pull/12821#issuecomment-1891530573 Hello Adrien, I have made changes to the PR. Please review the same and let me know if it looks good regards, Sreehari Guruprasad On Mon, Jan 8, 2024 at 6:08

Re: [I] Fix Field.java documentation to refer to new IntField/FloatField/LongField/DoubleField [lucene]

2024-01-15 Thread via GitHub
jpountz closed issue #12125: Fix Field.java documentation to refer to new IntField/FloatField/LongField/DoubleField URL: https://github.com/apache/lucene/issues/12125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Fixed Field.java documentation to refer to new IntField/FloatField/Lo… [lucene]

2024-01-15 Thread via GitHub
jpountz merged PR #13012: URL: https://github.com/apache/lucene/pull/13012 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Fix Field.java documentation to refer to new IntField/FloatField/LongField/DoubleField #12125 [lucene]

2024-01-15 Thread via GitHub
jpountz closed pull request #12821: Fix Field.java documentation to refer to new IntField/FloatField/LongField/DoubleField #12125 URL: https://github.com/apache/lucene/pull/12821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Fix Field.java documentation to refer to new IntField/FloatField/LongField/DoubleField #12125 [lucene]

2024-01-15 Thread via GitHub
jpountz commented on PR #12821: URL: https://github.com/apache/lucene/pull/12821#issuecomment-1891539895 Thank you! I'll close this one then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-01-15 Thread via GitHub
jimczi commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1452096401 ## lucene/core/src/java/org/apache/lucene/index/LeafReader.java: ## @@ -240,11 +241,19 @@ public final PostingsEnum postings(Term term) throws IOException { * @par

Re: [I] Port PR management bot from Apache Beam [lucene]

2024-01-15 Thread via GitHub
stefanvodita commented on issue #12796: URL: https://github.com/apache/lucene/issues/12796#issuecomment-1892098969 The stale bot has been online for a week now and I like the effect it's had. It labeled almost 100 PRs as stale in total and we closed or un-staled 30 of those. Another

Re: [PR] Backport #12829 to 9.x [lucene]

2024-01-15 Thread via GitHub
s1monw commented on PR #13013: URL: https://github.com/apache/lucene/pull/13013#issuecomment-1892154344 ups I made a bad assumpion. I need to revisit this... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Reduce duplication in taxonomy facets; always do counts [lucene]

2024-01-15 Thread via GitHub
Shradha26 commented on code in PR #12966: URL: https://github.com/apache/lucene/pull/12966#discussion_r1449034518 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/TaxonomyFacets.java: ## @@ -17,20 +17,44 @@ package org.apache.lucene.facet.taxonomy; +import com.carr

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-01-15 Thread via GitHub
mayya-sharipova commented on PR #12962: URL: https://github.com/apache/lucene/pull/12962#issuecomment-1892646998 @jimczi Thanks for your feedback. > Some of the recalls for the single segment baseline seem seem quite off (0.477?). Are you sure that there was no issue during the testin

Re: [PR] Speedup concurrent multi-segment HNWS graph search 2 [lucene]

2024-01-15 Thread via GitHub
mayya-sharipova commented on code in PR #12962: URL: https://github.com/apache/lucene/pull/12962#discussion_r1452703248 ## lucene/core/src/java/org/apache/lucene/search/TopKnnCollector.java: ## @@ -27,25 +29,72 @@ */ public final class TopKnnCollector extends AbstractKnnColle

[PR] Rollback the tmp storage of BytesRefHash to -1 after sort [lucene]

2024-01-15 Thread via GitHub
gf2121 opened a new pull request, #13014: URL: https://github.com/apache/lucene/pull/13014 In #12784 we cache buckets into extra slots in `BytesRefHash` to speed up `BytesRefHash#sort`. This causes an [AssertError](https://lists.apache.org/thread/lxk2lm88twfzdl549974vov1984kj995) for [`Te