stefanvodita commented on issue #12796:
URL: https://github.com/apache/lucene/issues/12796#issuecomment-1874974051
Ironically, the PR for marking stale PRs is now itself stale 😄
I would still like to try it out if anyone is willing to review.
--
This is an automated message from the Ap
mgodwan commented on issue #12986:
URL: https://github.com/apache/lucene/issues/12986#issuecomment-1874996176
Thanks @mikemccand @rmuir for your feedback.
> It looks like that test was 100% updateDocument calls with 25% of the
updates being updates not appends?
That is correct.
mikemccand commented on issue #12796:
URL: https://github.com/apache/lucene/issues/12796#issuecomment-1875132535
> Ironically, the PR for marking stale PRs is now itself stale 😄
LOL sigh.
> I would still like to try it out if anyone is willing to review.
+1 to get this wo
stefanvodita commented on issue #12796:
URL: https://github.com/apache/lucene/issues/12796#issuecomment-1875144407
> seems to automatically add a comment after two weeks of no activity on a
PR? And also attach a label no-pr-activity?
That is correct.
> If/when we first merge th
s1monw commented on code in PR #12829:
URL: https://github.com/apache/lucene/pull/12829#discussion_r1440307876
##
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java:
##
@@ -245,10 +274,11 @@ long updateDocuments(
onNewDocOnRAM.run();
gokaai commented on code in PR #12872:
URL: https://github.com/apache/lucene/pull/12872#discussion_r1440324120
##
lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java:
##
@@ -389,13 +389,26 @@ private static void parseSegmentInfos(
}
long totalDocs = 0;
+
s1monw commented on code in PR #12829:
URL: https://github.com/apache/lucene/pull/12829#discussion_r1440343745
##
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThread.java:
##
@@ -231,7 +244,23 @@ long updateDocuments(
final int docsInRamBefore = numDocsI
mikemccand commented on PR #12829:
URL: https://github.com/apache/lucene/pull/12829#issuecomment-1875663308
> [add test and docs to make mike not staring at this
forever](https://github.com/apache/lucene/pull/12829/commits/25e6da47f989675d310de5f319ff38088589b4d4)
HAHAHA
--
This is
mikemccand commented on code in PR #12829:
URL: https://github.com/apache/lucene/pull/12829#discussion_r1440668657
##
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##
@@ -132,6 +135,13 @@ public FieldInfos(FieldInfo[] infos) {
}
softDeletesField
mikemccand commented on code in PR #12829:
URL: https://github.com/apache/lucene/pull/12829#discussion_r1440776102
##
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##
@@ -437,6 +488,33 @@ private void verifySoftDeletedFieldName(String fieldName,
boolean isSoftDe
mikemccand commented on code in PR #12829:
URL: https://github.com/apache/lucene/pull/12829#discussion_r1440776709
##
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##
@@ -437,6 +488,33 @@ private void verifySoftDeletedFieldName(String fieldName,
boolean isSoftDe
dweiss merged PR #12974:
URL: https://github.com/apache/lucene/pull/12974
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
12 matches
Mail list logo
