Re: [PR] Make FSTPostingFormat to build FST off-heap [lucene]

2023-12-27 Thread via GitHub
dungba88 commented on code in PR #12980: URL: https://github.com/apache/lucene/pull/12980#discussion_r1436295737 ## lucene/codecs/src/java/org/apache/lucene/codecs/memory/FSTTermsWriter.java: ## @@ -187,33 +200,38 @@ public void write(Fields fields, NormsProducer norms) throws

Re: [PR] Add support for index sorting with document blocks [lucene]

2023-12-27 Thread via GitHub
s1monw commented on code in PR #12829: URL: https://github.com/apache/lucene/pull/12829#discussion_r1437134740 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -188,6 +200,26 @@ public static FieldInfos getMergedFieldInfos(IndexReader reader) { } }

Re: [PR] Add support for index sorting with document blocks [lucene]

2023-12-27 Thread via GitHub
s1monw commented on PR #12829: URL: https://github.com/apache/lucene/pull/12829#issuecomment-1870447436 @mikemccand @jpountz I think it's ready. I added some more testing to it and removed storing the no. of children in the DV field to make it as low impact as possible. we can still optimiz

Re: [I] Where should we stream FST to disk directly? [lucene]

2023-12-27 Thread via GitHub
dungba88 commented on issue #12902: URL: https://github.com/apache/lucene/issues/12902#issuecomment-1870848548 Put the first PR for `FSTPostingsFormat`: https://github.com/apache/lucene/pull/12980 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [I] TransitionAccessor for NFA: get transitions for a given state via random-access leads to wrong results. [lucene]

2023-12-27 Thread via GitHub
zhaih closed issue #12906: TransitionAccessor for NFA: get transitions for a given state via random-access leads to wrong results. URL: https://github.com/apache/lucene/issues/12906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Fix bug where NFARunAutomaton#getTransition does not set Transition correctly [lucene]

2023-12-27 Thread via GitHub
zhaih merged PR #12909: URL: https://github.com/apache/lucene/pull/12909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach