Re: [PR] Add missing spaces in concatenated strings [lucene]

2023-12-24 Thread via GitHub
sabi0 commented on PR #12967: URL: https://github.com/apache/lucene/pull/12967#issuecomment-1868483440 Thank you for checking this so quickly! I started with a "Whitespace may be missing in string concatenation" inspection in IntelliJ IDEA. After applying those fixes I went through

Re: [PR] Add support for index sorting with document blocks [lucene]

2023-12-24 Thread via GitHub
s1monw commented on code in PR #12829: URL: https://github.com/apache/lucene/pull/12829#discussion_r1435809808 ## lucene/core/src/java/org/apache/lucene/index/FieldInfos.java: ## @@ -437,6 +486,31 @@ private void verifySoftDeletedFieldName(String fieldName, boolean isSoftDelete

Re: [PR] Enable CheckIndex to exorcise segments with missing segment infos (.si) (#7820) [lucene]

2023-12-24 Thread via GitHub
mikemccand commented on code in PR #12872: URL: https://github.com/apache/lucene/pull/12872#discussion_r1435749878 ## lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java: ## @@ -389,13 +389,26 @@ private static void parseSegmentInfos( } long totalDocs = 0;

[I] FSDirectory stuck at open(Path path) method when ran from .jar file [lucene]

2023-12-24 Thread via GitHub
setokk opened a new issue, #12968: URL: https://github.com/apache/lucene/issues/12968 ### Description Hello! I use the FSDirectory.open(Path path) method when building the index. When I run this method while **not** being in a jar, it works as intended. But as soon as

Re: [I] `TestStressLockFactories` fails on Windows in a freshly cloned repository [lucene]

2023-12-24 Thread via GitHub
dweiss commented on issue #12964: URL: https://github.com/apache/lucene/issues/12964#issuecomment-1868599503 > But suggesting everyone to "fix their Windows" or wait for some Java 27 to fix this or otherwise run the tests with the SecurityManager completely off is unnecessarily rigid IMO.

[PR] Fix broken testAllVersionHaveCfsAndNocfs() [lucene]

2023-12-24 Thread via GitHub
sabi0 opened a new pull request, #12969: URL: https://github.com/apache/lucene/pull/12969 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] Remove unused imports [lucene]

2023-12-24 Thread via GitHub
sabi0 opened a new pull request, #12970: URL: https://github.com/apache/lucene/pull/12970 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] Fix parsing "bbox" shape type [lucene]

2023-12-24 Thread via GitHub
sabi0 opened a new pull request, #12971: URL: https://github.com/apache/lucene/pull/12971 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] Remove obsolete 'mappingRules' in Tokenizer tests [lucene]

2023-12-24 Thread via GitHub
sabi0 opened a new pull request, #12972: URL: https://github.com/apache/lucene/pull/12972 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] Cleanup and fix EscapeQuerySyntaxImpl [lucene]

2023-12-24 Thread via GitHub
sabi0 opened a new pull request, #12973: URL: https://github.com/apache/lucene/pull/12973 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] Fix updated but not read arrays [lucene]

2023-12-24 Thread via GitHub
sabi0 opened a new pull request, #12974: URL: https://github.com/apache/lucene/pull/12974 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[PR] Get rid of inefficient Stream.count() [lucene]

2023-12-24 Thread via GitHub
sabi0 opened a new pull request, #12975: URL: https://github.com/apache/lucene/pull/12975 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai