[GitHub] [lucene] stefanvodita commented on pull request #12506: Clean up ByteBlockPool

stefanvodita commented on PR #12506: URL: https://github.com/apache/lucene/pull/12506#issuecomment-1741739207 I noticed the failing checks on this PR, but I haven't been able to reproduce them. They appear related to the nested javadoc tags I had introduced. I've removed them now. Hopefully

[GitHub] [lucene] pzygielo opened a new pull request, #12611: Avoid NPEx if the end of the stream has been reached without reading any characters

pzygielo opened a new pull request, #12611: URL: https://github.com/apache/lucene/pull/12611 e.g. by user responding with ^D ``` Press (n)ext page, (q)uit or enter number to jump to a page. Exception in thread "main" java.lang.NullPointerException: Cannot invoke "String.length()" be

[GitHub] [lucene] stefanvodita commented on a diff in pull request #12548: Ability to compute vector similarity scores with DoubleValuesSource

stefanvodita commented on code in PR #12548: URL: https://github.com/apache/lucene/pull/12548#discussion_r1341952008 ## lucene/core/src/test/org/apache/lucene/search/TestVectorSimilarityValuesSource.java: ## @@ -0,0 +1,385 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene] stefanvodita commented on issue #12601: Reproducible TestDrillSideways failure

stefanvodita commented on issue #12601: URL: https://github.com/apache/lucene/issues/12601#issuecomment-1741757747 Reverting #921 fixes the test, so I think this is the same issue that @Yuti-G investigated in #12418. I ran the test in verbose mode (`./gradlew test --tests TestDrillSidewa