[GitHub] [lucene] shubhamvishu commented on pull request #12428: Replace consecutive close() calls and close() calls with null checks with IOUtils.close()

shubhamvishu commented on PR #12428: URL: https://github.com/apache/lucene/pull/12428#issuecomment-1695501578 @madrob I don't think this change would be performance impacting as such though. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [lucene] gashutos opened a new pull request, #12520: Honor topvalue while determining isMissingvalueCompetitive in case bottom is not set

gashutos opened a new pull request, #12520: URL: https://github.com/apache/lucene/pull/12520 ### Description There is a bug introduced with #12334 when field contains missing value and if those missing values are competitive. `isMissingValueCompetitive()` implementation gets invoke

[GitHub] [lucene] gashutos commented on pull request #12520: Honor topvalue while determining isMissingvalueCompetitive in case bottom is not set

gashutos commented on PR #12520: URL: https://github.com/apache/lucene/pull/12520#issuecomment-1695625805 This was observed here -> https://github.com/opensearch-project/OpenSearch/issues/9537 -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene] gashutos opened a new issue, #12521: [BUG] Sort After returning in-correct result when missing values are competitive.

gashutos opened a new issue, #12521: URL: https://github.com/apache/lucene/issues/12521 ### Description There is a bug introduced with https://github.com/apache/lucene/pull/12334 when field contains missing value and if those missing values are competitive. isMissingValueCompetitiv

[GitHub] [lucene] thomasdc opened a new issue, #12522: Add support for ignoreKeywords in WordDelimiterGraphFilterFactory

thomasdc opened a new issue, #12522: URL: https://github.com/apache/lucene/issues/12522 ### Description Lucene's [WordDelimiterGraphFilter](https://github.com/apache/lucene/blob/main/lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/WordDelimiterGraphFilter.java

[GitHub] [lucene] ChrisHegarty commented on pull request #12518: Use panama vector for l2normalize

ChrisHegarty commented on PR #12518: URL: https://github.com/apache/lucene/pull/12518#issuecomment-1695880133 How about we add a test scenario to `TestVectorUtilSupport`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [lucene] ChrisHegarty commented on pull request #12518: Use panama vector for l2normalize

ChrisHegarty commented on PR #12518: URL: https://github.com/apache/lucene/pull/12518#issuecomment-1695885121 > How about we add a test scenario to `TestVectorUtilSupport`. Ignore. I thought that the method was at a different level in the hierarchy. My comment doesn't make sense. --

[GitHub] [lucene] quux00 opened a new pull request, #12523: TaskExecutor waits for all tasks to complete before returning

quux00 opened a new pull request, #12523: URL: https://github.com/apache/lucene/pull/12523 The TaskExecutor used by IndexSearcher and AbstractKnnVectorQuery waits until all tasks have finished before returning, even when one or more of the tasks throw an Exception. -- This is

[GitHub] [lucene] jpountz commented on pull request #12490: Reduce the overhead of ImpactsDISI.

jpountz commented on PR #12490: URL: https://github.com/apache/lucene/pull/12490#issuecomment-1696471610 This change is ready for review. - `TermQuery` and `FeatureQuery` implement the new API. - To keep the PR small, `PhraseQuery`, `ConstantScoreQuery` and `SynonymQuery` do not impl

[GitHub] [lucene] vsop-479 opened a new issue, #12524: Test failure in TestIndexWriter.testDeleteUnusedFiles on Windows 11

vsop-479 opened a new issue, #12524: URL: https://github.com/apache/lucene/issues/12524 ### Description TestIndexWriter.testDeleteUnusedFiles asserts file exists, after the commit follow the force merge on Windows. Actually it is deleted after that commit. So, I got a assertion err