[GitHub] [lucene] iverase merged pull request #12512: Remove unused variable in BKDWriter

2023-08-22 Thread via GitHub
iverase merged PR #12512: URL: https://github.com/apache/lucene/pull/12512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] easyice closed issue #12514: Could we add more index for BKD LeafNode?

2023-08-22 Thread via GitHub
easyice closed issue #12514: Could we add more index for BKD LeafNode? URL: https://github.com/apache/lucene/issues/12514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [lucene] easyice commented on issue #12514: Could we add more index for BKD LeafNode?

2023-08-22 Thread via GitHub
easyice commented on issue #12514: URL: https://github.com/apache/lucene/issues/12514#issuecomment-1687673132 Thanks for explaining, I will close the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] azagniotov opened a new pull request, #12517: LUCENE-4056: Japanese Tokenizer (Kuromoji) cannot build UniDic dictionary

2023-08-22 Thread via GitHub
azagniotov opened a new pull request, #12517: URL: https://github.com/apache/lucene/pull/12517 ## TL;DR The current PR attempts to remediate https://issues.apache.org/jira/browse/LUCENE-4056 (`Japanese Tokenizer (Kuromoji) cannot build UniDic dictionary`) ## Description

[GitHub] [lucene] mikemccand commented on pull request #12465: Potential bug in IndexedDISI90#SPARSE->advanceExactWithinBlock

2023-08-22 Thread via GitHub
mikemccand commented on PR #12465: URL: https://github.com/apache/lucene/pull/12465#issuecomment-1688183077 It's awesome that Lucene changed to be more picky (removing leniency) on catching invalid usage of the API! Such improvements are great at ferreting out bugs (instead of masking them

[GitHub] [lucene] zhaih commented on a diff in pull request #12480: Enhancement 11236 lazy compute similarity score

2023-08-22 Thread via GitHub
zhaih commented on code in PR #12480: URL: https://github.com/apache/lucene/pull/12480#discussion_r1302276710 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java: ## @@ -401,8 +404,23 @@ private boolean isDiverse(byte[] candidate, NeighborArray neighbors,

[GitHub] [lucene] zhaih commented on a diff in pull request #12480: Enhancement 11236 lazy compute similarity score

2023-08-22 Thread via GitHub
zhaih commented on code in PR #12480: URL: https://github.com/apache/lucene/pull/12480#discussion_r1302278519 ## lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java: ## @@ -108,10 +111,16 @@ public int[] sort() { } /** insert the first unsorted node into

[GitHub] [lucene] zhaih commented on pull request #12480: Enhancement 11236 lazy compute similarity score

2023-08-22 Thread via GitHub
zhaih commented on PR #12480: URL: https://github.com/apache/lucene/pull/12480#issuecomment-1689049573 Ah sorry I almost forget: don't forget to create a CHANGES.txt entry :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub