[GitHub] [lucene] javanna commented on issue #12498: Simplify task executor for concurrent operations

2023-08-17 Thread via GitHub
javanna commented on issue #12498: URL: https://github.com/apache/lucene/issues/12498#issuecomment-1681815467 Thanks for the feedback everyone, there's a PR up as a first step (does not include single slice offloading yet): https://github.com/apache/lucene/pull/12499 . Reviews are welcome.

[GitHub] [lucene] easyice opened a new pull request, #12512: remove unused variable

2023-08-17 Thread via GitHub
easyice opened a new pull request, #12512: URL: https://github.com/apache/lucene/pull/12512 ### Description The variable `scratch2` is never used -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [lucene] benwtrent commented on pull request #12512: Remove unused variable in BKDWriter

2023-08-17 Thread via GitHub
benwtrent commented on PR #12512: URL: https://github.com/apache/lucene/pull/12512#issuecomment-1682335093 From what I can tell, it stopped being used after this commit: https://github.com/apache/lucene/commit/5d1d6448b91abdebbc68b54b062340c5baa88f4c#diff-12a84802489e3d06f69565f493e8f1b19147

[GitHub] [lucene] mbrette commented on issue #12440: Make HNSW merges faster

2023-08-17 Thread via GitHub
mbrette commented on issue #12440: URL: https://github.com/apache/lucene/issues/12440#issuecomment-1682522530 What is your take on existing merge optimization #12050 ? The approach seems very effective (*), however it does not work if there are deleted documents, which is likely to happen

[GitHub] [lucene] benwtrent commented on issue #12440: Make HNSW merges faster

2023-08-17 Thread via GitHub
benwtrent commented on issue #12440: URL: https://github.com/apache/lucene/issues/12440#issuecomment-1682640430 > What is your take on existing merge optimization https://github.com/apache/lucene/pull/12050? I think its a good start. One problem I have is that typical Lucene segment

[GitHub] [lucene] Tony-X opened a new issue, #12513: Try out a simpler term dictionary

2023-08-17 Thread via GitHub
Tony-X opened a new issue, #12513: URL: https://github.com/apache/lucene/issues/12513 ### Description Hello! I've been working on a [benchmark](https://tony-x.github.io/search-benchmark-game/) for a while to compare the features and performance of Lucene and [Tantivy](https:

[GitHub] [lucene] Tony-X commented on issue #12513: Try out a tantivy's term dictionary format

2023-08-17 Thread via GitHub
Tony-X commented on issue #12513: URL: https://github.com/apache/lucene/issues/12513#issuecomment-1682810659 Copy paste the relevant wiki section about tantivy's TermDictionary --- ## tantivy TermDictionary Tantivy's term dictionary has two components. An FST that encodes

[GitHub] [lucene] javanna commented on pull request #12499: Simplify task executor for concurrent operations

2023-08-17 Thread via GitHub
javanna commented on PR #12499: URL: https://github.com/apache/lucene/pull/12499#issuecomment-1682812371 Thanks for looking @reta ! i plan on merging this soon, if anyone else would like to review, please go ahead. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [lucene] reta commented on pull request #12499: Simplify task executor for concurrent operations

2023-08-17 Thread via GitHub
reta commented on PR #12499: URL: https://github.com/apache/lucene/pull/12499#issuecomment-1682819596 @sohami fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [lucene] sohami commented on pull request #12499: Simplify task executor for concurrent operations

2023-08-17 Thread via GitHub
sohami commented on PR #12499: URL: https://github.com/apache/lucene/pull/12499#issuecomment-1683053853 > @sohami fyi Thanks @reta for tagging me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene] sohami commented on pull request #12499: Simplify task executor for concurrent operations

2023-08-17 Thread via GitHub
sohami commented on PR #12499: URL: https://github.com/apache/lucene/pull/12499#issuecomment-1683057195 @javanna For single slice case are we thinking to leave it as is or change that as well to offload to the provided `executor` ? -- This is an automated message from the Apache Git Servi