[GitHub] [lucene] vsop-479 opened a new pull request, #12511: Avoid flush the writer with one doc when i is 0 in TestSortOptimization.testStringSortOptimization

2023-08-16 Thread via GitHub
vsop-479 opened a new pull request, #12511: URL: https://github.com/apache/lucene/pull/12511 I noticed the writer flushed with one doc in testStringSortOptimizationWithMissingValues intentionally. But i am not sure whether it is intentionally in testStringSortOptimization. -- This is

[GitHub] [lucene] benwtrent merged pull request #12479: GITHUB#12342 Add new maximum inner product vector similarity method

2023-08-16 Thread via GitHub
benwtrent merged PR #12479: URL: https://github.com/apache/lucene/pull/12479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[GitHub] [lucene] benwtrent merged pull request #12510: Adjust ToParentBlockJoin[Byte|Float]KnnVectorQuery to return highest score child doc ID by parent id

2023-08-16 Thread via GitHub
benwtrent merged PR #12510: URL: https://github.com/apache/lucene/pull/12510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[GitHub] [lucene] gsmiller merged pull request #12472: Fix UTF32toUTF8 will produce invalid transition

2023-08-16 Thread via GitHub
gsmiller merged PR #12472: URL: https://github.com/apache/lucene/pull/12472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[GitHub] [lucene] gsmiller commented on pull request #12472: Fix UTF32toUTF8 will produce invalid transition

2023-08-16 Thread via GitHub
gsmiller commented on PR #12472: URL: https://github.com/apache/lucene/pull/12472#issuecomment-1681353449 Merged and back-ported. Thanks again @tang-hi! Nice fix for a reasonably tricky issue! -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [lucene] gsmiller commented on issue #12458: UTF32toUTF8 can create automata that produce/accept invalid unicode

2023-08-16 Thread via GitHub
gsmiller commented on issue #12458: URL: https://github.com/apache/lucene/issues/12458#issuecomment-1681354136 Fixed by @tang-hi in GH#12472. Thanks!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene] gsmiller closed issue #12458: UTF32toUTF8 can create automata that produce/accept invalid unicode

2023-08-16 Thread via GitHub
gsmiller closed issue #12458: UTF32toUTF8 can create automata that produce/accept invalid unicode URL: https://github.com/apache/lucene/issues/12458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [lucene] gsmiller merged pull request #12428: Replace consecutive close() calls and close() calls with null checks with IOUtils.close()

2023-08-16 Thread via GitHub
gsmiller merged PR #12428: URL: https://github.com/apache/lucene/pull/12428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[GitHub] [lucene] gsmiller commented on pull request #12428: Replace consecutive close() calls and close() calls with null checks with IOUtils.close()

2023-08-16 Thread via GitHub
gsmiller commented on PR #12428: URL: https://github.com/apache/lucene/pull/12428#issuecomment-1681452529 Merged and back-ported. Thanks @shubhamvishu ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene] madrob commented on pull request #12428: Replace consecutive close() calls and close() calls with null checks with IOUtils.close()

2023-08-16 Thread via GitHub
madrob commented on PR #12428: URL: https://github.com/apache/lucene/pull/12428#issuecomment-1681463421 I would be curious to see the impact on performance here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [lucene] zhaih merged pull request #12462: Fix stack overflow in RegExp for long string

2023-08-16 Thread via GitHub
zhaih merged PR #12462: URL: https://github.com/apache/lucene/pull/12462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[GitHub] [lucene] zhaih closed issue #11537: StackOverflow when RegExp encounters a very large string [LUCENE-10501]

2023-08-16 Thread via GitHub
zhaih closed issue #11537: StackOverflow when RegExp encounters a very large string [LUCENE-10501] URL: https://github.com/apache/lucene/issues/11537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] zhaih commented on pull request #12462: Fix stack overflow in RegExp for long string

2023-08-16 Thread via GitHub
zhaih commented on PR #12462: URL: https://github.com/apache/lucene/pull/12462#issuecomment-1681653631 Merged and backported, thank you @slow-J ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t