[GitHub] [lucene] stefanvodita commented on a diff in pull request #12462: Fix stack overflow in RegExp for long string

2023-08-10 Thread via GitHub
stefanvodita commented on code in PR #12462: URL: https://github.com/apache/lucene/pull/12462#discussion_r1290149550 ## lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java: ## @@ -1067,22 +1071,44 @@ private boolean check(int flag) { } final RegExp parseUni

[GitHub] [lucene] slow-J commented on a diff in pull request #12462: Fix stack overflow in RegExp for long string

2023-08-10 Thread via GitHub
slow-J commented on code in PR #12462: URL: https://github.com/apache/lucene/pull/12462#discussion_r1290188698 ## lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java: ## @@ -1067,22 +1071,44 @@ private boolean check(int flag) { } final RegExp parseUnionExp(

[GitHub] [lucene] slow-J commented on a diff in pull request #12462: Fix stack overflow in RegExp for long string

2023-08-10 Thread via GitHub
slow-J commented on code in PR #12462: URL: https://github.com/apache/lucene/pull/12462#discussion_r1290219209 ## lucene/core/src/java/org/apache/lucene/util/automaton/RegExp.java: ## @@ -1067,22 +1071,44 @@ private boolean check(int flag) { } final RegExp parseUnionExp(

[GitHub] [lucene] javanna opened a new issue, #12498: Simplify task executor for concurrent operations

2023-08-10 Thread via GitHub
javanna opened a new issue, #12498: URL: https://github.com/apache/lucene/issues/12498 `IndexSearcher` supports parallelizing search across slices when an executor is available. Knn queries can also parallelize their rewrite across segments using the same executor. Potentially, other operat

[GitHub] [lucene] javanna commented on issue #12498: Simplify task executor for concurrent operations

2023-08-10 Thread via GitHub
javanna commented on issue #12498: URL: https://github.com/apache/lucene/issues/12498#issuecomment-1673363696 @jpountz @mikemccand pinging you two because you are likely to have thoughts on this. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [lucene] javanna opened a new pull request, #12499: Simplify task executor for concurrent operations

2023-08-10 Thread via GitHub
javanna opened a new pull request, #12499: URL: https://github.com/apache/lucene/pull/12499 Based on the proposal in #12498, this PR removes the QueueSizeBasedExecutor (package private) in favour of simply offloading concurrent execution to the provided executor. In need of specific behavio

[GitHub] [lucene] shubhamvishu commented on pull request #12428: Replace consecutive close() calls and close() calls with null checks with IOUtils.close()

2023-08-10 Thread via GitHub
shubhamvishu commented on PR #12428: URL: https://github.com/apache/lucene/pull/12428#issuecomment-1673477487 @gsmiller I have added the CHANGES entry under 9.8.0 and replaced a couple of more such calls I could find. Let me know if this looks good. Thanks! -- This is an automated message

[GitHub] [lucene] shubhamvishu commented on pull request #12427: StringsToAutomaton#build to take List as parameter instead of Collection

2023-08-10 Thread via GitHub
shubhamvishu commented on PR #12427: URL: https://github.com/apache/lucene/pull/12427#issuecomment-1673498218 > I still think the explicit validation is better in this situation, but the counter-argument would be a user that knows for sure they're always properly providing sorted input and

[GitHub] [lucene] tang-hi commented on pull request #12472: Fix UTF32toUTF8 will produce invalid transition

2023-08-10 Thread via GitHub
tang-hi commented on PR #12472: URL: https://github.com/apache/lucene/pull/12472#issuecomment-1673497452 @mikemccand Just a gentle reminder, perhaps you can review this code and then move this PR forward. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene] jbellis commented on a diff in pull request #12421: Concurrent hnsw graph and builder, take two

2023-08-10 Thread via GitHub
jbellis commented on code in PR #12421: URL: https://github.com/apache/lucene/pull/12421#discussion_r1290379055 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -104,7 +103,9 @@ public void addNode(int level, int node) { // and make this nod

[GitHub] [lucene] jbellis commented on a diff in pull request #12421: Concurrent hnsw graph and builder, take two

2023-08-10 Thread via GitHub
jbellis commented on code in PR #12421: URL: https://github.com/apache/lucene/pull/12421#discussion_r1290387939 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -169,35 +170,43 @@ public NodesIterator getNodesOnLevel(int level) { @Override

[GitHub] [lucene] jbellis commented on a diff in pull request #12421: Concurrent hnsw graph and builder, take two

2023-08-10 Thread via GitHub
jbellis commented on code in PR #12421: URL: https://github.com/apache/lucene/pull/12421#discussion_r1290397717 ## lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java: ## @@ -126,12 +124,16 @@ private int insertSortedInternal() { return insertionPoint; }

[GitHub] [lucene] jbellis commented on a diff in pull request #12421: Concurrent hnsw graph and builder, take two

2023-08-10 Thread via GitHub
jbellis commented on code in PR #12421: URL: https://github.com/apache/lucene/pull/12421#discussion_r1290402830 ## lucene/core/src/java/org/apache/lucene/util/hnsw/ConcurrentNeighborSet.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [lucene] jbellis commented on a diff in pull request #12421: Concurrent hnsw graph and builder, take two

2023-08-10 Thread via GitHub
jbellis commented on code in PR #12421: URL: https://github.com/apache/lucene/pull/12421#discussion_r1290407428 ## lucene/core/src/java/org/apache/lucene/util/hnsw/ConcurrentNeighborSet.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [lucene] jbellis commented on a diff in pull request #12421: Concurrent hnsw graph and builder, take two

2023-08-10 Thread via GitHub
jbellis commented on code in PR #12421: URL: https://github.com/apache/lucene/pull/12421#discussion_r1290415826 ## lucene/core/src/java/org/apache/lucene/util/hnsw/ConcurrentHnswGraphBuilder.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] jbellis commented on a diff in pull request #12421: Concurrent hnsw graph and builder, take two

2023-08-10 Thread via GitHub
jbellis commented on code in PR #12421: URL: https://github.com/apache/lucene/pull/12421#discussion_r1290452412 ## lucene/core/src/java/org/apache/lucene/util/hnsw/ConcurrentHnswGraphBuilder.java: ## @@ -0,0 +1,468 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [lucene] benwtrent opened a new pull request, #12500: Fix flaky testToString method for Knn Vector queries

2023-08-10 Thread via GitHub
benwtrent opened a new pull request, #12500: URL: https://github.com/apache/lucene/pull/12500 Periodically, the random indexer will force merge on close, this means that what was originally indexed as the zeroth document could no longer be the zeroth document. This commit adjusts the

[GitHub] [lucene-solr] jainankitk closed pull request #601: Adding reader settings for moving fst offheap

2023-08-10 Thread via GitHub
jainankitk closed pull request #601: Adding reader settings for moving fst offheap URL: https://github.com/apache/lucene-solr/pull/601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co