[GitHub] [lucene] jpountz commented on pull request #12488: Stop aligning windows in BooleanScorer.

2023-08-05 Thread via GitHub
jpountz commented on PR #12488: URL: https://github.com/apache/lucene/pull/12488#issuecomment-1666447365 Counting tasks confirm the speedup: ``` TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value

[GitHub] [lucene] jpountz merged pull request #12488: Stop aligning windows in BooleanScorer.

2023-08-05 Thread via GitHub
jpountz merged PR #12488: URL: https://github.com/apache/lucene/pull/12488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz commented on pull request #12415: Optimize disjunction counts.

2023-08-05 Thread via GitHub
jpountz commented on PR #12415: URL: https://github.com/apache/lucene/pull/12415#issuecomment-1666458827 Counting tasks after integrating #12488: ``` TaskQPS baseline StdDevQPS my_modified_version StdDevPct diff p-value

[GitHub] [lucene] jpountz opened a new pull request, #12490: Reduce the overhead of ImpactsDISI.

2023-08-05 Thread via GitHub
jpountz opened a new pull request, #12490: URL: https://github.com/apache/lucene/pull/12490 `ImpactsDISI` is nice: you give it an `ImpactsEnum`, typically coming from the `PostingsFormat` and it will automatically skip hits whose score cannot be greater than the minimum competitive score. T

[GitHub] [lucene] jpountz commented on pull request #12490: Reduce the overhead of ImpactsDISI.

2023-08-05 Thread via GitHub
jpountz commented on PR #12490: URL: https://github.com/apache/lucene/pull/12490#issuecomment-1666598365 Opened this PR as a draft to get feedback on the API (if any). Existing tests pass, but I plan on adding more tests before merging as well. Here are the results of this PR on wikimedium1

[GitHub] [lucene] donnerpeter commented on pull request #12491: hunspell: simplify TrigramAutomaton to speed up the suggestion enumeration

2023-08-05 Thread via GitHub
donnerpeter commented on PR #12491: URL: https://github.com/apache/lucene/pull/12491#issuecomment-1666598426 This gives ~10% speed improvement on German, Russian and Ukrainian suggestions -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene] donnerpeter opened a new pull request, #12491: hunspell: simplify TrigramAutomaton to speed up the suggestion enumeration

2023-08-05 Thread via GitHub
donnerpeter opened a new pull request, #12491: URL: https://github.com/apache/lucene/pull/12491 avoid the automaton access on definitely absent characters; count the scores for all substring lengths together -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [lucene] benwtrent commented on a diff in pull request #12421: Concurrent hnsw graph and builder, take two

2023-08-05 Thread via GitHub
benwtrent commented on code in PR #12421: URL: https://github.com/apache/lucene/pull/12421#discussion_r1285112800 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java: ## @@ -87,6 +88,67 @@ public static NeighborQueue search( Bits acceptOrds,

[GitHub] [lucene] ArtemLukanin-TomTom commented on issue #12142: Separate index/store document APIs take 2?

2023-08-05 Thread via GitHub
ArtemLukanin-TomTom commented on issue #12142: URL: https://github.com/apache/lucene/issues/12142#issuecomment-112546 I feel, that this discussion is close to my comment https://github.com/apache/lucene/issues/10374#issuecomment-112060 -- This is an automated message from the Apac

[GitHub] [lucene] jbellis commented on a diff in pull request #12421: Concurrent hnsw graph and builder, take two

2023-08-05 Thread via GitHub
jbellis commented on code in PR #12421: URL: https://github.com/apache/lucene/pull/12421#discussion_r1285130145 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraph.java: ## @@ -122,6 +123,24 @@ public NodesIterator getNodesOnLevel(int level) { } }; +