[GitHub] [lucene] mikemccand commented on pull request #12415: Optimize disjunction counts.

2023-07-21 Thread via GitHub
mikemccand commented on PR #12415: URL: https://github.com/apache/lucene/pull/12415#issuecomment-1645462761 > counting title OR 12 is now 80% faster compared to main. Wow! I'll try to review soon. Thanks @jpountz! -- This is an automated message from the Apache Git Service. To res

[GitHub] [lucene] gashutos commented on issue #12448: [Performance] sort query improvement for sequential ordered data [e.g. timestamp field sort in log data]

2023-07-21 Thread via GitHub
gashutos commented on issue #12448: URL: https://github.com/apache/lucene/issues/12448#issuecomment-1645589833 @backslasht The overhead of `Index Sort` is very high. I ingested above 36 million documents with/without @timestamp indexsort and different is minimum 20% plus. Refer below number

[GitHub] [lucene] heemin32 commented on pull request #12287: Fix a bug in ShapeTestUtil

2023-07-21 Thread via GitHub
heemin32 commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1646099677 > Nice find! I wonder if we could put a test in place that would have reliably detected this issue. This is a code for test actually. If we are writing a test using this method,

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #12436: Move max vector dims limit to Codec

2023-07-21 Thread via GitHub
mayya-sharipova commented on code in PR #12436: URL: https://github.com/apache/lucene/pull/12436#discussion_r1270997853 ## lucene/core/src/java/org/apache/lucene/index/IndexingChain.java: ## @@ -621,6 +621,12 @@ private void initializeFieldInfo(PerField pf) throws IOException {

[GitHub] [lucene] stefanvodita commented on pull request #12287: Fix a bug in ShapeTestUtil

2023-07-21 Thread via GitHub
stefanvodita commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1646142364 I should have been clearer. I'm assuming the existing tests that call `nextPolygon()` are passing before and after the fix, which warrants some suspicion. Could we devise a test tha

[GitHub] [lucene] mayya-sharipova commented on a diff in pull request #12436: Move max vector dims limit to Codec

2023-07-21 Thread via GitHub
mayya-sharipova commented on code in PR #12436: URL: https://github.com/apache/lucene/pull/12436#discussion_r1270997853 ## lucene/core/src/java/org/apache/lucene/index/IndexingChain.java: ## @@ -621,6 +621,12 @@ private void initializeFieldInfo(PerField pf) throws IOException {

[GitHub] [lucene] heemin32 commented on pull request #12287: Fix a bug in ShapeTestUtil

2023-07-21 Thread via GitHub
heemin32 commented on PR #12287: URL: https://github.com/apache/lucene/pull/12287#issuecomment-1646175009 > I should have been clearer. I'm assuming the existing tests that call `nextPolygon()` are passing before and after the fix, which warrants some suspicion. Could we devise a test that

[GitHub] [lucene] jbellis commented on pull request #12421: Concurrent hnsw graph and builder, take two

2023-07-21 Thread via GitHub
jbellis commented on PR #12421: URL: https://github.com/apache/lucene/pull/12421#issuecomment-1646504742 Parallel code with one thread will build the same graph as serial code. (This is validated by unit tests.) With multiple threads, parallel code errs on the side of potentially addin