[GitHub] [lucene] MaherTaho opened a new issue, #12443: Support Field type that holds multi values

2023-07-16 Thread via GitHub
MaherTaho opened a new issue, #12443: URL: https://github.com/apache/lucene/issues/12443 ### Description As I can see right now , at every document we can add one value for each field and it's just can be a string for example `Document document = new Document(); document.ad

[GitHub] [lucene] mkhludnev closed issue #12443: Support Field type that holds multi values

2023-07-16 Thread via GitHub
mkhludnev closed issue #12443: Support Field type that holds multi values URL: https://github.com/apache/lucene/issues/12443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [lucene] tang-hi commented on pull request #12417: forutil add vectorized and scalar code

2023-07-16 Thread via GitHub
tang-hi commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1637112151 @gsmiller I have pushed the commit for lazy computation.IMO, it will provide better performance. I would highly recommend considering its implementation in the production environment, ut

[GitHub] [lucene] uschindler commented on a diff in pull request #12417: forutil add vectorized and scalar code

2023-07-16 Thread via GitHub
uschindler commented on code in PR #12417: URL: https://github.com/apache/lucene/pull/12417#discussion_r1264698044 ## lucene/core/src/java20/org/apache/lucene/internal/vectorization/PanamaVectorizationProvider.java: ## @@ -82,4 +82,9 @@ private static T doPrivileged(PrivilegedA

[GitHub] [lucene] uschindler commented on a diff in pull request #12417: forutil add vectorized and scalar code

2023-07-16 Thread via GitHub
uschindler commented on code in PR #12417: URL: https://github.com/apache/lucene/pull/12417#discussion_r1264698044 ## lucene/core/src/java20/org/apache/lucene/internal/vectorization/PanamaVectorizationProvider.java: ## @@ -82,4 +82,9 @@ private static T doPrivileged(PrivilegedA

[GitHub] [lucene] uschindler commented on a diff in pull request #12417: forutil add vectorized and scalar code

2023-07-16 Thread via GitHub
uschindler commented on code in PR #12417: URL: https://github.com/apache/lucene/pull/12417#discussion_r1264698044 ## lucene/core/src/java20/org/apache/lucene/internal/vectorization/PanamaVectorizationProvider.java: ## @@ -82,4 +82,9 @@ private static T doPrivileged(PrivilegedA

[GitHub] [lucene] tang-hi commented on a diff in pull request #12417: forutil add vectorized and scalar code

2023-07-16 Thread via GitHub
tang-hi commented on code in PR #12417: URL: https://github.com/apache/lucene/pull/12417#discussion_r1264699065 ## lucene/core/src/java20/org/apache/lucene/internal/vectorization/PanamaVectorizationProvider.java: ## @@ -82,4 +82,9 @@ private static T doPrivileged(PrivilegedActi

[GitHub] [lucene] uschindler commented on pull request #12417: forutil add vectorized and scalar code

2023-07-16 Thread via GitHub
uschindler commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1637115931 > please, lets not use this integer vectorization when `hasFastIntegerVectors` is false. Otherwise we can see 30x or so slowdown on virtualmachines without properly plumbed AVX.

[GitHub] [lucene] stefanvodita commented on issue #11681: Wrong autocomplete suggestion [LUCENE-10645]

2023-07-16 Thread via GitHub
stefanvodita commented on issue #11681: URL: https://github.com/apache/lucene/issues/11681#issuecomment-1637120493 Thank you for the thorough description! I was curious about this issue and went through the code. The class Javadoc implies that this behaviour is intentional: > Analyze

[GitHub] [lucene] rmuir commented on pull request #12417: forutil add vectorized and scalar code

2023-07-16 Thread via GitHub
rmuir commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1637277039 > Was a simple change, thanks for reminder! thanks! We can always test performance with `-XX:UseAVX=0`, maybe the check is unneeded based on whatever hotspot can do. Only shifts/and/