[GitHub] [lucene] Deepika0510 commented on a diff in pull request #12345: LUCENE-10641: IndexSearcher#setTimeout should also abort query rewrites, point ranges and vector searches

Deepika0510 commented on code in PR #12345: URL: https://github.com/apache/lucene/pull/12345#discussion_r1257492761 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -763,6 +763,11 @@ public Query rewrite(Query original) throws IOException { for (Qu

[GitHub] [lucene] shubhamvishu commented on issue #12394: Add the ability to compute vector similarity scores with the new ValuesSource API

shubhamvishu commented on issue #12394: URL: https://github.com/apache/lucene/issues/12394#issuecomment-1627772700 I would like to take this up! @jpountz Do you mean we could have something like `ByteVectorSimilarityValuesSource` and `FloatVectorSimilarityValuesSource` extending `Do

[GitHub] [lucene] shubhamvishu opened a new pull request, #12427: StringsToAutomaton#build to take List as parameter instead of Collection

shubhamvishu opened a new pull request, #12427: URL: https://github.com/apache/lucene/pull/12427 ### Description - This addresses issue #12319 - `StringsToAutomaton` previously called `DaciukMihovAutomatonBuilder`(renamed in this PR) should take List as input instead of Collecti

[GitHub] [lucene] shubhamvishu commented on issue #12319: DaciukMihovAutomatonBuilder#build should probably take a List instead of a Collection

shubhamvishu commented on issue #12319: URL: https://github.com/apache/lucene/issues/12319#issuecomment-1627817309 Raised a PR #12427 for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] nknize commented on pull request #12376: Allow VectorUtilProvider tests to be executed although hardware may not fully support vectorization or if C2 is not enabled

nknize commented on PR #12376: URL: https://github.com/apache/lucene/pull/12376#issuecomment-1627887791 Curious what I'm missing here. With the jdk set to 20 [`checkVersion` in `WrapperDownloader.java`](https://github.com/apache/lucene/blob/d03c8f16d9d4f87ce24d603e4a9b4a7806f9b533/buildSrc/s

[GitHub] [lucene] tang-hi commented on pull request #12417: forutil add vectorized and scalar code

tang-hi commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1628186305 > What I'm not sure of is how to efficiently get into an int[] for output Perhaps you could consider utilizing the [reinterprestAsInts] (https://docs.oracle.com/en/java/javase/17/d

[GitHub] [lucene] tang-hi commented on pull request #12417: forutil add vectorized and scalar code

tang-hi commented on PR #12417: URL: https://github.com/apache/lucene/pull/12417#issuecomment-1628201127 > > What I'm not sure of is how to efficiently get into an int[] for output > > Perhaps you could consider utilizing the [reinterprestAsInts](https://docs.oracle.com/en/java/javase

[GitHub] [lucene] shubhamvishu opened a new pull request, #12428: Replace consecutive close() calls and close() calls with null checks with IOUtils.close()

shubhamvishu opened a new pull request, #12428: URL: https://github.com/apache/lucene/pull/12428 ### Description This PR replaces : - The consecutive `close()` calls with `IOUtils.close()` to close multiple `Closeable`s' - The close() calls with null checks with `IOUtils.clo