[GitHub] [lucene] jpountz commented on pull request #12415: Optimize disjunction counts.

2023-07-06 Thread via GitHub
jpountz commented on PR #12415: URL: https://github.com/apache/lucene/pull/12415#issuecomment-1623101984 To me a big question with this API is whether we should consider methods on the `DocIdStream` terminal or not. If we do this, then this may enable more optimizations later on, e.g. it wo

[GitHub] [lucene] tang-hi commented on issue #12419: IndexWriter and ConcurrentMergeScheduler and SegmentReader can cause static initialization deadlock

2023-07-06 Thread via GitHub
tang-hi commented on issue #12419: URL: https://github.com/apache/lucene/issues/12419#issuecomment-1623127458 In my opinion, this deadlock only occurs at the beginning of program execution. As long as you ensure that the IndexWriter is constructed before the ConcurrentMergeScheduler, the de

[GitHub] [lucene] hydrogen666 commented on issue #12419: IndexWriter and ConcurrentMergeScheduler and SegmentReader can cause static initialization deadlock

2023-07-06 Thread via GitHub
hydrogen666 commented on issue #12419: URL: https://github.com/apache/lucene/issues/12419#issuecomment-1623167682 @tang-hi Our Elasticsearch has migrated to Segment replication mechanism, so the code runing on the Primary shard and Replica shard is different. The replica shard will not cons

[GitHub] [lucene] almogtavor commented on issue #12406: Register nested queries (ToParentBlockJoinQuery) to Lucene Monitor

2023-07-06 Thread via GitHub
almogtavor commented on issue #12406: URL: https://github.com/apache/lucene/issues/12406#issuecomment-1623435023 @romseygeek @dweiss I'd love to get feedback from you on the subject -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [lucene] mikemccand commented on a diff in pull request #12345: LUCENE-10641: IndexSearcher#setTimeout should also abort query rewrites, point ranges and vector searches

2023-07-06 Thread via GitHub
mikemccand commented on code in PR #12345: URL: https://github.com/apache/lucene/pull/12345#discussion_r1254254429 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -763,6 +763,11 @@ public Query rewrite(Query original) throws IOException { for (Que

[GitHub] [lucene] easyice opened a new pull request, #12420: Optimize DocIdsWriter for BKD in reverse case with index sorting

2023-07-06 Thread via GitHub
easyice opened a new pull request, #12420: URL: https://github.com/apache/lucene/pull/12420 ### Description In https://github.com/apache/lucene/pull/438 , https://github.com/apache/lucene/pull/510, we optimized the doc ids more efficiently for store and decode, this pr allows these o

[GitHub] [lucene] jpountz commented on a diff in pull request #12345: LUCENE-10641: IndexSearcher#setTimeout should also abort query rewrites, point ranges and vector searches

2023-07-06 Thread via GitHub
jpountz commented on code in PR #12345: URL: https://github.com/apache/lucene/pull/12345#discussion_r1254334257 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -763,6 +763,11 @@ public Query rewrite(Query original) throws IOException { for (Query

[GitHub] [lucene] uschindler commented on a diff in pull request #12417: forutil add vectorized and scalar code

2023-07-06 Thread via GitHub
uschindler commented on code in PR #12417: URL: https://github.com/apache/lucene/pull/12417#discussion_r1254354197 ## lucene/core/src/java/org/apache/lucene/internal/vectorization/DefaultForUtil90.java: ## @@ -0,0 +1,118 @@ +// This file has been automatically generated, DO NOT

[GitHub] [lucene] uschindler commented on a diff in pull request #12417: forutil add vectorized and scalar code

2023-07-06 Thread via GitHub
uschindler commented on code in PR #12417: URL: https://github.com/apache/lucene/pull/12417#discussion_r1254355675 ## lucene/core/src/java/org/apache/lucene/internal/vectorization/DefaultForUtil90.java: ## @@ -0,0 +1,118 @@ +// This file has been automatically generated, DO NOT

[GitHub] [lucene] easyice commented on pull request #12420: Optimize DocIdsWriter for BKD in reverse case with index sorting

2023-07-06 Thread via GitHub
easyice commented on PR #12420: URL: https://github.com/apache/lucene/pull/12420#issuecomment-1623592791 duplicate with https://github.com/apache/lucene/pull/666, so i close it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [lucene] easyice closed pull request #12420: Optimize DocIdsWriter for BKD in reverse case with index sorting

2023-07-06 Thread via GitHub
easyice closed pull request #12420: Optimize DocIdsWriter for BKD in reverse case with index sorting URL: https://github.com/apache/lucene/pull/12420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] benwtrent commented on pull request #12413: Fix HNSW graph visitation limit bug

2023-07-06 Thread via GitHub
benwtrent commented on PR #12413: URL: https://github.com/apache/lucene/pull/12413#issuecomment-1623859719 @msokolov found my bug 🤦 in the simplified version. I updated, removed the need for tracking candidates & results since we only care about the best found entry point. -- This is an

[GitHub] [lucene] jbellis opened a new pull request, #12421: Concurrent hnsw graph and builder, take two

2023-07-06 Thread via GitHub
jbellis opened a new pull request, #12421: URL: https://github.com/apache/lucene/pull/12421 ### Motivation I need to support concurrent reads and writes to an HNSW index for Cassandra. One option would be to partition the document range and assign each range to a single thread with the

[GitHub] [lucene] jbellis commented on pull request #12254: add ConcurrentOnHeapHnswGraph and Builder

2023-07-06 Thread via GitHub
jbellis commented on PR #12254: URL: https://github.com/apache/lucene/pull/12254#issuecomment-1623876231 Closing in favor of #12421. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [lucene] jbellis closed pull request #12254: add ConcurrentOnHeapHnswGraph and Builder

2023-07-06 Thread via GitHub
jbellis closed pull request #12254: add ConcurrentOnHeapHnswGraph and Builder URL: https://github.com/apache/lucene/pull/12254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [lucene] msokolov commented on a diff in pull request #12413: Fix HNSW graph visitation limit bug

2023-07-06 Thread via GitHub
msokolov commented on code in PR #12413: URL: https://github.com/apache/lucene/pull/12413#discussion_r1254834917 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java: ## @@ -256,6 +256,56 @@ public NeighborQueue searchLevel( return results; } + /

[GitHub] [lucene] benwtrent commented on a diff in pull request #12413: Fix HNSW graph visitation limit bug

2023-07-06 Thread via GitHub
benwtrent commented on code in PR #12413: URL: https://github.com/apache/lucene/pull/12413#discussion_r1254849673 ## lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java: ## @@ -256,6 +256,56 @@ public NeighborQueue searchLevel( return results; } +

[GitHub] [lucene] benwtrent commented on pull request #12413: Fix HNSW graph visitation limit bug

2023-07-06 Thread via GitHub
benwtrent commented on PR #12413: URL: https://github.com/apache/lucene/pull/12413#issuecomment-1624222651 > I don't know what bug I found, but this LGTM Commas are important! Just meant to tell you I found my own bug. Not that YOU found my bug. -- This is an automated message from

[GitHub] [lucene] benwtrent merged pull request #12413: Fix HNSW graph visitation limit bug

2023-07-06 Thread via GitHub
benwtrent merged PR #12413: URL: https://github.com/apache/lucene/pull/12413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.a

[GitHub] [lucene] ChrisHegarty commented on a diff in pull request #12417: forutil add vectorized and scalar code

2023-07-06 Thread via GitHub
ChrisHegarty commented on code in PR #12417: URL: https://github.com/apache/lucene/pull/12417#discussion_r1254852005 ## lucene/core/src/java20/org/apache/lucene/internal/vectorization/PanamaForUtil90.java: ## @@ -0,0 +1,8994 @@ +// This file has been automatically generated, DO

[GitHub] [lucene] tang-hi commented on a diff in pull request #12417: forutil add vectorized and scalar code

2023-07-06 Thread via GitHub
tang-hi commented on code in PR #12417: URL: https://github.com/apache/lucene/pull/12417#discussion_r1255241555 ## lucene/core/src/java20/org/apache/lucene/internal/vectorization/PanamaForUtil90.java: ## @@ -0,0 +1,8994 @@ +// This file has been automatically generated, DO NOT E