[GitHub] [lucene] jpountz commented on issue #12358: Optimize `count()` for BooleanQuery disjunction

jpountz commented on issue #12358: URL: https://github.com/apache/lucene/issues/12358#issuecomment-1596907955 I was wondering about a possible alternative approach that would consist of handling this optimization more at the collector level. E.g. we could add a new method to LeafCollector t

[GitHub] [lucene] msokolov commented on issue #11020: CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit [LUCENE-9981]

msokolov commented on issue #11020: URL: https://github.com/apache/lucene/issues/11020#issuecomment-1597066615 @adioss why do you say this is "a security issue"? I don't see any security concerns being discussed here. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [lucene] adioss commented on issue #11020: CompiledAutomaton.getCommonSuffix can be extraordinarily slow, even with default maxDeterminizedStates limit [LUCENE-9981]

adioss commented on issue #11020: URL: https://github.com/apache/lucene/issues/11020#issuecomment-1597126024 Hi @msokolov thanks for the feedback. In fact, * somebody created https://forum.opensearch.org/t/is-opendistro-opensearch-exposed-to-redos-attack/5898/3 (opensearch sensitive

[GitHub] [lucene] jpountz commented on pull request #12374: Provide constructor to accept the LeafSlice computed by extensions

jpountz commented on PR #12374: URL: https://github.com/apache/lucene/pull/12374#issuecomment-1597335385 I'm not entirely happy with this new constructor either, because now there are two ways to customize slicing: either with this new constructor or by overriding the `slices()` method. I'd

[GitHub] [lucene] jpountz commented on issue #12230: TotalHitCountCollector to stop counting when threshold is reached

jpountz commented on issue #12230: URL: https://github.com/apache/lucene/issues/12230#issuecomment-1597398770 Would it help if we had something like a `PartialHitCountCollector` in `lucene/misc` that does what you're describing? -- This is an automated message from the Apache Git Service.

[GitHub] [lucene] javanna commented on issue #12230: TotalHitCountCollector to stop counting when threshold is reached

javanna commented on issue #12230: URL: https://github.com/apache/lucene/issues/12230#issuecomment-1597471217 > Would it help if we had something like a PartialHitCountCollector in lucene/misc that does what you're describing? I believe so, that sounds like a good trade-off. -- Thi

[GitHub] [lucene] andrross commented on pull request #12374: Provide constructor to accept the LeafSlice computed by extensions

andrross commented on PR #12374: URL: https://github.com/apache/lucene/pull/12374#issuecomment-1597890665 +1 to not having two ways to customize slicing. > the approach to override a method to compute slices given a list of segments looks more user-friendly to me than having to comput

[GitHub] [lucene] sohami commented on pull request #12374: Provide constructor to accept the LeafSlice computed by extensions

sohami commented on PR #12374: URL: https://github.com/apache/lucene/pull/12374#issuecomment-1597927888 > +1 to not having two ways to customize slicing. >> the approach to override a method to compute slices given a list of segments looks more user-friendly to me than having to compu

[GitHub] [lucene] easyice opened a new pull request, #12377: Avoid redundant loop for compute min value in DirectMonotonicWriter

easyice opened a new pull request, #12377: URL: https://github.com/apache/lucene/pull/12377 ### Description This small change will reduce an unnecessary loop in DirectMonotonicWriter#flush -- This is an automated message from the Apache Git Service. To respond to the message, pleas