[GitHub] [lucene] romseygeek commented on issue #12318: Async Usage of Lucene Monitor through a Reactive Programming based application

romseygeek commented on issue #12318: URL: https://github.com/apache/lucene/issues/12318#issuecomment-1576322597 Yes, I'd say `match` is unlikely to do any actual IO unless you're explicitly using an on-disk directory (ie not MMapDirectory or ByteBuffersDirectory) for the query index. So i

[GitHub] [lucene] fudongyingluck commented on pull request #12339: feat: soft delete optimize

fudongyingluck commented on PR #12339: URL: https://github.com/apache/lucene/pull/12339#issuecomment-1576330887 This is the esrally result. The command is like`esrally race --track=http_logs --target-hosts=*:9201 --pipeline=benchmark-only --offline --user-tag=softdelete:baseline --challen

[GitHub] [lucene] eliaporciani commented on a diff in pull request #12253: GITHUB-12252: Add function queries for computing similarity scores between knn vectors

eliaporciani commented on code in PR #12253: URL: https://github.com/apache/lucene/pull/12253#discussion_r1217704204 ## lucene/queries/src/java/org/apache/lucene/queries/function/valuesource/KnnVectorValueSource.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene] almogtavor commented on issue #12318: Async Usage of Lucene Monitor through a Reactive Programming based application

almogtavor commented on issue #12318: URL: https://github.com/apache/lucene/issues/12318#issuecomment-1576648070 @romseygeek Oh so that sounds even better than what I thought. In this case, I can treat the `match` operation like a total sync operation and use it in Reactor without bounding

[GitHub] [lucene] jpountz commented on a diff in pull request #12249: Restrict GraphTokenStreamFiniteStrings#articulationPointsRecurse recursion depth

jpountz commented on code in PR #12249: URL: https://github.com/apache/lucene/pull/12249#discussion_r1218211772 ## lucene/core/src/test/org/apache/lucene/util/graph/TestGraphTokenStreamFiniteStrings.java: ## @@ -660,4 +663,27 @@ public void testMultipleSidePathsWithGaps() throws

[GitHub] [lucene] jpountz commented on a diff in pull request #12249: Restrict GraphTokenStreamFiniteStrings#articulationPointsRecurse recursion depth

jpountz commented on code in PR #12249: URL: https://github.com/apache/lucene/pull/12249#discussion_r1218216466 ## lucene/core/src/test/org/apache/lucene/util/graph/TestGraphTokenStreamFiniteStrings.java: ## @@ -16,6 +16,9 @@ */ package org.apache.lucene.util.graph; +import

[GitHub] [lucene] sohami opened a new issue, #12347: Allow extensions of IndexSearcher to provide custom SliceExecutor and slices computation

sohami opened a new issue, #12347: URL: https://github.com/apache/lucene/issues/12347 ### Description For concurrent segment search, lucene uses the slices method to compute the number of work units which can be processed concurrently. a) It calculates slices in the [constructo

[GitHub] [lucene] fudongyingluck commented on pull request #12339: feat: soft delete optimize

fudongyingluck commented on PR #12339: URL: https://github.com/apache/lucene/pull/12339#issuecomment-1577903918 lucene benchmark result, `python3.10 src/python/localrun.py -source wikimediumall` ```TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-