[GitHub] [lucene] romseygeek commented on pull request #12249: Restrict GraphTokenStreamFiniteStrings#articulationPointsRecurse recursion depth

2023-05-02 Thread via GitHub
romseygeek commented on PR #12249: URL: https://github.com/apache/lucene/pull/12249#issuecomment-1531164211 I think an unchecked `IllegalArgumentException` here is fine - it's a problem with the input, and that's what we throw elsewhere on bad inputs. -- This is an automated message from

[GitHub] [lucene] mkhludnev commented on issue #12204: ToParentBlockJoinQuery's explain should depend on its ScoreMode

2023-05-02 Thread via GitHub
mkhludnev commented on issue #12204: URL: https://github.com/apache/lucene/issues/12204#issuecomment-1531181783 `For example, should we return a Exaplanation.match() if a parent matches a query, but no child of the parent doc matches the query? ` I missed the point. If no child matches To

[GitHub] [lucene] mkhludnev commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
mkhludnev commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1182347275 ## lucene/join/src/test/org/apache/lucene/search/join/TestBlockJoin.java: ## @@ -893,10 +892,11 @@ public void testRandom() throws Exception { // System.o

[GitHub] [lucene] mkhludnev commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
mkhludnev commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1182350167 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException {

[GitHub] [lucene] mkhludnev commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
mkhludnev commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1182352128 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException {

[GitHub] [lucene] mkhludnev commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
mkhludnev commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1182353352 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException {

[GitHub] [lucene] mkhludnev commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
mkhludnev commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1182354383 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException {

[GitHub] [lucene] jbellis commented on a diff in pull request #12254: add ConcurrentOnHeapHnswGraph and Builder

2023-05-02 Thread via GitHub
jbellis commented on code in PR #12254: URL: https://github.com/apache/lucene/pull/12254#discussion_r1182389660 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraphBuilder.java: ## @@ -0,0 +1,431 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [lucene] jbellis commented on a diff in pull request #12254: add ConcurrentOnHeapHnswGraph and Builder

2023-05-02 Thread via GitHub
jbellis commented on code in PR #12254: URL: https://github.com/apache/lucene/pull/12254#discussion_r1182397042 ## lucene/core/src/java/org/apache/lucene/util/hnsw/ConcurrentOnHeapHnswGraph.java: ## @@ -0,0 +1,280 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [lucene-solr] epugh commented on pull request #103: SOLR-6994: Implement Windows version of bin/post

2023-05-02 Thread via GitHub
epugh commented on PR #103: URL: https://github.com/apache/lucene-solr/pull/103#issuecomment-1531689506 out of curiosity, if this had been `bin/solr post` and post was just another Tool, would that have simplified this?So `bin/solr.cmd post`, so we don't add another Unix/Windows specifi

[GitHub] [lucene-solr] itygh commented on pull request #103: SOLR-6994: Implement Windows version of bin/post

2023-05-02 Thread via GitHub
itygh commented on PR #103: URL: https://github.com/apache/lucene-solr/pull/103#issuecomment-1531690197 这是来自QQ邮箱的假期自动回复邮件。您好,我最近正在休假中,无法亲自回复您的邮件。我将在假期结束后,尽快给您回复。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
MarcusSorealheis commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1182752118 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
MarcusSorealheis commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1182753128 ## lucene/join/src/test/org/apache/lucene/search/join/TestBlockJoin.java: ## @@ -893,10 +892,11 @@ public void testRandom() throws Exception { // S

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
MarcusSorealheis commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1182768321 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12254: add ConcurrentOnHeapHnswGraph and Builder

2023-05-02 Thread via GitHub
MarcusSorealheis commented on code in PR #12254: URL: https://github.com/apache/lucene/pull/12254#discussion_r1182799620 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraphBuilder.java: ## @@ -0,0 +1,431 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [lucene-solr] janhoy commented on pull request #103: SOLR-6994: Implement Windows version of bin/post

2023-05-02 Thread via GitHub
janhoy commented on PR #103: URL: https://github.com/apache/lucene-solr/pull/103#issuecomment-1531905476 That's a fine idea. A PostTool which calls the SimplePostTool API. We could keep bin/post as a wrapper? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
MarcusSorealheis commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1183028107 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
MarcusSorealheis commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1183030544 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
MarcusSorealheis commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1183035404 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException

[GitHub] [lucene] MarcusSorealheis commented on pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
MarcusSorealheis commented on PR #12245: URL: https://github.com/apache/lucene/pull/12245#issuecomment-1532179923 ok @mkhludnev I made the changes with your blessing and guidance. Thanks for laying groundwork, and for the talk at [Buzzwords '15](https://www.youtube.com/watch?v=z1RqZsjhIMM).

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
MarcusSorealheis commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1183028107 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException

[GitHub] [lucene] MarcusSorealheis commented on a diff in pull request #12245: `ToParentBlockJoinQuery` Explain Support Score Mode

2023-05-02 Thread via GitHub
MarcusSorealheis commented on code in PR #12245: URL: https://github.com/apache/lucene/pull/12245#discussion_r1183035404 ## lucene/join/src/java/org/apache/lucene/search/join/ToParentBlockJoinQuery.java: ## @@ -391,35 +391,86 @@ private void setScoreAndFreq() throws IOException

[GitHub] [lucene] dnhatn commented on pull request #12177: Ensure refreshed reader has the latest index commit generation

2023-05-02 Thread via GitHub
dnhatn commented on PR #12177: URL: https://github.com/apache/lucene/pull/12177#issuecomment-1532235812 @jpountz @uschindler Thanks for the feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] dnhatn closed pull request #12177: Ensure refreshed reader has the latest index commit generation

2023-05-02 Thread via GitHub
dnhatn closed pull request #12177: Ensure refreshed reader has the latest index commit generation URL: https://github.com/apache/lucene/pull/12177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] SrikanthMedisetti opened a new issue, #12259: Case insensitive search

2023-05-02 Thread via GitHub
SrikanthMedisetti opened a new issue, #12259: URL: https://github.com/apache/lucene/issues/12259 ### Description Hello Team, I have the following use case. Store/Index data without tokenize (use StringField) and maintain the same string while storing (maintain case sensitivity w