[GitHub] [lucene] romseygeek commented on a diff in pull request #12222: fix FragEnd bug in BaseFragmentsBuilder

2023-04-12 Thread via GitHub
romseygeek commented on code in PR #1: URL: https://github.com/apache/lucene/pull/1#discussion_r1164021939 ## lucene/highlighter/src/test/org/apache/lucene/search/vectorhighlight/TestSimpleFragmentsBuilder.java: ## @@ -226,7 +226,7 @@ public void testDiscreteMultiValueHi

[GitHub] [lucene] romseygeek commented on a diff in pull request #12222: fix FragEnd bug in BaseFragmentsBuilder

2023-04-12 Thread via GitHub
romseygeek commented on code in PR #1: URL: https://github.com/apache/lucene/pull/1#discussion_r1164024337 ## lucene/highlighter/src/test/org/apache/lucene/search/vectorhighlight/TestSimpleFragmentsBuilder.java: ## @@ -226,7 +226,7 @@ public void testDiscreteMultiValueHi

[GitHub] [lucene] sherman commented on issue #12203: Scalable merge/compaction of big doc values segments.

2023-04-12 Thread via GitHub
sherman commented on issue #12203: URL: https://github.com/apache/lucene/issues/12203#issuecomment-1506041033 Hi, @rmuir! >are you sure docvalues is really the slow part of your merge. I actually think doing this for terms/postings would be more bang-for-the-buck? I am not stat

[GitHub] [lucene] zacharymorn commented on pull request #12194: [GITHUB-11915] Make Lucene smarter about long runs of matches via new API on DISI

2023-04-12 Thread via GitHub
zacharymorn commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1506345579 Hi @jpountz @mikemccand @rmuir @uschindler @gsmiller , I have added some tests in the last few days and believed this PR is ready for review now, could you please take a look and let