[GitHub] [lucene] jpountz opened a new pull request, #12216: Adjust DWPT pool concurrency to the number of cores.

jpountz opened a new pull request, #12216: URL: https://github.com/apache/lucene/pull/12216 After upgrading Elasticsearch to a recent Lucene snapshot, we observed a few indexing slowdowns when indexing with low numbers of cores. This appears to be due to the fact that we lost too much of th

[GitHub] [lucene] zacharymorn commented on pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

zacharymorn commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1488143420 Hi @jpountz , I have been able to add some more changes for all the areas you mentioned, and here are the are the latest benchmark results (with benchmark code changes in https://git

[GitHub] [lucene] fthevenet commented on pull request #12212: Fixes Searches made via DrillSideways may miss documents that should match the query

fthevenet commented on PR #12212: URL: https://github.com/apache/lucene/pull/12212#issuecomment-1488300991 I made some changes and `spotlessCheck` is now happy. I did come across something more worrying while running the full test suite, however: one of the randomized test for TestDr

[GitHub] [lucene] romseygeek commented on issue #12213: Ordered intervals over interleaved terms

romseygeek commented on issue #12213: URL: https://github.com/apache/lucene/issues/12213#issuecomment-1488322013 Fixed by #12214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [lucene] romseygeek closed issue #12213: Ordered intervals over interleaved terms

romseygeek closed issue #12213: Ordered intervals over interleaved terms URL: https://github.com/apache/lucene/issues/12213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [lucene] fthevenet commented on pull request #12212: Fixes Searches made via DrillSideways may miss documents that should match the query

fthevenet commented on PR #12212: URL: https://github.com/apache/lucene/pull/12212#issuecomment-1488527286 OK, so I dug a little deeper in what happens in the failing instance of the random test. It fails because of an ÌllegalArgumentException` thrown by `TopFieldCollector::populateScore

[GitHub] [lucene] fthevenet commented on pull request #12212: Fixes Searches made via DrillSideways may miss documents that should match the query

fthevenet commented on PR #12212: URL: https://github.com/apache/lucene/pull/12212#issuecomment-1488891278 I now believe I know what is going on: I initially changed the iterator to advanced on to `baseApproximation` based on my findings that this causes a bug in one of the three hit collec

[GitHub] [lucene] gsmiller commented on pull request #12212: Fixes Searches made via DrillSideways may miss documents that should match the query

gsmiller commented on PR #12212: URL: https://github.com/apache/lucene/pull/12212#issuecomment-1489067247 Yikes, the saga continues! What a tricky series of bugs in a tricky bit of code. The fix, as it currently stands, seems right to me. I'll go ahead and merge. @fthevenet are you interest

[GitHub] [lucene] gsmiller merged pull request #12212: Fixes Searches made via DrillSideways may miss documents that should match the query

gsmiller merged PR #12212: URL: https://github.com/apache/lucene/pull/12212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[GitHub] [lucene] fthevenet opened a new pull request, #12217: Fixes Searches made via DrillSideways may miss documents that should match the query (backport of #12212)

fthevenet opened a new pull request, #12217: URL: https://github.com/apache/lucene/pull/12217 This is a back port of PR #12212 onto `branch_9x` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] kashkambath commented on issue #12178: TermAutomatonQuery explain() should return relevant explain output instead of null

kashkambath commented on issue #12178: URL: https://github.com/apache/lucene/issues/12178#issuecomment-1489509941 @MarcusSorealheis looks reasonable to me, thanks for taking it on! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [lucene] gsmiller commented on pull request #12212: Fixes Searches made via DrillSideways may miss documents that should match the query

gsmiller commented on PR #12212: URL: https://github.com/apache/lucene/pull/12212#issuecomment-1489527531 Also, congrats on your first contribution @fthevenet 🎆 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] mikemccand commented on pull request #12194: [GITHUB-11915] [Discussion Only] Make Lucene smarter about long runs of matches via new API on DISI

mikemccand commented on PR #12194: URL: https://github.com/apache/lucene/pull/12194#issuecomment-1489590080 > Result 1 (one task has close to 800% improvement!): Egads! Why does Result 2 not also show a massive gain on `AndHighNotMonth` too? Which `wiki` corpus are you running? Are

[GitHub] [lucene] dnhatn commented on a diff in pull request #12216: Adjust DWPT pool concurrency to the number of cores.

dnhatn commented on code in PR #12216: URL: https://github.com/apache/lucene/pull/12216#discussion_r1152745572 ## lucene/core/src/java/org/apache/lucene/index/ConcurrentApproximatePriorityQueue.java: ## @@ -22,25 +22,40 @@ /** * Concurrent version of {@link ApproximatePrior

[GitHub] [lucene] fthevenet commented on pull request #12212: Fixes Searches made via DrillSideways may miss documents that should match the query

fthevenet commented on PR #12212: URL: https://github.com/apache/lucene/pull/12212#issuecomment-1489772575 Thanks @gsmiller ! I have filled a PR to backport this to `branch_9x`, btw: #12217 . -- This is an automated message from the Apache Git Service. To respond to the message, ple