[GitHub] [lucene] zhaih commented on a diff in pull request #12197: [Backport] GITHUB-11838 Add api to allow concurrent query rewrite

2023-03-11 Thread via GitHub
zhaih commented on code in PR #12197: URL: https://github.com/apache/lucene/pull/12197#discussion_r1133053092 ## lucene/core/src/java/org/apache/lucene/search/Query.java: ## @@ -77,10 +85,28 @@ public Weight createWeight(IndexSearcher searcher, ScoreMode scoreMode, float bo

[GitHub] [lucene] stefanvodita commented on pull request #11780: GH#11601: Add ability to compute reader states after refresh

2023-03-11 Thread via GitHub
stefanvodita commented on PR #11780: URL: https://github.com/apache/lucene/pull/11780#issuecomment-1464991650 Thanks for the feedback @gmiller! The way you describe the state-of-the-world makes perfect sense to me, I think we’re on the same page there. What I was trying to do with `S

[GitHub] [lucene] stefanvodita commented on a diff in pull request #12184: [nocommit] Introduce ExpressionFacets along with a demo.

2023-03-11 Thread via GitHub
stefanvodita commented on code in PR #12184: URL: https://github.com/apache/lucene/pull/12184#discussion_r1133137958 ## lucene/facet/src/java/org/apache/lucene/facet/taxonomy/ExpressionFacets.java: ## @@ -0,0 +1,253 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [lucene] MarcusSorealheis commented on pull request #12159: Remove the Now Unused Class `pointInPolygon`.

2023-03-11 Thread via GitHub
MarcusSorealheis commented on PR #12159: URL: https://github.com/apache/lucene/pull/12159#issuecomment-1465007588 Awesome. Thanks all for the review. The main branch is protected. I cannot merge anything myself. Has to be a committer, I believe, even after approval. -- This is an