[GitHub] [lucene] 0roman commented on issue #12165: Integrating Apache Lucene into OSS-Fuzz

2023-02-22 Thread via GitHub
0roman commented on issue #12165: URL: https://github.com/apache/lucene/issues/12165#issuecomment-1439586559 > So I disagree with adding another fuzzing engine into Lucene. We have a library called "randomized-testing" which provides everything needed. Almost every test in Lucene has fuzzin

[GitHub] [lucene] MarcusSorealheis opened a new issue, #12166: `pointInPolygon` method in Tesselator is no longer used

2023-02-22 Thread via GitHub
MarcusSorealheis opened a new issue, #12166: URL: https://github.com/apache/lucene/issues/12166 ### Description The method is not found in the code base, and no tests fail upon its removal. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [lucene] dweiss commented on issue #12165: Integrating Apache Lucene into OSS-Fuzz

2023-02-22 Thread via GitHub
dweiss commented on issue #12165: URL: https://github.com/apache/lucene/issues/12165#issuecomment-1439747236 Sure, never enough bug reports. I keep wondering what does it report as a legitimate error/ problem if the patch catches a lot of what can be thrown from the inside, for example:

[GitHub] [lucene] cpoerschke opened a new issue, #12167: org.apache.lucene.search.grouping.TestGroupFacetCollector.testRandom fails reproducibly

2023-02-22 Thread via GitHub
cpoerschke opened a new issue, #12167: URL: https://github.com/apache/lucene/issues/12167 ### Description Please see https://lists.apache.org/thread/t5hgzv0q177nf8qqyz6h9qhhvwp366gp or https://jenkins.thetaphi.de/job/Lucene-9.x-Linux/8706 for full details. ``` Error Mess

[GitHub] [lucene] gsmiller commented on a diff in pull request #12158: Clone the BytesRef[] values in KeywordField#newSetQuery

2023-02-22 Thread via GitHub
gsmiller commented on code in PR #12158: URL: https://github.com/apache/lucene/pull/12158#discussion_r1114516161 ## lucene/core/src/java/org/apache/lucene/document/KeywordField.java: ## @@ -169,7 +169,7 @@ public static Query newSetQuery(String field, BytesRef... values) {

[GitHub] [lucene] uschindler commented on issue #12165: Integrating Apache Lucene into OSS-Fuzz

2023-02-22 Thread via GitHub
uschindler commented on issue #12165: URL: https://github.com/apache/lucene/issues/12165#issuecomment-1440293014 That is basically the same like: https://github.com/apache/lucene/blob/cce33b07e4f545ae4442c743c5023df1fb5d8fb9/lucene/analysis.tests/src/test/org/apache/lucene/analysis/tests/Tes

[GitHub] [lucene] nknize commented on a diff in pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-22 Thread via GitHub
nknize commented on code in PR #12162: URL: https://github.com/apache/lucene/pull/12162#discussion_r1114644266 ## lucene/core/src/java/org/apache/lucene/document/LatLonField.java: ## @@ -0,0 +1,318 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] nknize commented on a diff in pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-22 Thread via GitHub
nknize commented on code in PR #12162: URL: https://github.com/apache/lucene/pull/12162#discussion_r1114644266 ## lucene/core/src/java/org/apache/lucene/document/LatLonField.java: ## @@ -0,0 +1,318 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [lucene] nknize commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-22 Thread via GitHub
nknize commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1440455711 > This PR doesn't have this, but I'm unsure what should be the canonical representation of a geo point in stored fields. @jpountz Thinking out loud here, would it make sense to add

[GitHub] [lucene] kaivalnp commented on a diff in pull request #12160: Concurrent rewrite for KnnVectorQuery

2023-02-22 Thread via GitHub
kaivalnp commented on code in PR #12160: URL: https://github.com/apache/lucene/pull/12160#discussion_r1114954874 ## lucene/core/src/java/org/apache/lucene/search/AbstractKnnVectorQuery.java: ## @@ -73,17 +76,41 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOExcep

[GitHub] [lucene] kaivalnp commented on pull request #12160: Concurrent rewrite for KnnVectorQuery

2023-02-22 Thread via GitHub
kaivalnp commented on PR #12160: URL: https://github.com/apache/lucene/pull/12160#issuecomment-1440817461 I ran some benchmarks as well (Columns 2-4 are latency in ms): ### enwiki (topK = 100, segment count = 10) | recall | Sequential | CompletableFuture | SliceExecutor | nDoc | fan

[GitHub] [lucene] MarcusSorealheis commented on pull request #12162: Add LatLonField class to index both LatLonPoint and LatLonDocValues

2023-02-22 Thread via GitHub
MarcusSorealheis commented on PR #12162: URL: https://github.com/apache/lucene/pull/12162#issuecomment-1440954007 > I don't care about use of it for shapes since only 0.001% of users give a crap about shapes that's correct, today. -- This is an automated message from the Apache Git