benwtrent opened a new pull request, #12130:
URL: https://github.com/apache/lucene/pull/12130
Sometimes the random search lucene test searcher will wrap the reader.
Consequently, we need to make sure to use the reader provided by the test
`IndexSearcher` or the reader may be different betwe
gsmiller commented on PR #12089:
URL: https://github.com/apache/lucene/pull/12089#issuecomment-1419161514
@rmuir I grabbed your patch for adding a `ScoreSupplier` to
`DocValuesTermsQuery` (#12129) and reran benchmarks. The gap between IndexOrDV
and the "self-optimizing" TermInSetQuery have
rmuir commented on PR #12089:
URL: https://github.com/apache/lucene/pull/12089#issuecomment-1419214500
That's good that it made progress. I will look more into it tonight. I want
to get these patches landed to simplify benchmarking.
its true there is one benchmark where this combined
benwtrent merged PR #12130:
URL: https://github.com/apache/lucene/pull/12130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
uschindler opened a new pull request, #12131:
URL: https://github.com/apache/lucene/pull/12131
In Apache Solr we improved the local settings generation to be done directly
in gardlew startup (similar to gradle downloader).
This has several positive effects:
- We can do our Github C
jpountz commented on code in PR #12089:
URL: https://github.com/apache/lucene/pull/12089#discussion_r1097579916
##
lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java:
##
@@ -380,21 +431,28 @@ public ScorerSupplier scorerSupplier(LeafReaderContext
context) throws
jpountz merged PR #12116:
URL: https://github.com/apache/lucene/pull/12116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
colvinco commented on PR #12131:
URL: https://github.com/apache/lucene/pull/12131#issuecomment-1419339752
There's another reference in smokeTestRelease.py
https://github.com/apache/lucene/blob/8df59fc878795dd94e10d4c15a7bc4f1a919843b/dev-tools/scripts/smokeTestRelease.py#L612-L613
--
This
colvinco closed pull request #12123: Generate gradle.properties from gradlew
URL: https://github.com/apache/lucene/pull/12123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
gsmiller commented on PR #12089:
URL: https://github.com/apache/lucene/pull/12089#issuecomment-1419344879
> but there is also one benchmark where it does substantially worse ("Low
Cardinality + High Cost Country Code Filter Terms").
100%. The issue here is that `TermInSetQuery` gets r
uschindler commented on PR #12131:
URL: https://github.com/apache/lucene/pull/12131#issuecomment-1419364815
> There's another reference in smokeTestRelease.py
>
>
https://github.com/apache/lucene/blob/8df59fc878795dd94e10d4c15a7bc4f1a919843b/dev-tools/scripts/smokeTestRelease.py#L612-
gsmiller commented on code in PR #12089:
URL: https://github.com/apache/lucene/pull/12089#discussion_r1097623311
##
lucene/core/src/java/org/apache/lucene/search/TermInSetQuery.java:
##
@@ -258,13 +271,41 @@ public Matches matches(LeafReaderContext context, int
doc) throws IOEx
rmuir merged PR #12127:
URL: https://github.com/apache/lucene/pull/12127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir merged PR #12128:
URL: https://github.com/apache/lucene/pull/12128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
jpountz commented on PR #12054:
URL: https://github.com/apache/lucene/pull/12054#issuecomment-1419458041
I updated this PR to
- add a `Field.Store` parameter to the constructor that does not rely on
Field's guessing
- update the demo to pass Field.Store.YES as a value for this parame
rmuir merged PR #12129:
URL: https://github.com/apache/lucene/pull/12129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on code in PR #12054:
URL: https://github.com/apache/lucene/pull/12054#discussion_r1097736939
##
lucene/core/src/java/org/apache/lucene/document/KeywordField.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
janhoy commented on PR #12065:
URL: https://github.com/apache/lucene/pull/12065#issuecomment-1419513356
Intereting find. At least we don't include years in every single file as
some projects do, so not a huge burden and we are not obliged to keep or remove
years, we can do as we want.
rmuir commented on code in PR #12054:
URL: https://github.com/apache/lucene/pull/12054#discussion_r1097738909
##
lucene/core/src/java/org/apache/lucene/document/KeywordField.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
uschindler commented on PR #12123:
URL: https://github.com/apache/lucene/pull/12123#issuecomment-1419549026
Oh I did not see that PR. Sorry created a duplicate!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
uschindler commented on PR #12123:
URL: https://github.com/apache/lucene/pull/12123#issuecomment-141914
See #12131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
uschindler commented on PR #12131:
URL: https://github.com/apache/lucene/pull/12131#issuecomment-1419575660
Hi @colvinco, I merged your PR into my branch and found only a small
difference in the windows script, which I fixed. Not sure why Solr did not
apply the JAVA_OPTS for the generator.
uschindler merged PR #12131:
URL: https://github.com/apache/lucene/pull/12131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
rmuir opened a new pull request, #12132:
URL: https://github.com/apache/lucene/pull/12132
Similar to use of ScorerSupplier in #12129, implement it here too, because
creation of a Scorer requires `lookupTerm()` operations in the DV terms
dictionary.
This results in wasted effort/rand
uschindler opened a new pull request, #12133:
URL: https://github.com/apache/lucene/pull/12133
Instead return LongStream for toString() and testing (and possible other
use-cases)
This is a followup of @rmuir's PR #12128 and trashes even more code.
--
This is an automated message fr
uschindler merged PR #12133:
URL: https://github.com/apache/lucene/pull/12133
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler opened a new pull request, #12134:
URL: https://github.com/apache/lucene/pull/12134
Another followup for #12128: Due to previously only testing the
`java.util.Set` interface, the actual testing code never verified that `size()`
and the actual call to `contains(long)` worked corre
uschindler commented on PR #12134:
URL: https://github.com/apache/lucene/pull/12134#issuecomment-1419932992
I found a bug, first test works, second one does not work:
```java
public void testSameValue() {
LongHashSet set2 = new LongHashSet(new long[] {42L, 42L});
ass
jimmykobe1171 commented on code in PR #12126:
URL: https://github.com/apache/lucene/pull/12126#discussion_r1098024345
##
lucene/replicator/src/java/org/apache/lucene/replicator/nrt/CopyJob.java:
##
@@ -206,7 +206,7 @@ private synchronized void _transferAndCancel(CopyJob
prevJob
uschindler commented on PR #12134:
URL: https://github.com/apache/lucene/pull/12134#issuecomment-1419949170
Fixed. Actually code is better readable now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
uschindler merged PR #12134:
URL: https://github.com/apache/lucene/pull/12134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
zacharymorn commented on issue #11428:
URL: https://github.com/apache/lucene/issues/11428#issuecomment-1420073239
Thanks @dnhatn @rmuir @s1monw for the additional information! Yeah I can see
now how changing it to use liv doc and not relying on an explicit field, will
potentially require ch
32 matches
Mail list logo
