colvinco opened a new pull request, #12123:
URL: https://github.com/apache/lucene/pull/12123
Applying the changes from https://github.com/apache/solr/pull/1320 to move
generation of gradle.properties out of gradle itself, into a java class called
from `gradlew`.
--
This is an automated m
janhoy commented on code in PR #12123:
URL: https://github.com/apache/lucene/pull/12123#discussion_r1094533850
##
gradle/generation/local-settings.gradle:
##
@@ -41,87 +41,12 @@ configure(rootProject) {
throw new GradleException(
"Certain gradle tasks and p
colvinco commented on code in PR #12123:
URL: https://github.com/apache/lucene/pull/12123#discussion_r1094544617
##
gradle/generation/local-settings.gradle:
##
@@ -41,87 +41,12 @@ configure(rootProject) {
throw new GradleException(
"Certain gradle tasks and
ioanatia commented on issue #11829:
URL: https://github.com/apache/lucene/issues/11829#issuecomment-1413856068
the test fails because right from the start the random generated polygon is
invalid:
https://github.com/apache/lucene/blob/5acca826330b2afc15b6a2d5e2134d7d1a64e4a9/lucene/co
ioanatia opened a new pull request, #12124:
URL: https://github.com/apache/lucene/pull/12124
### Description
https://github.com/apache/lucene/issues/11829
`BaseXYShapeTestCase.ShapeType.POLYGON.nextShape()` can return polygons that
can fail the self intersection check, which th
benwtrent commented on issue #11419:
URL: https://github.com/apache/lucene/issues/11419#issuecomment-1413927792
Doing some minor digging into this. From what I can tell there are two
things that use the heap logic:
- candidate tracking (max_heap)
- Nearest neighbor tracking (min_
rmuir commented on PR #12118:
URL: https://github.com/apache/lucene/pull/12118#issuecomment-1413950962
> For the record this need comes from implementing sparse retrieval
similarly to what's discussed at #11799, so `FeatureField` no longer stores
features but regular terms here. One option
jpountz commented on PR #12116:
URL: https://github.com/apache/lucene/pull/12116#issuecomment-1413971039
I went one step further:
- StringField now implements storedValue() instead of relying on the
guessing of Field#storedValue()
- IntField, LongField, FloatField and DoubleField now
jpountz merged PR #12124:
URL: https://github.com/apache/lucene/pull/12124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
rmuir commented on issue #12115:
URL: https://github.com/apache/lucene/issues/12115#issuecomment-1413981821
I think @romseygeek explanation makes sense. Wrapping the reader is not
helpful to testing that the highlighter uses it correctly, it just causes
complexity?
To me the easiest
colvinco commented on PR #12123:
URL: https://github.com/apache/lucene/pull/12123#issuecomment-1414014200
Sorry for the force push, I initially committed from the wrong account
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
rmuir commented on PR #12116:
URL: https://github.com/apache/lucene/pull/12116#issuecomment-1414053507
Thanks for removing the type-guessing from the "structured" fields and
supporting store! Can we fix the class-level javadocs for `IntField` & co?
They still say this: "If you also n
jpountz commented on PR #12116:
URL: https://github.com/apache/lucene/pull/12116#issuecomment-1414128335
Thanks for catching this, I just pushed a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
benwtrent merged PR #12118:
URL: https://github.com/apache/lucene/pull/12118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
rmuir commented on code in PR #12116:
URL: https://github.com/apache/lucene/pull/12116#discussion_r1094947639
##
lucene/core/src/java/org/apache/lucene/codecs/StoredFieldsWriter.java:
##
@@ -43,7 +38,7 @@
*
* For every document, {@link #startDocument()} is called, informi
rmuir commented on code in PR #12116:
URL: https://github.com/apache/lucene/pull/12116#discussion_r1094948098
##
lucene/core/src/java/org/apache/lucene/codecs/StoredFieldsWriter.java:
##
@@ -57,17 +52,31 @@ public abstract class StoredFieldsWriter implements
Closeable, Accounta
rmuir commented on code in PR #12116:
URL: https://github.com/apache/lucene/pull/12116#discussion_r1094948838
##
lucene/core/src/java/org/apache/lucene/codecs/StoredFieldsWriter.java:
##
@@ -104,9 +113,9 @@ public int nextDoc() {
/**
* Merges in the stored fields from the
rmuir opened a new issue, #12125:
URL: https://github.com/apache/lucene/issues/12125
### Description
Currently Field.java has these docs:
```
/**
* Expert: directly create a field for a document. Most users should use one
of the sugar
* subclasses:
*
*
*
zhaih opened a new pull request, #12126:
URL: https://github.com/apache/lucene/pull/12126
### Description
See #11885
### Approach
I extracted mainly the ref counting part into the new `FileDeleter` so that
both `IndexFileDeleter` and `ReplicaFileDeleter` will use it as a co
19 matches
Mail list logo
