romseygeek commented on PR #12095:
URL: https://github.com/apache/lucene/pull/12095#issuecomment-1396781927
+1, this has caught me multiple times! I think I'd personally make it the
default but I don't know if others have things set up so that they don't need
to type in their GPG pin.
--
rmuir commented on PR #12094:
URL: https://github.com/apache/lucene/pull/12094#issuecomment-1396882440
Should we just remove the username from the manifest? This doesn't make
sense to me, we don't put usernames anywhere else (e.g. no `@author` at
apache)...
--
This is an automated messag
rmuir commented on PR #12094:
URL: https://github.com/apache/lucene/pull/12094#issuecomment-1396942514
I have also witnessed harassment from solr users towards the person whose
name happens to be in there. Please, lets remove the username.
If I am ignored and this option is kept, I wi
javanna merged PR #12085:
URL: https://github.com/apache/lucene/pull/12085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apa
javanna commented on PR #12085:
URL: https://github.com/apache/lucene/pull/12085#issuecomment-1396993570
Thanks @magibney !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
magibney commented on PR #12095:
URL: https://github.com/apache/lucene/pull/12095#issuecomment-1397344248
The main reason I didn't make this the default is because I'm not sure
whether running this through the releaseWizard would support user input. I'm
using the releaseWizard to guide me t
magibney commented on PR #12094:
URL: https://github.com/apache/lucene/pull/12094#issuecomment-1397358626
> Should we just remove the username from the manifest? This doesn't make
sense to me, we don't put usernames anywhere else (e.g. no @author at apache)...
This seems fine to me. T
magibney opened a new pull request, #12096:
URL: https://github.com/apache/lucene/pull/12096
Following on discussion from #12094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
magibney commented on code in PR #12094:
URL: https://github.com/apache/lucene/pull/12094#discussion_r1081614175
##
gradle/java/jar-manifest.gradle:
##
@@ -46,7 +46,9 @@ subprojects {
if (snapshotBuild) {
return "${project.version} ${gitRev} [snapshot
uschindler commented on PR #12094:
URL: https://github.com/apache/lucene/pull/12094#issuecomment-1397386789
I am fine with both PRs, both technically correct. I don't care about
username. If I would do a relaese I would insert "policeman" into the artifacts.
--
This is an automated messag
vigyasharma opened a new issue, #12097:
URL: https://github.com/apache/lucene/issues/12097
### Description
Found this test failing in Lucene-Check-9.x - Build # 4239.
**Steps to repro:**
```ruby
gradlew test --tests
TestIndexSortSortedNumericDocValuesRangeQuery.testCount
vigyasharma commented on issue #12097:
URL: https://github.com/apache/lucene/issues/12097#issuecomment-1397542712
Wait.. I think the assert should simply be on total no. of documents, not
documents per leaf. Something like:
```java
int count = 0;
for (LeafReaderContext conte
vigyasharma opened a new pull request, #12098:
URL: https://github.com/apache/lucene/pull/12098
Fixes bug in `TestIndexSortSortedNumericDocValuesRangeQuery.
testCountBoundary`.
Addresses #12097
--
This is an automated message from the Apache Git Service.
To respond to the message
jmazanec15 commented on PR #12050:
URL: https://github.com/apache/lucene/pull/12050#issuecomment-1397643952
Per [this
discussion](https://github.com/apache/lucene/pull/12050#discussion_r1061034056),
I refactored OnHeapHnswGraph to use a TreeMap to represent the graph structure
for levels g
jmazanec15 commented on code in PR #12050:
URL: https://github.com/apache/lucene/pull/12050#discussion_r1081896861
##
lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java:
##
@@ -94,36 +93,83 @@ public int size() {
}
/**
- * Add node on the given level
rmuir commented on PR #12098:
URL: https://github.com/apache/lucene/pull/12098#issuecomment-1397749519
if a test wants to enforce it only has one segment, it should
`forceMerge()`, make use of `LuceneTestCase.getOnlyLeafReader()`, etc.
Otherwise the number of segments can vary based
vigyasharma merged PR #12098:
URL: https://github.com/apache/lucene/pull/12098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
vigyasharma closed issue #12097:
TestIndexSortSortedNumericDocValuesRangeQuery.testCountBoundary failure
URL: https://github.com/apache/lucene/issues/12097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
18 matches
Mail list logo
