[GitHub] [lucene] mohamedniyaz1996 commented on issue #11902: Customization of Edit distance costs for different operations

mohamedniyaz1996 commented on issue #11902: URL: https://github.com/apache/lucene/issues/11902#issuecomment-1386830082 @tang-hi , I agree it will be a dip in performance - but still it can be provided as a feature with a warning about performance drop. -- This is an automated message from

[GitHub] [lucene] rmuir closed issue #11902: Customization of Edit distance costs for different operations

rmuir closed issue #11902: Customization of Edit distance costs for different operations URL: https://github.com/apache/lucene/issues/11902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [lucene] rmuir commented on issue #11902: Customization of Edit distance costs for different operations

rmuir commented on issue #11902: URL: https://github.com/apache/lucene/issues/11902#issuecomment-1386981136 this would be far too trappy, entirely too slow. use toy python libraries like the one referenced if you want to build toys, but this is a library for building search engines -- Th

[GitHub] [lucene] rmuir commented on issue #12090: Building a Lucene posting format that leverages the Java Vector API

rmuir commented on issue #12090: URL: https://github.com/apache/lucene/issues/12090#issuecomment-1386986113 There is nothing to do here about it. Convince OpenJDK to stop hostaging the vector api in incubating status like they have done for years. When it is at least in "Preview" stat

[GitHub] [lucene] rmuir commented on issue #12091: Speeding up Lucene Vector Similarity through the Java Vector API

rmuir commented on issue #12091: URL: https://github.com/apache/lucene/issues/12091#issuecomment-1386986370 There is nothing to do here about it. Convince OpenJDK to stop hostaging the vector api in incubating status like they have done for years. When it is at least in "Preview" stat

[GitHub] [lucene] magibney opened a new pull request, #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

magibney opened a new pull request, #12094: URL: https://github.com/apache/lucene/pull/12094 buildAndPushRelease (release script) currently sets the username portion of the `ImplementationVersion` property MANIFEST.MF entry for built jars according the local machine username of the active u

[GitHub] [lucene] magibney opened a new pull request, #12095: buildAndPushRelease should optionally pause before assembleRelease

magibney opened a new pull request, #12095: URL: https://github.com/apache/lucene/pull/12095 buildAndPushRelease currently proceeds directly from running tests to assembling the release (and signing jars). Since assembleRelease prompts for GPG key PIN, it can easily happen that the RM steps

[GitHub] [lucene] rmuir commented on pull request #12093: Deprecate support for UTF8TaxonomyWriterCache

rmuir commented on PR #12093: URL: https://github.com/apache/lucene/pull/12093#issuecomment-1387508863 @vigyasharma do you intend to change the default implementation in branch_9x to LRU as well? (either here on this issue or via #12092). I think it would be good to not default to the depre

[GitHub] [lucene] vigyasharma commented on pull request #12093: Deprecate support for UTF8TaxonomyWriterCache

vigyasharma commented on PR #12093: URL: https://github.com/apache/lucene/pull/12093#issuecomment-1387643504 > hange the default implementation in branch_9x to LRU as well? (either here on this issue or via #12092). I think it would be good to not default to the deprecated impl. Ah,

[GitHub] [lucene] vigyasharma merged pull request #12092: Remove UTF8TaxonomyWriterCache

vigyasharma merged PR #12092: URL: https://github.com/apache/lucene/pull/12092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[GitHub] [lucene] jmazanec15 commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

jmazanec15 commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1080646383 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -94,36 +93,83 @@ public int size() { } /** - * Add node on the given level

[GitHub] [lucene] vigyasharma merged pull request #12093: Deprecate support for UTF8TaxonomyWriterCache

vigyasharma merged PR #12093: URL: https://github.com/apache/lucene/pull/12093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[GitHub] [lucene] uschindler commented on a diff in pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

uschindler commented on code in PR #12094: URL: https://github.com/apache/lucene/pull/12094#discussion_r1080678559 ## gradle/java/jar-manifest.gradle: ## @@ -46,7 +46,9 @@ subprojects { if (snapshotBuild) { return "${project.version} ${gitRev} [snapsh

[GitHub] [lucene] uschindler commented on a diff in pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

uschindler commented on code in PR #12094: URL: https://github.com/apache/lucene/pull/12094#discussion_r1080678559 ## gradle/java/jar-manifest.gradle: ## @@ -46,7 +46,9 @@ subprojects { if (snapshotBuild) { return "${project.version} ${gitRev} [snapsh

[GitHub] [lucene] uschindler commented on a diff in pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

uschindler commented on code in PR #12094: URL: https://github.com/apache/lucene/pull/12094#discussion_r1080679818 ## dev-tools/scripts/buildAndPushRelease.py: ## @@ -120,6 +120,8 @@ def prepare(root, version, gpg_key_id, gpg_password, gpg_home=None, sign_gradle= print(' pr

[GitHub] [lucene] uschindler commented on a diff in pull request #12094: releaseWizard: allow explicitly setting MANIFEST.MF userid (e.g., to apache id)

uschindler commented on code in PR #12094: URL: https://github.com/apache/lucene/pull/12094#discussion_r1080680435 ## dev-tools/scripts/buildAndPushRelease.py: ## @@ -120,6 +120,8 @@ def prepare(root, version, gpg_key_id, gpg_password, gpg_home=None, sign_gradle= print(' pr

[GitHub] [lucene] LuXugang merged pull request #12084: Same bound with fallbackQuery

LuXugang merged PR #12084: URL: https://github.com/apache/lucene/pull/12084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

[GitHub] [lucene] vigyasharma commented on issue #12082: LeafFieldComparator setBottom not being called before compareBottom

vigyasharma commented on issue #12082: URL: https://github.com/apache/lucene/issues/12082#issuecomment-1396549638 I think you're right that `bottom` should be scoped outside the `LeafFieldComparator`. It stores the bottom slot value for competitive hits and should survive across leaf contex

[GitHub] [lucene] vigyasharma commented on issue #12000: Lucene-facet leaves ThreadLocal that creates a memory leak

vigyasharma commented on issue #12000: URL: https://github.com/apache/lucene/issues/12000#issuecomment-1396551522 Removed UTF8TaxonomyWriterCache from main, and deprecated it in 9.x. We now default to LruTaxonomyWriterCache. PRs have been merged in. Closing this issue. -- This is an autom

[GitHub] [lucene] vigyasharma closed issue #12000: Lucene-facet leaves ThreadLocal that creates a memory leak

vigyasharma closed issue #12000: Lucene-facet leaves ThreadLocal that creates a memory leak URL: https://github.com/apache/lucene/issues/12000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe