[GitHub] [lucene] uschindler commented on issue #11870: Create a Markdown based documentation

2023-01-06 Thread GitBox
uschindler commented on issue #11870: URL: https://github.com/apache/lucene/issues/11870#issuecomment-1373330425 There is markdown (or commonmark) support coming for JDK javadoc: https://bugs.openjdk.org/browse/JDK-8298405 So at some point we might replace those overview HTML files by

[GitHub] [lucene] zhaih commented on a diff in pull request #12050: Reuse HNSW graph for intialization during merge

2023-01-06 Thread GitBox
zhaih commented on code in PR #12050: URL: https://github.com/apache/lucene/pull/12050#discussion_r1063681335 ## lucene/core/src/java/org/apache/lucene/util/hnsw/OnHeapHnswGraph.java: ## @@ -94,36 +93,83 @@ public int size() { } /** - * Add node on the given level +

[GitHub] [lucene] zhaih commented on a diff in pull request #12034: Remove null check in IndexReaderContext#leaves() usages

2023-01-06 Thread GitBox
zhaih commented on code in PR #12034: URL: https://github.com/apache/lucene/pull/12034#discussion_r1063684215 ## lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java: ## @@ -314,19 +314,15 @@ private static TermStates adjustFrequencies( IndexReaderContext r

[GitHub] [lucene] ErikPelli commented on a diff in pull request #12034: Remove null check in IndexReaderContext#leaves() usages

2023-01-06 Thread GitBox
ErikPelli commented on code in PR #12034: URL: https://github.com/apache/lucene/pull/12034#discussion_r1063816707 ## lucene/core/src/java/org/apache/lucene/search/BlendedTermQuery.java: ## @@ -314,19 +314,15 @@ private static TermStates adjustFrequencies( IndexReaderConte

[GitHub] [lucene] zhaih merged pull request #12034: Remove null check in IndexReaderContext#leaves() usages

2023-01-06 Thread GitBox
zhaih merged PR #12034: URL: https://github.com/apache/lucene/pull/12034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apach

[GitHub] [lucene] rmuir commented on issue #12067: Getting exception on search after upgrading to Lucene 9.4

2023-01-06 Thread GitBox
rmuir commented on issue #12067: URL: https://github.com/apache/lucene/issues/12067#issuecomment-1374409314 The bug is in your code, because you index inconsitently different data in the same field: the data going into docvalues is lowercased, the data going into stringfield is not. -- T

[GitHub] [lucene] rmuir closed issue #12067: Getting exception on search after upgrading to Lucene 9.4

2023-01-06 Thread GitBox
rmuir closed issue #12067: Getting exception on search after upgrading to Lucene 9.4 URL: https://github.com/apache/lucene/issues/12067 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c