[GitHub] [lucene] jpountz commented on a diff in pull request #12040: Minor refactoring and cleanup to BooleanQuery code

jpountz commented on code in PR #12040: URL: https://github.com/apache/lucene/pull/12040#discussion_r1057563242 ## lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java: ## @@ -204,11 +204,11 @@ BooleanQuery rewriteNoScoring(IndexSearcher indexSearcher) throws IOExcep

[GitHub] [lucene] twosom commented on a diff in pull request #12040: Minor refactoring and cleanup to BooleanQuery code

twosom commented on code in PR #12040: URL: https://github.com/apache/lucene/pull/12040#discussion_r1057574839 ## lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java: ## @@ -204,11 +204,11 @@ BooleanQuery rewriteNoScoring(IndexSearcher indexSearcher) throws IOExcept

[GitHub] [lucene] jpountz merged pull request #12039: Avoid sorting values of multi-valued writers if there is a single value.

jpountz merged PR #12039: URL: https://github.com/apache/lucene/pull/12039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz merged pull request #11968: Replace JIRA release instructions with GitHub.

jpountz merged PR #11968: URL: https://github.com/apache/lucene/pull/11968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz merged pull request #12011: Tune the amount of memory that is allocated to sorting postings upon flushing.

jpountz merged PR #12011: URL: https://github.com/apache/lucene/pull/12011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] jpountz merged pull request #12037: Optimize flush of doc-value fields that are effectively single-valued when an index sort is configured.

jpountz merged PR #12037: URL: https://github.com/apache/lucene/pull/12037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] twosom commented on a diff in pull request #12040: Minor refactoring and cleanup to BooleanQuery code

twosom commented on code in PR #12040: URL: https://github.com/apache/lucene/pull/12040#discussion_r1057622205 ## lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java: ## @@ -346,21 +338,15 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOException {

[GitHub] [lucene] twosom commented on a diff in pull request #12040: Minor refactoring and cleanup to BooleanQuery code

twosom commented on code in PR #12040: URL: https://github.com/apache/lucene/pull/12040#discussion_r1057623506 ## lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java: ## @@ -346,21 +338,15 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOException {

[GitHub] [lucene] twosom commented on a diff in pull request #12040: Minor refactoring and cleanup to BooleanQuery code

twosom commented on code in PR #12040: URL: https://github.com/apache/lucene/pull/12040#discussion_r1057623506 ## lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java: ## @@ -346,21 +338,15 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOException {

[GitHub] [lucene] twosom commented on a diff in pull request #12040: Minor refactoring and cleanup to BooleanQuery code

twosom commented on code in PR #12040: URL: https://github.com/apache/lucene/pull/12040#discussion_r1057624186 ## lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java: ## @@ -408,19 +393,15 @@ public Query rewrite(IndexSearcher indexSearcher) throws IOException {

[GitHub] [lucene] ErikPelli commented on pull request #12035: Remove redundant code in Lucene search

ErikPelli commented on PR #12035: URL: https://github.com/apache/lucene/pull/12035#issuecomment-1365878989 > The change to `IndexSearcher#slices` looks fine. I'm less sure about changes to `DefaultBulkScorer`: it puts more pressure on the compiler to detect that `twoPhase == null` is a loop