[GitHub] [lucene] uschindler commented on pull request #12033: Patch class files for Java 19 code to no longer have the "preview" flag (this enables Java 19 memory segments by default)

2022-12-24 Thread GitBox
uschindler commented on PR #12033: URL: https://github.com/apache/lucene/pull/12033#issuecomment-1364516210 > I assume that older JDK support will be eagerly cleaned up? Say only provide support for JDK N and JDK N+1. So the currently shipping JDK and the one in development. Thus limiting t

[GitHub] [lucene] jpountz opened a new pull request, #12037: Optimize flush of doc-value fields that are effectively single-valued when an index sort is configured.

2022-12-24 Thread GitBox
jpountz opened a new pull request, #12037: URL: https://github.com/apache/lucene/pull/12037 This iterates on #399 to also optimize the case when an index sort is configured. When cutting over the NYC taxis benchmark to the new numeric fields, [flush times](http://people.apache.org/~mikem

[GitHub] [lucene] rmuir opened a new pull request, #12038: remove non-NRT replication support

2022-12-24 Thread GitBox
rmuir opened a new pull request, #12038: URL: https://github.com/apache/lucene/pull/12038 Lucene's replicator/ module has really two replication APIs: NRT and the older non-NRT. The NRT replication is nice, it is actually JUST an API, hence there's no network support or anything like

[GitHub] [lucene] rmuir commented on pull request #12038: remove non-NRT replication support

2022-12-24 Thread GitBox
rmuir commented on PR #12038: URL: https://github.com/apache/lucene/pull/12038#issuecomment-1364546284 This PR is for `main` branch only. For 9.x i would only push `@deprecated` and `@Deprecated` tags. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [lucene] jpountz opened a new pull request, #12039: Avoid sorting values of multi-valued writers if there is a single value.

2022-12-24 Thread GitBox
jpountz opened a new pull request, #12039: URL: https://github.com/apache/lucene/pull/12039 They currently call `Arrays#sort`, which incurs a tiny bit of overhead due to range checks and some logic to determine the optimal sorting algorithm to use depending on the number of values. We can s

[GitHub] [lucene] ErikPelli commented on a diff in pull request #12036: Remove redundant code in Lucene geo

2022-12-24 Thread GitBox
ErikPelli commented on code in PR #12036: URL: https://github.com/apache/lucene/pull/12036#discussion_r1056874550 ## lucene/core/src/java/org/apache/lucene/geo/GeoUtils.java: ## @@ -205,13 +205,7 @@ static boolean within90LonDegrees(double lon, double minLon, double maxLon) {

[GitHub] [lucene] rmuir commented on a diff in pull request #12036: Remove redundant code in Lucene geo

2022-12-24 Thread GitBox
rmuir commented on code in PR #12036: URL: https://github.com/apache/lucene/pull/12036#discussion_r1056883193 ## lucene/core/src/java/org/apache/lucene/geo/GeoUtils.java: ## @@ -205,13 +205,7 @@ static boolean within90LonDegrees(double lon, double minLon, double maxLon) { pu

[GitHub] [lucene] mdmarshmallow commented on pull request #11958: GITHUB-11868: Add FilterIndexInput and FilterIndexOutput wrapper classes

2022-12-24 Thread GitBox
mdmarshmallow commented on PR #11958: URL: https://github.com/apache/lucene/pull/11958#issuecomment-1364622450 Added the java docs and the CHANGES.txt entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [lucene] twosom opened a new pull request, #12040: Minor refactoring and cleanup to BooleanQuery code

2022-12-24 Thread GitBox
twosom opened a new pull request, #12040: URL: https://github.com/apache/lucene/pull/12040 ### Description some cleanups (typos, use Java17 feature , improving readability) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G