uschindler opened a new pull request, #12033:
URL: https://github.com/apache/lucene/pull/12033
After many complaints that you need to use `--enable-preview` to use the new
MMapDirectory with Java 19 (especially Elasticsearch peope where afraid that
passing this flag enables other "unwanted
uschindler commented on PR #12033:
URL: https://github.com/apache/lucene/pull/12033#issuecomment-1363998405
As cleanup I also moved all MR-JAR special cases into a separate gradle file
to have `javac.gradle` clean and only contain the defaults.
--
This is an automated message from the Apa
uschindler commented on PR #12033:
URL: https://github.com/apache/lucene/pull/12033#issuecomment-1364028457
Maybe have a look, @mcimadamore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
ErikPelli opened a new pull request, #12034:
URL: https://github.com/apache/lucene/pull/12034
Avoid the call of get() method call in adjustFrequencies if the leaves List
object returned by the context is null.
Actually the cycle is executed 1 time if it's null and this will cause a
Null
ErikPelli opened a new pull request, #12035:
URL: https://github.com/apache/lucene/pull/12035
Weight: Move the twoPhase argument check in the loop, so the condition is
true when twoPhase argument is null or, when not null, if matches() return true.
IndexSearcher: group is an ArrayList
ErikPelli opened a new pull request, #12036:
URL: https://github.com/apache/lucene/pull/12036
Tessellator: Move boolean check repeated 4 times to its dedicated function.
Replace pointInTriangle implementation with the Component2D one, passing to
it the calculated minX, minY, maxX, maxY.
rmuir commented on code in PR #12036:
URL: https://github.com/apache/lucene/pull/12036#discussion_r1056723062
##
lucene/core/src/java/org/apache/lucene/geo/GeoUtils.java:
##
@@ -205,13 +205,7 @@ static boolean within90LonDegrees(double lon, double
minLon, double maxLon) {
pu
rmuir commented on PR #12033:
URL: https://github.com/apache/lucene/pull/12033#issuecomment-1364453343
theoretically i am fine with the change, the less `SIGSEGV` the better. the
hoops we jump through though :)
--
This is an automated message from the Apache Git Service.
To respond to the