[GitHub] [lucene] uschindler opened a new pull request, #12033: Patch class files for Java 19 code to no longer have the "preview" flag (this enables Java 19 memory segments by default)

2022-12-23 Thread GitBox
uschindler opened a new pull request, #12033: URL: https://github.com/apache/lucene/pull/12033 After many complaints that you need to use `--enable-preview` to use the new MMapDirectory with Java 19 (especially Elasticsearch peope where afraid that passing this flag enables other "unwanted

[GitHub] [lucene] uschindler commented on pull request #12033: Patch class files for Java 19 code to no longer have the "preview" flag (this enables Java 19 memory segments by default)

2022-12-23 Thread GitBox
uschindler commented on PR #12033: URL: https://github.com/apache/lucene/pull/12033#issuecomment-1363998405 As cleanup I also moved all MR-JAR special cases into a separate gradle file to have `javac.gradle` clean and only contain the defaults. -- This is an automated message from the Apa

[GitHub] [lucene] uschindler commented on pull request #12033: Patch class files for Java 19 code to no longer have the "preview" flag (this enables Java 19 memory segments by default)

2022-12-23 Thread GitBox
uschindler commented on PR #12033: URL: https://github.com/apache/lucene/pull/12033#issuecomment-1364028457 Maybe have a look, @mcimadamore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene] ErikPelli opened a new pull request, #12034: Avoid possible NullPointerException in BlendedTermQuery

2022-12-23 Thread GitBox
ErikPelli opened a new pull request, #12034: URL: https://github.com/apache/lucene/pull/12034 Avoid the call of get() method call in adjustFrequencies if the leaves List object returned by the context is null. Actually the cycle is executed 1 time if it's null and this will cause a Null

[GitHub] [lucene] ErikPelli opened a new pull request, #12035: Remove redundant code in Lucene search

2022-12-23 Thread GitBox
ErikPelli opened a new pull request, #12035: URL: https://github.com/apache/lucene/pull/12035 Weight: Move the twoPhase argument check in the loop, so the condition is true when twoPhase argument is null or, when not null, if matches() return true. IndexSearcher: group is an ArrayList

[GitHub] [lucene] ErikPelli opened a new pull request, #12036: Remove redundant code in Lucene geo

2022-12-23 Thread GitBox
ErikPelli opened a new pull request, #12036: URL: https://github.com/apache/lucene/pull/12036 Tessellator: Move boolean check repeated 4 times to its dedicated function. Replace pointInTriangle implementation with the Component2D one, passing to it the calculated minX, minY, maxX, maxY.

[GitHub] [lucene] rmuir commented on a diff in pull request #12036: Remove redundant code in Lucene geo

2022-12-23 Thread GitBox
rmuir commented on code in PR #12036: URL: https://github.com/apache/lucene/pull/12036#discussion_r1056723062 ## lucene/core/src/java/org/apache/lucene/geo/GeoUtils.java: ## @@ -205,13 +205,7 @@ static boolean within90LonDegrees(double lon, double minLon, double maxLon) { pu

[GitHub] [lucene] rmuir commented on pull request #12033: Patch class files for Java 19 code to no longer have the "preview" flag (this enables Java 19 memory segments by default)

2022-12-23 Thread GitBox
rmuir commented on PR #12033: URL: https://github.com/apache/lucene/pull/12033#issuecomment-1364453343 theoretically i am fine with the change, the less `SIGSEGV` the better. the hoops we jump through though :) -- This is an automated message from the Apache Git Service. To respond to the