gf2121 opened a new issue, #12028:
URL: https://github.com/apache/lucene/issues/12028
### Description
Today `TermInSetQuery` can be rewritten to disjunction BooleanQuery to
lazily materialize query result if terms count < 16. This can significantly
improve query performance in cases
gf2121 commented on issue #12028:
URL: https://github.com/apache/lucene/issues/12028#issuecomment-1361021593
I benchmarked some queries like `_id = '1' AND cardinality_8_field in (1, 2,
3) ` on 1M docs, here is the result:
```
Benchmark Mode Cnt ScoreEr
alessandrobenedetti opened a new pull request, #12029:
URL: https://github.com/apache/lucene/pull/12029
### Description
Knn Queries are locked currently, it would be beneficial for applications
using them to have access to getters and setters.
An example is how filter queries are manag
rmuir commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361503436
queries should be immutable, see Query.java documentation. Hence I don't
think we should add getter/setters or remove final keywords.
--
This is an automated message from the Apache Git
alessandrobenedetti commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361523810
Thanks @rmuir for the prompt answer, I took a look at Query.java, and
couldn't find any particular reason for the Knn query to be immutable(aside
from historical reasons?).
rmuir commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361552026
All queries need to be immutable for the query cache to work correctly and
consistently.
You are right, the docs need help here. Unfortunately docs on immutability
were attached to
rmuir commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361577899
the `getTarget()` getters are unsafe as they return mutable things
(`float[]`, `BytesRef`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please
alessandrobenedetti commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361578619
Thanks, @rmuir for the explanation, it seems reasonable and definitely, I
won't argue with that.
For the sake of my needs, just the getters would be fine(and I'll clone the
alessandrobenedetti commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361606803
@rmuir you are right again, I gave it another try, using copies, this should
be safe.
If there are still concerns I may move to some Builder/Constructors
approaches, to be
epotyom commented on PR #12025:
URL: https://github.com/apache/lucene/pull/12025#issuecomment-1361631708
> At the same time, for demo module we already have a method for
compile-time safety of examples that doesn't rely upon this new `@snippet`. See
IndexFiles/SearchFiles where we simply in
twosom opened a new pull request, #12030:
URL: https://github.com/apache/lucene/pull/12030
### Description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
rmuir merged PR #12025:
URL: https://github.com/apache/lucene/pull/12025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #12025:
URL: https://github.com/apache/lucene/pull/12025#issuecomment-1361698706
Thank you @epotyom for this! I'll backport to 9.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rmuir closed issue #11582: Update Faceting user guide [LUCENE-10546]
URL: https://github.com/apache/lucene/issues/11582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
rmuir commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361726280
BytesRef.clone won't do what we want here. it is a shallow clone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dsmiley commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1361753981
Completely agree with Robert -- Query subclasses ought to be immutable and
the javadocs ought to be updated to scream this. Nasty/hard bugs happen when a
Query is mutable.
--
This is
rmuir merged PR #12030:
URL: https://github.com/apache/lucene/pull/12030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #12030:
URL: https://github.com/apache/lucene/pull/12030#issuecomment-1361838583
Thank you @twosom !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
jpountz commented on PR #12011:
URL: https://github.com/apache/lucene/pull/12011#issuecomment-1362512365
I plan on merging it soon if there are no objections.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
alessandrobenedetti commented on PR #12029:
URL: https://github.com/apache/lucene/pull/12029#issuecomment-1362512997
Thanks again @rmuir, moved to a deep copy!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
20 matches
Mail list logo
