[GitHub] [lucene] javanna merged pull request #11985: ExitableTerms to override getMin and getMax

javanna merged PR #11985: URL: https://github.com/apache/lucene/pull/11985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene-solr] epugh commented on a diff in pull request #976: SOLR-13749: Implement support for joining across collections with multiple shards

epugh commented on code in PR #976: URL: https://github.com/apache/lucene-solr/pull/976#discussion_r1035762208 ## solr/core/src/java/org/apache/solr/search/join/XCJFQuery.java: ## @@ -0,0 +1,380 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * co

[GitHub] [lucene] v00d00c0de opened a new issue, #11989: Null support in PatternReplaceFilter/PatternReplaceFilterFactory

v00d00c0de opened a new issue, #11989: URL: https://github.com/apache/lucene/issues/11989 ### Description _org.apache.lucene.analysis.pattern.PatternReplaceFilter_ supports null value in 'replacement' parameter which is eventually replaced by an empty string. After an upgrade

[GitHub] [lucene] rmuir closed issue #11989: Null support in PatternReplaceFilter/PatternReplaceFilterFactory

rmuir closed issue #11989: Null support in PatternReplaceFilter/PatternReplaceFilterFactory URL: https://github.com/apache/lucene/issues/11989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [lucene] rmuir commented on issue #11989: Null support in PatternReplaceFilter/PatternReplaceFilterFactory

rmuir commented on issue #11989: URL: https://github.com/apache/lucene/issues/11989#issuecomment-1332052656 Support null  😂 Rejecting null values with NullPointerException is the correct behavior here. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene] romseygeek opened a new pull request, #11990: Don't let merged passages push out lower-scoring ones

romseygeek opened a new pull request, #11990: URL: https://github.com/apache/lucene/pull/11990 PassageScorer uses a priority queue of size `maxPassages` to keep track of which highlighted passages are worth returning to the user. Once all passages have been collected, we go through and

[GitHub] [lucene] luyuncheng commented on pull request #11987: Make Decompressor release memory buffer

luyuncheng commented on PR #11987: URL: https://github.com/apache/lucene/pull/11987#issuecomment-1332277159 @rmuir Thanks for the replying this issue, i did some benchmarks: > better to assign null and create array of the correct size, if it won't be reused. LGTM , i assigned n

[GitHub] [lucene] rmuir commented on pull request #11987: Make Decompressor release memory buffer

rmuir commented on PR #11987: URL: https://github.com/apache/lucene/pull/11987#issuecomment-1332307323 Thanks for running the stored fields benchmark: are you able to report the retrieval time as well? That's my first concern. Maybe, the StoredFieldsBenchmark.java needs to be run standalone

[GitHub] [lucene] luyuncheng commented on pull request #11987: Make Decompressor release memory buffer

luyuncheng commented on PR #11987: URL: https://github.com/apache/lucene/pull/11987#issuecomment-1332336907 > are you able to report the retrieval time as well? runStoredFieldsBenchmark.py |retrieved_time_msec | Baseline | Candidate | | :---|:: |

[GitHub] [lucene] rmuir commented on pull request #11987: Make Decompressor release memory buffer

rmuir commented on PR #11987: URL: https://github.com/apache/lucene/pull/11987#issuecomment-1332427293 Thanks, yeah my remaining concern is the non-optimized merge... especially for those that delete and update documents (as it prevents them from getting optimized merges). Alternativ

[GitHub] [lucene] costin commented on pull request #11984: Add exponential growth to TimeLimitingBulkScorer

costin commented on PR #11984: URL: https://github.com/apache/lucene/pull/11984#issuecomment-1332462998 > LGTM. Can you add a CHANGES entry under 9.5? Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene] uschindler commented on pull request #11987: Make Decompressor release memory buffer

uschindler commented on PR #11987: URL: https://github.com/apache/lucene/pull/11987#issuecomment-1332570305 Yes, before we work around all that stuff here, I'd also suggest to remove those ThreadLocals. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [lucene] navneet1v commented on issue #11752: Enable Relate Interface of Shape Doc Values to be used by clients of Lucene

navneet1v commented on issue #11752: URL: https://github.com/apache/lucene/issues/11752#issuecomment-1332600579 Resolving the issue as the code is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene] navneet1v closed issue #11752: Enable Relate Interface of Shape Doc Values to be used by clients of Lucene

navneet1v closed issue #11752: Enable Relate Interface of Shape Doc Values to be used by clients of Lucene URL: https://github.com/apache/lucene/issues/11752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene] navneet1v commented on issue #11827: Release manager should review lucene benchmarks before building release candidates

navneet1v commented on issue #11827: URL: https://github.com/apache/lucene/issues/11827#issuecomment-1332603551 @iverase Where are we seeing the degradation? We are seeing the degradation in K-NN Queries between 9.3 and 9.4 release. I am trying to figure out if there are other clients of lu

[GitHub] [lucene] dweiss commented on a diff in pull request #11990: Don't let merged passages push out lower-scoring ones

dweiss commented on code in PR #11990: URL: https://github.com/apache/lucene/pull/11990#discussion_r1036450814 ## lucene/highlighter/src/java/org/apache/lucene/search/matchhighlight/PassageSelector.java: ## @@ -89,8 +89,9 @@ public List pickBest( } // Best passages s

[GitHub] [lucene] dweiss commented on a diff in pull request #11990: Don't let merged passages push out lower-scoring ones

dweiss commented on code in PR #11990: URL: https://github.com/apache/lucene/pull/11990#discussion_r1036458813 ## lucene/highlighter/src/java/org/apache/lucene/search/matchhighlight/PassageSelector.java: ## @@ -89,8 +89,9 @@ public List pickBest( } // Best passages s

[GitHub] [lucene] iverase commented on issue #11827: Release manager should review lucene benchmarks before building release candidates

iverase commented on issue #11827: URL: https://github.com/apache/lucene/issues/11827#issuecomment-124626 @navneet1v this issue was triggered by a regression on a geo query and was addressed before the release. I have no knowledge of any regression in vector search. -- This is an aut