[GitHub] [lucene] dweiss commented on a diff in pull request #11893: hunspell: allow for faster dictionary iteration during 'suggest' by using more memory (opt-in)

2022-11-01 Thread GitBox
dweiss commented on code in PR #11893: URL: https://github.com/apache/lucene/pull/11893#discussion_r1010183268 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java: ## @@ -72,10 +77,29 @@ public Hunspell(Dictionary dictionary) { * or sugge

[GitHub] [lucene] matriv commented on pull request #11856: Fix nanos to millis conversion for tests

2022-11-01 Thread GitBox
matriv commented on PR #11856: URL: https://github.com/apache/lucene/pull/11856#issuecomment-1298239363 > I think this is ready to be merged, sorry for the delay. One thing - could you add an appropriate lucene/CHANGES.txt entry? @dweiss Thanks a lot for taking care, apologies, I was

[GitHub] [lucene] benwtrent commented on a diff in pull request #11860: GITHUB-11830 Better optimize storage for vector connections

2022-11-01 Thread GitBox
benwtrent commented on code in PR #11860: URL: https://github.com/apache/lucene/pull/11860#discussion_r1010320791 ## lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsReader.java: ## @@ -0,0 +1,520 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [lucene] benwtrent commented on a diff in pull request #11860: GITHUB-11830 Better optimize storage for vector connections

2022-11-01 Thread GitBox
benwtrent commented on code in PR #11860: URL: https://github.com/apache/lucene/pull/11860#discussion_r1010321394 ## lucene/core/src/java/org/apache/lucene/util/packed/PackedInts.java: ## @@ -416,6 +416,60 @@ public static interface ReaderIterator { int ord(); } + /**

[GitHub] [lucene] reta commented on pull request #11875: Usability improvements for timeout support in IndexSearcher

2022-11-01 Thread GitBox
reta commented on PR #11875: URL: https://github.com/apache/lucene/pull/11875#issuecomment-1298432816 Thanks @jpountz, no problem at all. > Sorry for the lag I'm on vacation. > > The problem with "this class may be useful outside of Lucene" to me is that it could apply to any c

[GitHub] [lucene] dweiss commented on pull request #11856: Fix nanos to millis conversion for tests

2022-11-01 Thread GitBox
dweiss commented on PR #11856: URL: https://github.com/apache/lucene/pull/11856#issuecomment-1298926451 No worries. I added the missing entry manually. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] romseygeek merged pull request #11879: fix typo 'into into'

2022-11-01 Thread GitBox
romseygeek merged PR #11879: URL: https://github.com/apache/lucene/pull/11879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.