[GitHub] [lucene] dweiss commented on pull request #11872: Update java version to 17 for Lucene 10 in the release wizard.

2022-10-25 Thread GitBox
dweiss commented on PR #11872: URL: https://github.com/apache/lucene/pull/11872#issuecomment-1290386554 Updated Lucene 10's minimum JDK requirement in the release wizard, as per Jan's suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [lucene] dweiss merged pull request #11872: Update java version to 17 for Lucene 10 in the release wizard.

2022-10-25 Thread GitBox
dweiss merged PR #11872: URL: https://github.com/apache/lucene/pull/11872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] harishankar-gopalan commented on issue #11354: Reuse HNSW graphs when merging segments? [LUCENE-10318]

2022-10-25 Thread GitBox
harishankar-gopalan commented on issue #11354: URL: https://github.com/apache/lucene/issues/11354#issuecomment-1290668547 > Update: Sorry for delay, I am still working on this but got a little side tracked with other work. > > > > Hi @harishankar-gopalan, yes what currently ha

[GitHub] [lucene] uschindler commented on pull request #11873: DISCUSSION: Move Lucene Core's log support to Java Platform Logging (JEP 264) facade instead of java.util.logging implementation module

2022-10-25 Thread GitBox
uschindler commented on PR #11873: URL: https://github.com/apache/lucene/pull/11873#issuecomment-1290731341 > This looks fine to me. Migration entry would be probably good here since some folks may be collection JUL logs and parsing messages from there (although for what reason - I've no id

[GitHub] [lucene] rmuir commented on pull request #11873: DISCUSSION: Move Lucene Core's log support to Java Platform Logging (JEP 264) facade instead of java.util.logging implementation module

2022-10-25 Thread GitBox
rmuir commented on PR #11873: URL: https://github.com/apache/lucene/pull/11873#issuecomment-1290734616 Technically it makes sense. The only confusion i have is from the JEP: > Non-Goals It is not a goal to define a general-purpose interface for logging. The service interface

[GitHub] [lucene] uschindler commented on pull request #11873: DISCUSSION: Move Lucene Core's log support to Java Platform Logging (JEP 264) facade instead of java.util.logging implementation module

2022-10-25 Thread GitBox
uschindler commented on PR #11873: URL: https://github.com/apache/lucene/pull/11873#issuecomment-1290737592 > Technically it makes sense. > > The only confusion i have is from the JEP: > > > Non-Goals > > It is not a goal to define a general-purpose interface for logging. The

[GitHub] [lucene] rmuir commented on pull request #11873: DISCUSSION: Move Lucene Core's log support to Java Platform Logging (JEP 264) facade instead of java.util.logging implementation module

2022-10-25 Thread GitBox
rmuir commented on PR #11873: URL: https://github.com/apache/lucene/pull/11873#issuecomment-1290739788 Yeah, I just mean some of their wording in the JEP hints strongly that this is "internal for our use only". Even the first line of the summary: "Define a minimal logging API which *platfor

[GitHub] [lucene] uschindler commented on pull request #11873: DISCUSSION: Move Lucene Core's log support to Java Platform Logging (JEP 264) facade instead of java.util.logging implementation module

2022-10-25 Thread GitBox
uschindler commented on PR #11873: URL: https://github.com/apache/lucene/pull/11873#issuecomment-1290740794 I will keep this open a while. I have also mixed feelings. Logging is a desaster and Java has just thrown another part into the game! -- This is an automated message from the Apache

[GitHub] [lucene] reta opened a new issue, #11874: Usability improvements for timeout support in IndexSearcher

2022-10-25 Thread GitBox
reta opened a new issue, #11874: URL: https://github.com/apache/lucene/issues/11874 ### Description In OpenSearch, we used to rely on custom implementation for query timeouts support. Since `9.3`, Apache Lucene offers the timeout support in the `IndexSearcher` [1] but the implementat

[GitHub] [lucene] dweiss commented on pull request #11873: DISCUSSION: Move Lucene Core's log support to Java Platform Logging (JEP 264) facade instead of java.util.logging implementation module

2022-10-25 Thread GitBox
dweiss commented on PR #11873: URL: https://github.com/apache/lucene/pull/11873#issuecomment-1290776703 > Define a minimal logging API which platform classes can use to log messages This is confusing like hell, isn't it. I admit I didn't even know about this JEP... -- This is an au

[GitHub] [lucene] reta opened a new pull request, #11875: Usability improvements for timeout support in IndexSearcher

2022-10-25 Thread GitBox
reta opened a new pull request, #11875: URL: https://github.com/apache/lucene/pull/11875 Signed-off-by: Andriy Redko ### Description Closes https://github.com/apache/lucene/issues/11874 -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [lucene] reta commented on a diff in pull request #11875: Usability improvements for timeout support in IndexSearcher

2022-10-25 Thread GitBox
reta commented on code in PR #11875: URL: https://github.com/apache/lucene/pull/11875#discussion_r1004673321 ## lucene/core/src/java/org/apache/lucene/search/TimeLimitingBulkScorer.java: ## @@ -28,14 +28,14 @@ * * @see org.apache.lucene.index.ExitableDirectoryReader */ -fi

[GitHub] [lucene] reta commented on a diff in pull request #11875: Usability improvements for timeout support in IndexSearcher

2022-10-25 Thread GitBox
reta commented on code in PR #11875: URL: https://github.com/apache/lucene/pull/11875#discussion_r1004673850 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -519,10 +524,15 @@ public void search(Query query, Collector results) throws IOException {

[GitHub] [lucene] gf2121 opened a new pull request, #11876: Use ByteArrayComparator for PointInSetQuery#MergePointVisitor

2022-10-25 Thread GitBox
gf2121 opened a new pull request, #11876: URL: https://github.com/apache/lucene/pull/11876 This PR proposes to use `ByteArrayComparator` to speed up `PointInSetQuery#MergePointVisitor` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] rmuir commented on pull request #11876: Use ByteArrayComparator for PointInSetQuery#MergePointVisitor

2022-10-25 Thread GitBox
rmuir commented on PR #11876: URL: https://github.com/apache/lucene/pull/11876#issuecomment-1290840923 Looks like it the build is angry about spotless formatting. High level, this makes sense to me. We're just comparing fixed length arrays and we know this length up front (bytesPerDim

[GitHub] [lucene-solr] Trey314159 commented on a diff in pull request #187: LUCENE-7785: Move dictionary for Ukrainan analyzer to external dependency

2022-10-25 Thread GitBox
Trey314159 commented on code in PR #187: URL: https://github.com/apache/lucene-solr/pull/187#discussion_r1004863464 ## lucene/analysis/morfologik/src/java/org/apache/lucene/analysis/uk/UkrainianMorfologikAnalyzer.java: ## @@ -107,11 +107,18 @@ public UkrainianMorfologikAnalyzer(

[GitHub] [lucene] gf2121 commented on pull request #11876: Use ByteArrayComparator for PointInSetQuery#MergePointVisitor

2022-10-25 Thread GitBox
gf2121 commented on PR #11876: URL: https://github.com/apache/lucene/pull/11876#issuecomment-1291530725 Thanks @rmuir ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [lucene] gf2121 merged pull request #11876: Use ByteArrayComparator for PointInSetQuery#MergePointVisitor

2022-10-25 Thread GitBox
gf2121 merged PR #11876: URL: https://github.com/apache/lucene/pull/11876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] gf2121 merged pull request #11877: Use ByteArrayComparator for PointInSetQuery#MergePointVisitor (Backport 9x)

2022-10-25 Thread GitBox
gf2121 merged PR #11877: URL: https://github.com/apache/lucene/pull/11877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] jpountz commented on pull request #11875: Usability improvements for timeout support in IndexSearcher

2022-10-25 Thread GitBox
jpountz commented on PR #11875: URL: https://github.com/apache/lucene/pull/11875#issuecomment-1291573525 Adding a getter works for me, but I'd prefer not to make other implementation details like the custom bulk scorer public, why do you need this? -- This is an automated message from the