[GitHub] [lucene] romseygeek commented on issue #11851: Luke web interface

2022-10-17 Thread GitBox
romseygeek commented on issue #11851: URL: https://github.com/apache/lucene/issues/11851#issuecomment-1280453204 That was marple @dsmiley! Which might be a useful start but is indeed very out of date. It uses node to build the UI, but I'm sure there are better ways to do things now. --

[GitHub] [lucene] matriv opened a new pull request, #11856: Fix nanos to millis conversion for tests

2022-10-17 Thread GitBox
matriv opened a new pull request, #11856: URL: https://github.com/apache/lucene/pull/11856 Fix some wrong division to calculate millis from nanos in tests, after commit that removes System.currentTimeMillis() calls. Follows: fb40a43c0de65950e51380e9bc0b409030c53068 Follows: https:/

[GitHub] [lucene] matriv commented on issue #11459: Remove uses of wall-clock time in codebase [LUCENE-10423]

2022-10-17 Thread GitBox
matriv commented on issue #11459: URL: https://github.com/apache/lucene/issues/11459#issuecomment-1280660003 Thank you @donnerpeter! Opened a PR to address the rest of the incorrect divisions: https://github.com/apache/lucene/pull/11856 /cc @rmuir -- This is an automated message fr

[GitHub] [lucene] dweiss commented on a diff in pull request #11856: Fix nanos to millis conversion for tests

2022-10-17 Thread GitBox
dweiss commented on code in PR #11856: URL: https://github.com/apache/lucene/pull/11856#discussion_r996928969 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/sinks/TestTeeSinkTokenFilter.java: ## @@ -199,7 +199,11 @@ public void performance() throws Exception {

[GitHub] [lucene] matriv commented on a diff in pull request #11856: Fix nanos to millis conversion for tests

2022-10-17 Thread GitBox
matriv commented on code in PR #11856: URL: https://github.com/apache/lucene/pull/11856#discussion_r996932110 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/sinks/TestTeeSinkTokenFilter.java: ## @@ -199,7 +199,11 @@ public void performance() throws Exception {

[GitHub] [lucene] dweiss commented on a diff in pull request #11856: Fix nanos to millis conversion for tests

2022-10-17 Thread GitBox
dweiss commented on code in PR #11856: URL: https://github.com/apache/lucene/pull/11856#discussion_r996934411 ## lucene/analysis/common/src/test/org/apache/lucene/analysis/sinks/TestTeeSinkTokenFilter.java: ## @@ -199,7 +199,11 @@ public void performance() throws Exception {

[GitHub] [lucene] rmuir commented on pull request #11856: Fix nanos to millis conversion for tests

2022-10-17 Thread GitBox
rmuir commented on PR #11856: URL: https://github.com/apache/lucene/pull/11856#issuecomment-1280767858 thank you @matriv for following up here. I like the use of TimeUnit conversion (thanks @dweiss), very easy to read. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [lucene] matriv commented on pull request #11856: Fix nanos to millis conversion for tests

2022-10-17 Thread GitBox
matriv commented on PR #11856: URL: https://github.com/apache/lucene/pull/11856#issuecomment-1280771031 I pushed only for the wrong calculations, will let you know once I've converted all such divisions to use `TimeUnit` instead. -- This is an automated message from the Apache Git Service

[GitHub] [lucene] msokolov commented on a diff in pull request #11852: Luke Webapp

2022-10-17 Thread GitBox
msokolov commented on code in PR #11852: URL: https://github.com/apache/lucene/pull/11852#discussion_r997034628 ## lucene/luke/src/java/org/apache/lucene/luke/app/web/LukeWebMain.java: ## @@ -17,31 +17,78 @@ package org.apache.lucene.luke.app.web; +import java.net.InetSocke

[GitHub] [lucene] msokolov commented on a diff in pull request #11852: Luke Webapp

2022-10-17 Thread GitBox
msokolov commented on code in PR #11852: URL: https://github.com/apache/lucene/pull/11852#discussion_r997035422 ## lucene/luke/src/java/org/apache/lucene/luke/app/web/LukeWebMain.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene] uschindler commented on a diff in pull request #11852: Luke Webapp

2022-10-17 Thread GitBox
uschindler commented on code in PR #11852: URL: https://github.com/apache/lucene/pull/11852#discussion_r997045001 ## lucene/luke/src/java/org/apache/lucene/luke/app/web/LukeWebMain.java: ## @@ -17,31 +17,78 @@ package org.apache.lucene.luke.app.web; +import java.net.InetSoc

[GitHub] [lucene] matriv commented on a diff in pull request #11856: Fix nanos to millis conversion for tests

2022-10-17 Thread GitBox
matriv commented on code in PR #11856: URL: https://github.com/apache/lucene/pull/11856#discussion_r997068202 ## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ## @@ -4190,7 +4190,7 @@ private static Status.SoftDeletsStatus checkSoftDeletes( } private stat

[GitHub] [lucene-solr] risdenk opened a new pull request, #2674: SOLR-16464: Upgrade commons-text to 1.10.0

2022-10-17 Thread GitBox
risdenk opened a new pull request, #2674: URL: https://github.com/apache/lucene-solr/pull/2674 https://issues.apache.org/jira/browse/SOLR-16464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] rmuir commented on a diff in pull request #11852: Luke Webapp

2022-10-17 Thread GitBox
rmuir commented on code in PR #11852: URL: https://github.com/apache/lucene/pull/11852#discussion_r997309676 ## lucene/luke/src/java/org/apache/lucene/luke/app/web/LukeWebMain.java: ## @@ -17,31 +17,78 @@ package org.apache.lucene.luke.app.web; +import java.net.InetSocketAd

[GitHub] [lucene] rmuir commented on a diff in pull request #11852: Luke Webapp

2022-10-17 Thread GitBox
rmuir commented on code in PR #11852: URL: https://github.com/apache/lucene/pull/11852#discussion_r997311191 ## lucene/luke/src/java/org/apache/lucene/luke/app/web/LukeWebMain.java: ## @@ -17,31 +17,78 @@ package org.apache.lucene.luke.app.web; +import java.net.InetSocketAd

[GitHub] [lucene] rmuir commented on a diff in pull request #11857: hunspell: speedup suggestions by caching speller and compound stemming requests

2022-10-17 Thread GitBox
rmuir commented on code in PR #11857: URL: https://github.com/apache/lucene/pull/11857#discussion_r997318423 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java: ## @@ -614,11 +617,27 @@ private void doSuggest( Runnable checkCanceled) {

[GitHub] [lucene-solr] risdenk merged pull request #2674: SOLR-16464: Upgrade commons-text to 1.10.0

2022-10-17 Thread GitBox
risdenk merged PR #2674: URL: https://github.com/apache/lucene-solr/pull/2674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] donnerpeter commented on a diff in pull request #11857: hunspell: speedup suggestions by caching speller and compound stemming requests

2022-10-17 Thread GitBox
donnerpeter commented on code in PR #11857: URL: https://github.com/apache/lucene/pull/11857#discussion_r997326314 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java: ## @@ -614,11 +617,27 @@ private void doSuggest( Runnable checkCanceled

[GitHub] [lucene] rmuir commented on a diff in pull request #11857: hunspell: speedup suggestions by caching speller and compound stemming requests

2022-10-17 Thread GitBox
rmuir commented on code in PR #11857: URL: https://github.com/apache/lucene/pull/11857#discussion_r997328633 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java: ## @@ -614,11 +617,27 @@ private void doSuggest( Runnable checkCanceled) {

[GitHub] [lucene] dweiss commented on a diff in pull request #11857: hunspell: speedup suggestions by caching speller and compound stemming requests

2022-10-17 Thread GitBox
dweiss commented on code in PR #11857: URL: https://github.com/apache/lucene/pull/11857#discussion_r997341034 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java: ## @@ -614,11 +617,27 @@ private void doSuggest( Runnable checkCanceled) {

[GitHub] [lucene] dweiss commented on a diff in pull request #11856: Fix nanos to millis conversion for tests

2022-10-17 Thread GitBox
dweiss commented on code in PR #11856: URL: https://github.com/apache/lucene/pull/11856#discussion_r997342151 ## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ## @@ -4190,7 +4190,7 @@ private static Status.SoftDeletsStatus checkSoftDeletes( } private stat

[GitHub] [lucene] donnerpeter commented on a diff in pull request #11857: hunspell: speedup suggestions by caching speller and compound stemming requests

2022-10-17 Thread GitBox
donnerpeter commented on code in PR #11857: URL: https://github.com/apache/lucene/pull/11857#discussion_r997349204 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java: ## @@ -614,11 +617,27 @@ private void doSuggest( Runnable checkCanceled

[GitHub] [lucene] matriv commented on a diff in pull request #11856: Fix nanos to millis conversion for tests

2022-10-17 Thread GitBox
matriv commented on code in PR #11856: URL: https://github.com/apache/lucene/pull/11856#discussion_r997357120 ## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ## @@ -4190,7 +4190,7 @@ private static Status.SoftDeletsStatus checkSoftDeletes( } private stat

[GitHub] [lucene] dweiss commented on a diff in pull request #11857: hunspell: speedup suggestions by caching speller and compound stemming requests

2022-10-17 Thread GitBox
dweiss commented on code in PR #11857: URL: https://github.com/apache/lucene/pull/11857#discussion_r997417873 ## lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java: ## @@ -614,11 +617,27 @@ private void doSuggest( Runnable checkCanceled) {

[GitHub] [lucene] donnerpeter merged pull request #11857: hunspell: speedup suggestions by caching speller and compound stemming requests

2022-10-17 Thread GitBox
donnerpeter merged PR #11857: URL: https://github.com/apache/lucene/pull/11857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[GitHub] [lucene] benwtrent commented on pull request #11849: Fix failure to load larger data sets in KnnGraphTest

2022-10-17 Thread GitBox
benwtrent commented on PR #11849: URL: https://github.com/apache/lucene/pull/11849#issuecomment-1281604399 @jtibshirani I confirmed that on my M1 Macbook, there is no significant change in QPS, I tested glove-100-angular and deep-image-96-angular -- This is an automated message from the A

[GitHub] [lucene] jtibshirani merged pull request #11849: Fix failure to load larger data sets in KnnGraphTest

2022-10-17 Thread GitBox
jtibshirani merged PR #11849: URL: https://github.com/apache/lucene/pull/11849 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene

[GitHub] [lucene] jtibshirani opened a new issue, #11858: Lucene94HnswVectorsFormat validation fails with large datasets

2022-10-17 Thread GitBox
jtibshirani opened a new issue, #11858: URL: https://github.com/apache/lucene/issues/11858 I ran a test on Lucene 9.4 where I tried to force merge 2 million vectors with dimension 768. It failed with ``` java.lang.IllegalStateException: Vector data length 3070061568 not matching

[GitHub] [lucene] jtibshirani commented on issue #11858: Lucene94HnswVectorsFormat validation fails with large datasets

2022-10-17 Thread GitBox
jtibshirani commented on issue #11858: URL: https://github.com/apache/lucene/issues/11858#issuecomment-1281793284 Here's the stack trace: ``` java.lang.IllegalStateException: Vector data length 3070061568 not matching size=999369 * dim=768 * byteSize=4 = -1224905728 at org.apa

[GitHub] [lucene] harishankar-gopalan commented on pull request #239: LUCENE-10040: Handle deletions in nearest vector search

2022-10-17 Thread GitBox
harishankar-gopalan commented on PR #239: URL: https://github.com/apache/lucene/pull/239#issuecomment-1281844998 Hi @jtibshirani / @msokolov , had a quick doubt on the deletion implementation. From the discussion and changes I understand that for now we have only marked the docs as deleted