uschindler commented on PR #11840:
URL: https://github.com/apache/lucene/pull/11840#issuecomment-1278656494
I think the general idea looks well.
This should me Lucene 10 only, as the changes in query API may break lots of
code downstream. We could theoretically add a backwards combatiilit
jpountz commented on PR #11840:
URL: https://github.com/apache/lucene/pull/11840#issuecomment-1278661850
Agreed on making this Lucene 10.
As far as bw compat is concerned, I was thinking of updating Lucene 9 this
way:
- introduce `Query#rewrite(IndexSearcher)` and make it delegate
rmuir commented on PR #11847:
URL: https://github.com/apache/lucene/pull/11847#issuecomment-1278844737
it absolutely is. Look at the fucking diff dude. You won't sneak this one
past me.
-1 to this interning stuff. I remember what things were like when we made
this mistake before and
dsmiley commented on PR #11847:
URL: https://github.com/apache/lucene/pull/11847#issuecomment-1278967192
Could you comment on the pertinent line of code please? `canonicalStrings`
is not static. Maybe you are thinking of the ThreadLocal? That's some
temporary byte buffer.
--
This is a
almogtavor commented on PR #11852:
URL: https://github.com/apache/lucene/pull/11852#issuecomment-1279032576
@msokolov What are the reasons for choosing to create a web app without a
usage of a web framework such as React? Writing Vanilla will get pretty
cumbersome when things get complex
YmBIgo opened a new issue, #11853:
URL: https://github.com/apache/lucene/issues/11853
### Description
Hi. I want to make Trigram Filter for [CJK
Analyzer](https://github.com/apache/lucene/tree/cc342ea7407c729a743123d8f7957aff6c6f9792/lucene/analysis/common/src/java/org/apache/lucene/a
benwtrent commented on issue #11830:
URL: https://github.com/apache/lucene/issues/11830#issuecomment-1279207529
OK, I ran this patch against minst, sift, glove, and deep image. Recall is
the exact same in all cases, so no mistakes there.
There are indeed slight differences in latency
rmuir commented on code in PR #11852:
URL: https://github.com/apache/lucene/pull/11852#discussion_r995989985
##
lucene/luke/src/java/org/apache/lucene/luke/app/web/LukeWebMain.java:
##
@@ -17,31 +17,78 @@
package org.apache.lucene.luke.app.web;
+import java.net.InetSocketAd
rmuir commented on code in PR #11852:
URL: https://github.com/apache/lucene/pull/11852#discussion_r995991513
##
lucene/luke/src/java/org/apache/lucene/luke/app/web/LukeWebMain.java:
##
@@ -17,31 +17,78 @@
package org.apache.lucene.luke.app.web;
+import java.net.InetSocketAd
rmuir commented on PR #11847:
URL: https://github.com/apache/lucene/pull/11847#issuecomment-1279364308
both are an issue.
The threadlocal will leak badly, especially for cases that "churn" lots of
threads (e.g. jetty defaults, e.g. java webapps). It will cause more harm than
good.
mdmarshmallow commented on PR #11796:
URL: https://github.com/apache/lucene/pull/11796#issuecomment-1279371679
I resolved a merge conflict with `CHANGES.txt`. I think I've also addressed
all the issues people have pointed out as well. Would it be possible for
someone to take a look at this
msokolov commented on code in PR #11852:
URL: https://github.com/apache/lucene/pull/11852#discussion_r996170730
##
lucene/luke/src/java/org/apache/lucene/luke/app/web/LukeWebMain.java:
##
@@ -17,31 +17,78 @@
package org.apache.lucene.luke.app.web;
+import java.net.InetSocke
msokolov commented on PR #11852:
URL: https://github.com/apache/lucene/pull/11852#issuecomment-1279488548
> What are the reasons for choosing to create a web app without a usage of a
web framework such as React? Writing Vanilla will get pretty cumbersome when
things get complex
I don
msokolov commented on PR #11852:
URL: https://github.com/apache/lucene/pull/11852#issuecomment-1279498308
Re: JS frameworks - I recognize my position is from Ludd, and it might be
untenable. If it gets out of hand we can always add something like jQuery, but
we can never remove, so let's st
patsonluk opened a new pull request, #2673:
URL: https://github.com/apache/lucene-solr/pull/2673
## Description
It's found that our prod env have certain data nodes have "ghost replicas"
that do not have data dir but has the core.properties file and core directory.
Replica with same name
patsonluk closed pull request #2673: Flag exception during core creation if the
node defined in state.json is not the same as current node
URL: https://github.com/apache/lucene-solr/pull/2673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jtibshirani commented on issue #11830:
URL: https://github.com/apache/lucene/issues/11830#issuecomment-1279577436
Thanks @benwtrent , the results look promising! It seems like a good time to
open a PR. We might even have ideas for optimizations once we see how the
change looks.
--
This i
dsmiley commented on PR #11847:
URL: https://github.com/apache/lucene/pull/11847#issuecomment-1279653616
The ThreadLocal aspect was a needless addition here; it could be reverted.
> the private map just leaks for the caller by unnecessarily saving strings.
it's a lot of overhead to da
18 matches
Mail list logo
