[GitHub] [lucene] shubhamvishu commented on a diff in pull request #11832: Added static factory method for loading VectorValues

shubhamvishu commented on code in PR #11832: URL: https://github.com/apache/lucene/pull/11832#discussion_r984717340 ## lucene/core/src/java/org/apache/lucene/index/VectorValues.java: ## @@ -35,6 +35,25 @@ public abstract class VectorValues extends DocIdSetIterator { /** Sole

[GitHub] [lucene] shubhamvishu commented on a diff in pull request #11832: Added static factory method for loading VectorValues

shubhamvishu commented on code in PR #11832: URL: https://github.com/apache/lucene/pull/11832#discussion_r984718205 ## lucene/core/src/java/org/apache/lucene/index/CheckIndex.java: ## @@ -2585,7 +2585,7 @@ public static Status.VectorValuesStatus testVectors(

[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #11796: GITHUB#11795: Add FilterDirectory to track write amplification factor

mdmarshmallow commented on code in PR #11796: URL: https://github.com/apache/lucene/pull/11796#discussion_r984889764 ## lucene/misc/src/java/org/apache/lucene/misc/store/ByteWritesTrackingDirectoryWrapper.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [lucene] mdmarshmallow commented on pull request #11796: GITHUB#11795: Add FilterDirectory to track write amplification factor

mdmarshmallow commented on PR #11796: URL: https://github.com/apache/lucene/pull/11796#issuecomment-1263938801 Not sure why the tests are failing as `./gradlew check` passes on my machine. I checked the macos-latest distributions test logs and found this: ``` 2022-09-29T19:53:49.480313

[GitHub] [lucene] mdmarshmallow commented on issue #11761: Expand TieredMergePolicy deletePctAllowed limits

mdmarshmallow commented on issue #11761: URL: https://github.com/apache/lucene/issues/11761#issuecomment-1264018168 I can include that in the above PR as well if you all agree that it's a good idea. -- This is an automated message from the Apache Git Service. To respond to the message, pl