[GitHub] [lucene] iverase opened a new issue, #11824: Performance regression on LatLonPoint#newPolygonQuery

iverase opened a new issue, #11824: URL: https://github.com/apache/lucene/issues/11824 ### Description I just notice a big performance regression on polygon queries using LatLonPoint field in [lucene geo benchmarks](https://home.apache.org/~mikemccand/geobench.html): https://u

[GitHub] [lucene] jpountz commented on pull request #11796: GITHUB#11795: Add FilterDirectory to track write amplification factor

jpountz commented on PR #11796: URL: https://github.com/apache/lucene/pull/11796#issuecomment-1259137841 > Interesting point.. Thinking how/when we'd like to track the impact of temp output files. From what I understand, they won't be a part of commit and fsync. So if we're trying to measur

[GitHub] [lucene] iverase opened a new pull request, #11825: Build SpatialVisitor once per index

iverase opened a new pull request, #11825: URL: https://github.com/apache/lucene/pull/11825 see https://github.com/apache/lucene/issues/11824 I am not adding an entry in changes as this is an unreleased bug. If it does not make to Lucene 8.4 then we should add it. -- This is an aut

[GitHub] [lucene] jpountz commented on pull request #11825: Build SpatialVisitor once per index

jpountz commented on PR #11825: URL: https://github.com/apache/lucene/pull/11825#issuecomment-1259183151 Have you managed to confirm that it addressed the performance regression? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] iverase commented on pull request #11825: Build SpatialVisitor once per index

iverase commented on PR #11825: URL: https://github.com/apache/lucene/pull/11825#issuecomment-1259185529 Yes, I did -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [lucene] iverase merged pull request #11825: Build SpatialVisitor once per index

iverase merged PR #11825: URL: https://github.com/apache/lucene/pull/11825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[GitHub] [lucene] uschindler commented on pull request #11825: Build SpatialVisitor once per index

uschindler commented on PR #11825: URL: https://github.com/apache/lucene/pull/11825#issuecomment-1259209942 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [lucene] uschindler commented on pull request #11823: GH-11819: Fix the Eclipse part to support development of the MR-JAR in IDE

uschindler commented on PR #11823: URL: https://github.com/apache/lucene/pull/11823#issuecomment-1259214503 This PR also removes an obsolete XSL file used by Ant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] uschindler merged pull request #11823: GH-11819: Fix the Eclipse part to support development of the MR-JAR in IDE

uschindler merged PR #11823: URL: https://github.com/apache/lucene/pull/11823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] uschindler commented on issue #11819: Fix Java 19 MR-JAR compilation in IDEs

uschindler commented on issue #11819: URL: https://github.com/apache/lucene/issues/11819#issuecomment-1259220386 I merged the Eclipse part. Robert yesterday tried to get hold of IDEA, but it looks like it is "mostly working" if you set the Java versions correctly (to 19). It looks like Idea

[GitHub] [lucene] uschindler opened a new pull request, #11826: Let smoketester initialize local settings before running any checks (like Github CI or Jenkins)

uschindler opened a new pull request, #11826: URL: https://github.com/apache/lucene/pull/11826 This closes #11820. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [lucene] uschindler commented on issue #11820: smoketester needs to run 'gradlew localSettings' first

uschindler commented on issue #11820: URL: https://github.com/apache/lucene/issues/11820#issuecomment-1259230934 I have a simple PR: #11826 We can introduce more advanced solutions like editing gradlew.sh/bat later. This should fix the issue. -- This is an automated message from th

[GitHub] [lucene] iverase closed issue #11824: Performance regression on LatLonPoint#newPolygonQuery

iverase closed issue #11824: Performance regression on LatLonPoint#newPolygonQuery URL: https://github.com/apache/lucene/issues/11824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [lucene] iverase commented on issue #11824: Performance regression on LatLonPoint#newPolygonQuery

iverase commented on issue #11824: URL: https://github.com/apache/lucene/issues/11824#issuecomment-1259240627 close in https://github.com/apache/lucene/pull/11825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] uschindler closed issue #11820: smoketester needs to run 'gradlew localSettings' first

uschindler closed issue #11820: smoketester needs to run 'gradlew localSettings' first URL: https://github.com/apache/lucene/issues/11820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [lucene] uschindler merged pull request #11826: Let smoketester initialize local settings before running any checks (like Github CI or Jenkins)

uschindler merged PR #11826: URL: https://github.com/apache/lucene/pull/11826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] rmuir commented on issue #11819: Fix Java 19 MR-JAR compilation in IDEs

rmuir commented on issue #11819: URL: https://github.com/apache/lucene/issues/11819#issuecomment-125935 i tried wrestling with it, but i'm not sure i even held it properly. ultimately i was able to get it to work by setting entire project to java 19. this works for now, because "mr-jar"

[GitHub] [lucene] rmuir commented on issue #11820: smoketester needs to run 'gradlew localSettings' first

rmuir commented on issue #11820: URL: https://github.com/apache/lucene/issues/11820#issuecomment-1259358447 thanks @uschindler ! it works now without any hassles. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [lucene] gsmiller commented on pull request #11803: DrillSideways optimizations

gsmiller commented on PR #11803: URL: https://github.com/apache/lucene/pull/11803#issuecomment-1259557102 > Changes LGTM, do we need to add some unit tests? Thanks @zhaih. Let me consider some specific test for this. I know our randomized testing for DrillSideways covers these code pa

[GitHub] [lucene] iverase opened a new issue, #11827: Release manager should review lucene benchmarks before building release candidates

iverase opened a new issue, #11827: URL: https://github.com/apache/lucene/issues/11827 ### Description We were about to release Lucene 9.4.0 with an important performance regression. This regression was showing up in the benchmarks but obviously we missed reviewing them. The regressi

[GitHub] [lucene] gsmiller opened a new pull request, #11828: TermInSetQuery optimization when all docs in a field match a term

gsmiller opened a new pull request, #11828: URL: https://github.com/apache/lucene/pull/11828 ### Description This changes the optimization present in `TermInSetQuery` to mimic the one in `MultiTermQueryConstantScoreWrapper`, bringing parity to the two approaches. More specifically, i

[GitHub] [lucene] jpountz commented on issue #11592: Relax the maximum dirtiness for stored fields and term vectors? [LUCENE-10556]

jpountz commented on issue #11592: URL: https://github.com/apache/lucene/issues/11592#issuecomment-1259677572 Updated numbers now that TMP no longer runs quadratic merges, and BEST_COMPRESSION: |Dirtiness|Indexing time (msec)| |-|-| |0%|27219| |1%|26897| |5%|27196| |20%

[GitHub] [lucene] jpountz closed issue #11592: Relax the maximum dirtiness for stored fields and term vectors? [LUCENE-10556]

jpountz closed issue #11592: Relax the maximum dirtiness for stored fields and term vectors? [LUCENE-10556] URL: https://github.com/apache/lucene/issues/11592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene] dweiss commented on issue #11819: Fix Java 19 MR-JAR compilation in IDEs

dweiss commented on issue #11819: URL: https://github.com/apache/lucene/issues/11819#issuecomment-1259684070 (away until the next of the week, guys - out of reach). bb on sunday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene] nknize commented on issue #11824: Performance regression on LatLonPoint#newPolygonQuery

nknize commented on issue #11824: URL: https://github.com/apache/lucene/issues/11824#issuecomment-1259733493 Just seeing this. That's exactly what it would be! Snuck in one of those last commits on the long running PR. Thanks for refactoring and merging @iverase! -- This is an automated

[GitHub] [lucene] rmuir commented on issue #11827: Release manager should review lucene benchmarks before building release candidates

rmuir commented on issue #11827: URL: https://github.com/apache/lucene/issues/11827#issuecomment-1259797860 i think a good step is to just make sure that we review the benchmark results before releasing and send an email out about anything that looks suspicious. -- This is an automated m

[GitHub] [lucene] jpountz commented on a diff in pull request #11722: Binary search the entries when all suffixes have the same length in a leaf block.

jpountz commented on code in PR #11722: URL: https://github.com/apache/lucene/pull/11722#discussion_r981512784 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/BasePostingsFormatTestCase.java: ## @@ -367,6 +367,49 @@ public void testGhosts() throws Exception {

[GitHub] [lucene] elliotzlin commented on pull request #11724: LUCENE-10520 / #11556 HTMLStripCharFilter bugfix

elliotzlin commented on PR #11724: URL: https://github.com/apache/lucene/pull/11724#issuecomment-1259830640 @rmuir would you be able to help with running the workflows? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [lucene] msokolov commented on issue #11827: Release manager should review lucene benchmarks before building release candidates

msokolov commented on issue #11827: URL: https://github.com/apache/lucene/issues/11827#issuecomment-1259830880 yup. Possibly too if Mike M is bored he could implement an alarming system :) or export the data somehow so we could bolt one on the side? -- This is an automated message fro

[GitHub] [lucene] kaivalnp closed pull request #1059: Refactor KnnGraphTester

kaivalnp closed pull request #1059: Refactor KnnGraphTester URL: https://github.com/apache/lucene/pull/1059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma