danmuzi commented on code in PR #11784:
URL: https://github.com/apache/lucene/pull/11784#discussion_r978324992
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -46,27 +45,23 @@ public NeighborArray(int maxSize, boolean descOrder) {
* nodes.
*
LuXugang commented on code in PR #687:
URL: https://github.com/apache/lucene/pull/687#discussion_r978331854
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java:
##
@@ -214,12 +221,172 @@ public int count(LeafReaderContext co
danmuzi commented on code in PR #11784:
URL: https://github.com/apache/lucene/pull/11784#discussion_r978324992
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -46,27 +45,23 @@ public NeighborArray(int maxSize, boolean descOrder) {
* nodes.
*
danmuzi commented on code in PR #11784:
URL: https://github.com/apache/lucene/pull/11784#discussion_r978324992
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -46,27 +45,23 @@ public NeighborArray(int maxSize, boolean descOrder) {
* nodes.
*
gcbaptista commented on issue #11800:
URL: https://github.com/apache/lucene/issues/11800#issuecomment-1255984965
So why isn't this method escaping `@` then?
https://github.com/apache/lucene/blob/5b24a233bdfd2c1feb177a5de4fc5eb62baf6015/lucene/queryparser/src/java/org/apache/lucene/que
dweiss commented on issue #11800:
URL: https://github.com/apache/lucene/issues/11800#issuecomment-1256036589
Note this class is in a different package - it's a different query parser.
There are many. They all behave differently. It's a project with long history.
--
This is an automated me
dweiss commented on PR #11734:
URL: https://github.com/apache/lucene/pull/11734#issuecomment-1256055653
I rebased your commits on top of main so that they're linear when merged.
Waiting for builds to pass.
--
This is an automated message from the Apache Git Service.
To respond to the mess
gcbaptista commented on issue #11800:
URL: https://github.com/apache/lucene/issues/11800#issuecomment-1256055850
OK, thank you very much for the clarification 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dweiss closed issue #11800: INVALID_SYNTAX_CANNOT_PARSE for at sign (@)
URL: https://github.com/apache/lucene/issues/11800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
dweiss merged PR #11734:
URL: https://github.com/apache/lucene/pull/11734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
dweiss closed issue #11771: KeywordRepeatFilter + OpenNLPLemmatizer Early Exit
URL: https://github.com/apache/lucene/issues/11771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dweiss closed issue #11735: Incorrect sentence boundaries with repeating tokens
in OpenNLP package
URL: https://github.com/apache/lucene/issues/11735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dweiss commented on PR #11734:
URL: https://github.com/apache/lucene/pull/11734#issuecomment-1256090394
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
rmuir commented on PR #11738:
URL: https://github.com/apache/lucene/pull/11738#issuecomment-1256102333
nope, looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
rmuir commented on issue #11805:
URL: https://github.com/apache/lucene/issues/11805#issuecomment-1256105188
no. use of `Thread.interrupt` is not safe because if a thread is blocked on
io it will close its file handle in java.
--
This is an automated message from the Apache Git Service.
To
romseygeek opened a new pull request, #11807:
URL: https://github.com/apache/lucene/pull/11807
### Description
Since QueryVisitor added the ability to signal multi-term queries, the query
rewrite
call in UnifiedHighlighter has been essentially useless, and with more
aggressive
jpountz commented on PR #11722:
URL: https://github.com/apache/lucene/pull/11722#issuecomment-1256184937
> I may add this test case to BasePostingsFormatTestCase, or do you have any
other idea on test?
1M documents is too much for a unit test, I was thinking of a smaller
dataset, e.g
jpountz commented on PR #11796:
URL: https://github.com/apache/lucene/pull/11796#issuecomment-1256199718
This implementation ignores temporary index outputs from write
amplification, which I wonder whether this is correct (maybe it is, I struggle
making an opinion on this question).
--
T
reta commented on issue #11788:
URL: https://github.com/apache/lucene/issues/11788#issuecomment-1256210216
:+1: thanks @rmuir, I will start with tests first (with respect to the
changes needed) and we could make the decision having the evidence / numbers at
hand.
--
This is an automated
romseygeek opened a new pull request, #11808:
URL: https://github.com/apache/lucene/pull/11808
### Description
The UnifiedHighlighter can throw exceptions when highlighting terms that are
longer
than the maximum size the DaciukMihovAutomatonBuilder accepts. Rather than
throwing
kotman12 commented on PR #11734:
URL: https://github.com/apache/lucene/pull/11734#issuecomment-1256263228
Thanks as well for taking a look 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
HoustonPutman commented on PR #2671:
URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1256342520
Hey Josh, thanks for this. All development is done primarily through the
https://github.com/apache/solr repo now, then after merging we will backport to
older versions (possibly
thongnt99 commented on issue #11799:
URL: https://github.com/apache/lucene/issues/11799#issuecomment-1256416719
I confirmed @jpountz approach working. In my dataset, the indexing time
goes down from more than 1 hours to ~ 10 minutes.
A small issue, the weight in `FeatureField.newLinea
HoustonPutman commented on PR #2671:
URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1256423745
If you can get a JIRA created soon, I'll try to get this in today before the
9.1 release.
--
This is an automated message from the Apache Git Service.
To respond to the messag
jpountz commented on issue #11799:
URL: https://github.com/apache/lucene/issues/11799#issuecomment-1256425435
This is a good point. This limit was introduced with the idea that
`FeatureField` would be used to incorporate features into a BM25/TFIDF/DFR
score and higher weights than 64 would
vigyasharma commented on PR #11796:
URL: https://github.com/apache/lucene/pull/11796#issuecomment-1256430088
> This implementation ignores temporary index outputs from write
amplification, which I wonder whether this is correct (maybe it is, I struggle
making an opinion on this question).
dsmiley commented on PR #11796:
URL: https://github.com/apache/lucene/pull/11796#issuecomment-1256431118
This is nifty!
I wonder if it'd be worthwhile for Lucene itself to track this small bit of
metadata so that it's persistent?
--
This is an automated message from the Apache Git Se
thongnt99 commented on issue #11799:
URL: https://github.com/apache/lucene/issues/11799#issuecomment-1256442806
Yes, I think that would be nicer to have dedicated classes for LSR? Though
using FeatureField is efficient, I feels it is still a bit of hacking.
If we replaced FeatureQuery w
taroplus opened a new issue, #11809:
URL: https://github.com/apache/lucene/issues/11809
### Description
Hello, I have a very lengthy string to search with, basically
```
String term = "very-lengthy-text-contains-dots-and-dashes";
```
When I try to create a Wildcard
shahrs87 commented on PR #907:
URL: https://github.com/apache/lucene/pull/907#issuecomment-1256448795
I was busy with some other security related work at my day job so couldn't
update this PR. Apologies for that.
@jpountz Can you please review this PR again ?
--
This is an automated
joshsouza commented on PR #2671:
URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1256461704
https://issues.apache.org/jira/browse/SOLR-16429 created, I'm working on
getting a PR set up, should be up momentarily.
Any chance this might end up backported to 8? There's n
joshsouza commented on PR #2671:
URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1256462290
https://github.com/apache/solr/pull/1042
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rmuir commented on issue #11809:
URL: https://github.com/apache/lucene/issues/11809#issuecomment-1256465997
not sure it is still an issue for `main` branch as i don't have the full
stacktrace. however i would recommend using TermInSetQuery instead of the large
regex you have that seems to r
HoustonPutman commented on PR #2671:
URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1256475948
Yeah we can get this backported. Also sorry about putting up a PR first,
just wanted to get this in and out before my trip once I saw how
straightforward it was. I made sure to
joshsouza commented on PR #2671:
URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1256483605
@HoustonPutman No worries. Thanks for your help (and incredibly fast
response!) on this!
Should we go ahead and close out this PR? I'm a fish out of water here.
--
This is an a
HoustonPutman commented on PR #2671:
URL: https://github.com/apache/lucene-solr/pull/2671#issuecomment-1256486843
We can leave this open for now! We'll just leave it for now and pick it up
whenever we are ready to backport
--
This is an automated message from the Apache Git Service.
To re
shahrs87 commented on issue #11479:
URL: https://github.com/apache/lucene/issues/11479#issuecomment-1256508467
> SparseFixedBItSet is no longer used by DocIdSetBuilder, but the class
didn't get cleaned up and removed.
In main branch, SparseFixedBItSet is used by `UnicodeProps`,
`Luce
taroplus commented on issue #11809:
URL: https://github.com/apache/lucene/issues/11809#issuecomment-1256518868
stacktrace is long
```
java.lang.IllegalArgumentException: input automaton is too large: 1001
at
org.apache.lucene.util.automaton.Operations.isFinite(Operations.ja
dweiss commented on issue #11771:
URL: https://github.com/apache/lucene/issues/11771#issuecomment-1256525265
https://ci-builds.apache.org/job/Lucene/job/Lucene-Check-9.x/3057/
Hmm... this patch applied to 9x fails the tests. Could you take a look at
that, @kotman12 ?
--
This is an
dweiss commented on issue #11771:
URL: https://github.com/apache/lucene/issues/11771#issuecomment-1256534557
I can reproduce those failures with JDK11 but not with JDK17. I didn't look
into this deeper.
--
This is an automated message from the Apache Git Service.
To respond to the message
taroplus commented on issue #11809:
URL: https://github.com/apache/lucene/issues/11809#issuecomment-1256541453
Tried with the latest commit, it happens. it's not regex, it's just `*`
after a plain text. I'm just trying to run a prefix query (same happens with
PrefixQuery too)
--
This is
rmuir commented on issue #11809:
URL: https://github.com/apache/lucene/issues/11809#issuecomment-1256553025
ok, thanks for reporting. I will dig more into this.
The problem is that `isFinite` is implemented recursively, so we have a
defensive check that you are hitting, due to the len
kotman12 commented on issue #11771:
URL: https://github.com/apache/lucene/issues/11771#issuecomment-1256604231
Very, very interesting .. will take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kotman12 opened a new pull request, #11810:
URL: https://github.com/apache/lucene/pull/11810
this check is incorrect and will fail in older jdk versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kotman12 commented on issue #11771:
URL: https://github.com/apache/lucene/issues/11771#issuecomment-1256641710
So [this change](https://github.com/apache/lucene/pull/11810/files) seems to
fix the test **locally** for me in branch 9x .. Created a PR for the upstream
.. not sure how you want
HoustonPutman commented on PR #2670:
URL: https://github.com/apache/lucene-solr/pull/2670#issuecomment-1256675583
Sorry tried to get the tests to pass and test this, but it never worked for
me 😕
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
vsop-479 commented on PR #11722:
URL: https://github.com/apache/lucene/pull/11722#issuecomment-1256739176
> 200 fixed-size IDs and we'd make sure that the binary search works as
expected for both `seekCeil` and `seekExact` for every of these 200 terms as
well as other terms that compare
47 matches
Mail list logo
